Message ID | 20221108140614.12968-1-yuehaibing@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2728737wru; Tue, 8 Nov 2022 06:08:40 -0800 (PST) X-Google-Smtp-Source: AMsMyM6mii8VIVgN/o3xotZSKvswkL9n3Wffa8SumconRPw64X6rJsqv7yuiZUOzYtgVGfx/o3Qz X-Received: by 2002:a17:906:9c84:b0:7ad:90d9:a6cf with SMTP id fj4-20020a1709069c8400b007ad90d9a6cfmr52240332ejc.595.1667916520519; Tue, 08 Nov 2022 06:08:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667916520; cv=none; d=google.com; s=arc-20160816; b=w+QSFylhIUVlfDl/HiOysdwW49lUcowdek7VKASA6Esu/kcUBWE1lluyuUBEVszZL7 sVf+YR8Cl+yJe+ao43GItPPC6szwnEpbq7Vw650J1C8EphofZCxpa7Y6+kItqfcxMCtJ BNPUQp+ihS8ZDZBpFJF8Bf+9v9oum4oDR8wFIC8IHs+1MylLXkqEPsAhovxRHDSNRTV/ e0qHy2IpJ9yG6VZcRtChdhf3Y6c449Da1+j8Hqpao8YCOoepYjvy0L8BH4I+5DW0DHx0 TtuuarclGgYn6pv4P9//4ybFo1UgF6Zh9z1ZGugLC9ZzCTMOQhRAZZw8X1mV5NFkIJGc Kqcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=hfiHWwUcciTEfobhyWsoJDIaXzUj9i9jF/CsVM3xiDk=; b=m+v7Vwzkrni2/DbQKcATEJULw5iPGWnBlW/l4ZREG0bP7XxDILpbgvy+Kn+RHniS8B gJuWif0s5+LksXY9Hw+1RNz7MbFCdEp8rHJVL/usyH2nItExGVBHQu9EjQcs5Lfd6ags R5vGDWialaSqFJ3kuDHu8pJ++ZV5jA822tQ6PdvtlMaRbNCwaix3r+nS8YcPAeBuVZxc UQQjHwk12FqZm55dsmfb4zt8QtO4RBmxxRdOJ2UwWzW3g/HBHIG5br5dECg1zU5XTBCa E/ox9mHcAuAMZiALGk6Af7pNigsYRyWzpai1nfmgwQPYXg7DCpmQOvYnT6Fx36FVrUNW NKcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bb2-20020a1709070a0200b00783ddc8b643si13825149ejc.317.2022.11.08.06.08.15; Tue, 08 Nov 2022 06:08:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235128AbiKHOHp (ORCPT <rfc822;david.rheinsberg@gmail.com> + 99 others); Tue, 8 Nov 2022 09:07:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbiKHOHd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 8 Nov 2022 09:07:33 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13C1A748C1; Tue, 8 Nov 2022 06:07:32 -0800 (PST) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N69096sZQzRp4C; Tue, 8 Nov 2022 22:07:21 +0800 (CST) Received: from localhost (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 22:07:29 +0800 From: YueHaibing <yuehaibing@huawei.com> To: <borisp@nvidia.com>, <saeedm@nvidia.com>, <leon@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>, <lkayal@nvidia.com>, <tariqt@nvidia.com>, <markzhang@nvidia.com> CC: <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>, YueHaibing <yuehaibing@huawei.com> Subject: [PATCH v2] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create() Date: Tue, 8 Nov 2022 22:06:14 +0800 Message-ID: <20221108140614.12968-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748933628805180481?= X-GMAIL-MSGID: =?utf-8?q?1748937233533814129?= |
Series |
[v2] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create()
|
|
Commit Message
Yue Haibing
Nov. 8, 2022, 2:06 p.m. UTC
'accel_tcp' is allocted by kvzalloc(), which should freed by kvfree().
Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix the same issue in mlx5e_accel_fs_tcp_destroy() and a commit log typo
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 11/8/2022 4:06 PM, YueHaibing wrote: > 'accel_tcp' is allocted by kvzalloc(), which should freed by kvfree(). > > Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: fix the same issue in mlx5e_accel_fs_tcp_destroy() and a commit log typo > --- > drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c > index 285d32d2fd08..d7c020f72401 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c > @@ -365,7 +365,7 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs) > for (i = 0; i < ACCEL_FS_TCP_NUM_TYPES; i++) > accel_fs_tcp_destroy_table(fs, i); > > - kfree(accel_tcp); > + kvfree(accel_tcp); > mlx5e_fs_set_accel_tcp(fs, NULL); > } > > @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs) > err_destroy_tables: > while (--i >= 0) > accel_fs_tcp_destroy_table(fs, i); > - kfree(accel_tcp); > + kvfree(accel_tcp); > mlx5e_fs_set_accel_tcp(fs, NULL); > return err; > } Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Thanks for your patch.
On Tue, Nov 8, 2022 at 9:58 AM Tariq Toukan <ttoukan.linux@gmail.com> wrote: > > > > On 11/8/2022 4:06 PM, YueHaibing wrote: > > 'accel_tcp' is allocted by kvzalloc(), which should freed by kvfree(). > > > > Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > v2: fix the same issue in mlx5e_accel_fs_tcp_destroy() and a commit log typo > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c > > index 285d32d2fd08..d7c020f72401 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c > > @@ -365,7 +365,7 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs) > > for (i = 0; i < ACCEL_FS_TCP_NUM_TYPES; i++) > > accel_fs_tcp_destroy_table(fs, i); > > > > - kfree(accel_tcp); > > + kvfree(accel_tcp); > > mlx5e_fs_set_accel_tcp(fs, NULL); > > } > > > > @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs) > > err_destroy_tables: > > while (--i >= 0) > > accel_fs_tcp_destroy_table(fs, i); > > - kfree(accel_tcp); > > + kvfree(accel_tcp); > > mlx5e_fs_set_accel_tcp(fs, NULL); > > return err; > > } > > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> > > Thanks for your patch. Although this structure is 64 bytes... Not sure why kvmalloc() has been used for this small chunk.
On 11/8/2022 9:45 PM, Eric Dumazet wrote: > On Tue, Nov 8, 2022 at 9:58 AM Tariq Toukan <ttoukan.linux@gmail.com> wrote: >> >> >> >> On 11/8/2022 4:06 PM, YueHaibing wrote: >>> 'accel_tcp' is allocted by kvzalloc(), which should freed by kvfree(). >>> >>> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API") >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>> --- >>> v2: fix the same issue in mlx5e_accel_fs_tcp_destroy() and a commit log typo >>> --- >>> drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c >>> index 285d32d2fd08..d7c020f72401 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c >>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c >>> @@ -365,7 +365,7 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs) >>> for (i = 0; i < ACCEL_FS_TCP_NUM_TYPES; i++) >>> accel_fs_tcp_destroy_table(fs, i); >>> >>> - kfree(accel_tcp); >>> + kvfree(accel_tcp); >>> mlx5e_fs_set_accel_tcp(fs, NULL); >>> } >>> >>> @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs) >>> err_destroy_tables: >>> while (--i >= 0) >>> accel_fs_tcp_destroy_table(fs, i); >>> - kfree(accel_tcp); >>> + kvfree(accel_tcp); >>> mlx5e_fs_set_accel_tcp(fs, NULL); >>> return err; >>> } >> >> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> >> >> Thanks for your patch. > > Although this structure is 64 bytes... Not sure why kvmalloc() has > been used for this small chunk. It's a small chunk indeed. Unnecessary usage of kvmalloc. Although it's not critical (used only in slowpath), it'd be nice to clean it up and directly call kzalloc, instead of aligning the kfree(). YueHaibing, can you please submit a v3 for this? Regards, Tariq
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c index 285d32d2fd08..d7c020f72401 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c @@ -365,7 +365,7 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs) for (i = 0; i < ACCEL_FS_TCP_NUM_TYPES; i++) accel_fs_tcp_destroy_table(fs, i); - kfree(accel_tcp); + kvfree(accel_tcp); mlx5e_fs_set_accel_tcp(fs, NULL); } @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs) err_destroy_tables: while (--i >= 0) accel_fs_tcp_destroy_table(fs, i); - kfree(accel_tcp); + kvfree(accel_tcp); mlx5e_fs_set_accel_tcp(fs, NULL); return err; }