diff mbox series

[net-next,1/1] net: phy: dp83867: add TI PHY loopback

Message ID 20221108101527.612723-1-michael.wei.hong.sit@intel.com
State New
Headers
Series [net-next,1/1] net: phy: dp83867: add TI PHY loopback |

Commit Message

Sit, Michael Wei Hong Nov. 8, 2022, 10:15 a.m. UTC 
  From: Tan Tee Min <tee.min.tan@linux.intel.com>

The existing genphy_loopback() is not working for TI DP83867 PHY as it
will disable autoneg support while another side is still enabling autoneg.
This is causing the link is not established and results in timeout error
in genphy_loopback() function.

Thus, based on TI PHY datasheet, introduce a TI PHY loopback function by
just configuring BMCR_LOOPBACK(Bit-9) in MII_BMCR register (0x0).

Tested working on TI DP83867 PHY for all speeds (10/100/1000Mbps).

Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
---
 drivers/net/phy/dp83867.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andrew Lunn Nov. 8, 2022, 3:44 p.m. UTC | #1 
On Tue, Nov 08, 2022 at 06:15:27PM +0800, Michael Sit Wei Hong wrote:
> From: Tan Tee Min <tee.min.tan@linux.intel.com>
> 
> The existing genphy_loopback() is not working for TI DP83867 PHY as it
> will disable autoneg support while another side is still enabling autoneg.
> This is causing the link is not established and results in timeout error
> in genphy_loopback() function.
> 
> Thus, based on TI PHY datasheet, introduce a TI PHY loopback function by
> just configuring BMCR_LOOPBACK(Bit-9) in MII_BMCR register (0x0).
> 
> Tested working on TI DP83867 PHY for all speeds (10/100/1000Mbps).
> 
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org Nov. 10, 2022, 3:30 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  8 Nov 2022 18:15:27 +0800 you wrote:
> From: Tan Tee Min <tee.min.tan@linux.intel.com>
> 
> The existing genphy_loopback() is not working for TI DP83867 PHY as it
> will disable autoneg support while another side is still enabling autoneg.
> This is causing the link is not established and results in timeout error
> in genphy_loopback() function.
> 
> [...]

Here is the summary with links:
  - [net-next,1/1] net: phy: dp83867: add TI PHY loopback
    https://git.kernel.org/netdev/net-next/c/13bd85580b85

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 6939563d3b7c..350217a23b34 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -925,6 +925,12 @@  static void dp83867_link_change_notify(struct phy_device *phydev)
 	}
 }
 
+static int dp83867_loopback(struct phy_device *phydev, bool enable)
+{
+	return phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK,
+			  enable ? BMCR_LOOPBACK : 0);
+}
+
 static struct phy_driver dp83867_driver[] = {
 	{
 		.phy_id		= DP83867_PHY_ID,
@@ -951,6 +957,7 @@  static struct phy_driver dp83867_driver[] = {
 		.resume		= genphy_resume,
 
 		.link_change_notify = dp83867_link_change_notify,
+		.set_loopback	= dp83867_loopback,
 	},
 };
 module_phy_driver(dp83867_driver);