From patchwork Tue Nov 8 04:52:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 16865 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2485186wru; Mon, 7 Nov 2022 20:55:18 -0800 (PST) X-Google-Smtp-Source: AMsMyM48RVTljOE+kxrmIXyS1asK13J4mZydwNylbWdHBSbBV4jwofcM5ABxjs4AzGs9OQAMItYP X-Received: by 2002:a17:906:8a57:b0:7ad:69fb:3a with SMTP id gx23-20020a1709068a5700b007ad69fb003amr49866725ejc.179.1667883318331; Mon, 07 Nov 2022 20:55:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667883318; cv=none; d=google.com; s=arc-20160816; b=RgpVAHJl+/h4rIO3qwQn4ahA8MkDwUoXDVMc5LKlx44shoy4Mf+8BKCt1J4w+p8Ntx qKdd4GH/EZ8PWRIOj9owsZW93bWvtuLH9gnKhFbRQ4Yu91WJuO5PVNSaA9+27/5KhOnv pk4cdfokp93MP55vEOR3noF8rOQw3TN7whroz+QXZRdgBWYZnqUz2uByKt81NQAU49Vc DbrIBZDeZbhbeyw7nVFjFQFh9NbY7YFebm2W++W9ER9Q1JdRCLqZfGjt2N7ZoQ8raPFQ X/CMJImokkdxs8RIG8H5FtMXeLGH/Zaq1gJQAZIEZ8d7/x40Dr524i6DdfGHTGHhlqpe llEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=nwIyP8sfa7W7QTv+lh5zr76n7mBm//mbeRytK4uzegM=; b=JZwtpSXQh4umpjmWfsC2GYZXm+xdmhG4u6ceF7dNiMClKqY8aiGJ/66Dfdz8S9bSve 9Moo0CMnQKACMF1gl4VnfkBSjwkveTP3iCSGvBL1srQszqp02wZkQ9/oeY7W1S7Eqr74 o2qd4i2cHttfqPjbk2IhCQCAyUqIbeTwXaUO44/6qyUOwKFZn30KMZIDkLYyzUZgFLKd hjqHISxQDCSKSf9N3Yf+F7kHs8kB5FJRVbc5NkL1sSxqP3Is/aFyNks3YyG++4lot465 nfM9A1022VOiF5oHIdLDduRuY73qbfjvKGqrJrR6ZACbjBj1HA3ElxFmFiLhzxKQx/LR Q9nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a17090658ca00b007a835c56b70si12093102ejs.267.2022.11.07.20.54.53; Mon, 07 Nov 2022 20:55:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233371AbiKHExi (ORCPT + 99 others); Mon, 7 Nov 2022 23:53:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233175AbiKHEwo (ORCPT ); Mon, 7 Nov 2022 23:52:44 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1889F326F9; Mon, 7 Nov 2022 20:52:36 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4N5wcZ1b8DzJnVD; Tue, 8 Nov 2022 12:49:34 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 12:52:33 +0800 From: Kemeng Shi To: , CC: , , Subject: [PATCH 10/10] block, bfq: remove check of bfq_wr_max_softrt_rate which is always greater than 0 Date: Tue, 8 Nov 2022 12:52:24 +0800 Message-ID: <20221108045224.19092-11-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221108045224.19092-1-shikemeng@huawei.com> References: <20221108045224.19092-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748902418834558657?= X-GMAIL-MSGID: =?utf-8?q?1748902418834558657?= bfqd->bfq_wr_max_softrt_rate is assigned with 7000 in bfq_init_queue and never changed. So we can remove bfqd->bfq_wr_max_softrt_rate > 0 check which is always true. Signed-off-by: Kemeng Shi --- block/bfq-iosched.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 40ac219b2d8f..d0a867b2569b 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -1840,8 +1840,7 @@ static void bfq_bfqq_handle_idle_busy_switch(struct bfq_data *bfqd, * to control its weight explicitly) */ in_burst = bfq_bfqq_in_large_burst(bfqq); - soft_rt = bfqd->bfq_wr_max_softrt_rate > 0 && - !BFQQ_TOTALLY_SEEKY(bfqq) && + soft_rt = !BFQQ_TOTALLY_SEEKY(bfqq) && !in_burst && time_is_before_jiffies(bfqq->soft_rt_next_start) && bfqq->dispatched == 0 && @@ -4350,8 +4349,7 @@ void bfq_bfqq_expire(struct bfq_data *bfqd, if (bfqd->low_latency && bfqq->wr_coeff == 1) bfqq->last_wr_start_finish = jiffies; - if (bfqd->low_latency && bfqd->bfq_wr_max_softrt_rate > 0 && - RB_EMPTY_ROOT(&bfqq->sort_list)) { + if (bfqd->low_latency && RB_EMPTY_ROOT(&bfqq->sort_list)) { /* * If we get here, and there are no outstanding * requests, then the request pattern is isochronous