Message ID | 20221107235654.1769462-4-bryan.odonoghue@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2373377wru; Mon, 7 Nov 2022 15:58:37 -0800 (PST) X-Google-Smtp-Source: AMsMyM5uMcqwzwMv+jKRzIOHjkeLOPTLOaDYdgosaJGW/13Ia43H8M979V9rzHVJYJJvJAqNQKuM X-Received: by 2002:a65:644a:0:b0:470:f04:5b67 with SMTP id s10-20020a65644a000000b004700f045b67mr24843738pgv.586.1667865517034; Mon, 07 Nov 2022 15:58:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667865517; cv=none; d=google.com; s=arc-20160816; b=kV92HvSVCkqine5pwdg+0dpuV1MoX2gRL+H30CCI2VJn9AvxH/mltZWSyJ7qGuIPC/ 0AHzhfv/ksBTKdbG1Uv/Ez0X87TwKNidqF+EMbgcUhHWNiV/CCEeARHYbBrTwStYv7v8 Ulqh9NQTVKuXOy6IE3H/Ry6UZNVF6PT8BU1afaM0X6sFT9m/6D5HSYSHk136tat9bMry GdFMNYKXuvnpHpsaiXgU/0X0EFjY9lFX38tRM9L78tdkkq4IaCldiYhH/dEk0bmlqXen nChpgK497B3xtXPWgZgIZXxYVF1WXgHlF1sdNa/6EvFXVIr48EB2PnwPuygO36y34DX2 pMTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=j6+k+VnBlUqDvk2kkm8jof+dC2sdOCi6gT/1zjBraSs=; b=BmkAHt9rPm2uncWJeYt6jHGHl/3T8eGxU9+EPNbpPYHGTRCrWvGZ02TVW8UyqZMYqH +zSq5sGDkxi2YXrGNLAZ7To/FVbVoV7ZmzU9qsLjFP/1CocdhyecQg7JIZd3Wsf+niOk IYpvdTajKZnAHY+A5EKcVrzPhivro8uZfRG3EbB+Pu8bbTVlSrRmFhv9zF4ySdUOeWjF zlHitFoRjEvcYvL27EVcM4lQWb7UmWzJ3cdUlMVdafH6jPpH0e6cw0dsJhXT94/Z78ym 6QkrOgG1Cib9Wzbx4j5//bdQGsDumZ5t7/x2F/X2rn53fq+wfOj4l9t2CJx248Zd2W2r sLcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i8bcjlRL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li4-20020a17090b48c400b00212d2bf21b1si12355411pjb.85.2022.11.07.15.58.24; Mon, 07 Nov 2022 15:58:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i8bcjlRL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232712AbiKGX5K (ORCPT <rfc822;hjfbswb@gmail.com> + 99 others); Mon, 7 Nov 2022 18:57:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232676AbiKGX5H (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 7 Nov 2022 18:57:07 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6671D27908 for <linux-kernel@vger.kernel.org>; Mon, 7 Nov 2022 15:57:01 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id c3-20020a1c3503000000b003bd21e3dd7aso10655053wma.1 for <linux-kernel@vger.kernel.org>; Mon, 07 Nov 2022 15:57:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j6+k+VnBlUqDvk2kkm8jof+dC2sdOCi6gT/1zjBraSs=; b=i8bcjlRLWz2eVfBMXkZ+YP2GXHL+oICNaqk7chAMX1OPwEKT+r2xr+BagAoqefWCle Cp57t5oK7tzFmSGPg5BujBFd5C2xazKjfVDVREUg29hAUAuP/Of9NOIiET104ftzW/k6 9qa78qJG3L4iry45JEQYBRN0iC3WjqCvTVKD617TmcrYi85srsf2Z5U+z+aXcko4Zj4o unXqjgpxrbk7JVk3AMaITpUL/CMpI0n9NsylkUSj3PljH+eRTtL/Fc/82xqvreHIz3bS 8BoXVZW/wUEgyr7ryKuVtRvuvIFIMRdCI302mst4RICl3FXerToMirc2M5rMq9bfh6Az bXmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j6+k+VnBlUqDvk2kkm8jof+dC2sdOCi6gT/1zjBraSs=; b=MhFGfgcXGbff+Pi+L/g1mFy4EZEpFc34PbPDa/gh6v0wXeR8aqIWQeImxcegRvI394 VONwG7/dphn7r6CzA2E/+ZiJ+tKWU5x7yvc02iaFjwMKoQ/3DbSOBcR2dOuTxmAV++eZ GbjLv4TVJKuRwGDaFjdXv/O77gNdfwQnVJV8l1a5DGZAgE+Nbdx4kiTCl25eIKX09Cif OcMKjqs2KsT/rvOe80WP9QfU4S7dafGA3KZeWwVx3D6pcqkNgBYrwzA12AY5sdWoIA1G cYlC3AAiMAGJG2nQ7RB1qf2fQAJ+hStRvqva/aXbvGJWLI5oJ4mTUPWsuVwY3sO8bHzk 2z6A== X-Gm-Message-State: ACrzQf2J/y+IkD+9/QfmAKDpXt8gTThUFhJ55yKDk6YPoMMrsJGoM3fB eh1FQr2gcEKRuCGH1fpf+6D6ZQ== X-Received: by 2002:a05:600c:4d86:b0:3cf:7257:ba15 with SMTP id v6-20020a05600c4d8600b003cf7257ba15mr29852243wmp.22.1667865419855; Mon, 07 Nov 2022 15:56:59 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id b18-20020a056000055200b00236545edc91sm8386161wrf.76.2022.11.07.15.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 15:56:59 -0800 (PST) From: Bryan O'Donoghue <bryan.odonoghue@linaro.org> To: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, quic_mkrishn@quicinc.com, linux-arm-msm@vger.kernel.org Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Date: Mon, 7 Nov 2022 23:56:39 +0000 Message-Id: <20221107235654.1769462-4-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221107235654.1769462-1-bryan.odonoghue@linaro.org> References: <20221107235654.1769462-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748883752147914242?= X-GMAIL-MSGID: =?utf-8?q?1748883752147914242?= |
Series |
[v2,01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint
|
|
Commit Message
Bryan O'Donoghue
Nov. 7, 2022, 11:56 p.m. UTC
When converting from .txt to .yaml we didn't include descriptions for the
existing regulator supplies.
- vdd
- vdda
- vddio
Add those descriptions into the yaml now as they were prior to the
conversion. Mark the supplies as required as was previously the case in the
.txt implementation.
Warnings about missing regulators can be resolved by updating the relevant
dtsi files to point to fixed always-on regulators where appropriate.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Cc: Rob Clark <robdclark@gmail.com>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
Comments
On 08/11/2022 02:56, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. Mark the supplies as required as was previously the case in the > .txt implementation. > > Warnings about missing regulators can be resolved by updating the relevant > dtsi files to point to fixed always-on regulators where appropriate. Ugh. Are they missing or are they optional/not used on these platforms? Can you possibly list all regulator warnings? > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index cf782c5f5bdb0..0f7747e55b9be 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -124,6 +124,18 @@ properties: > - port@0 > - port@1 > > + vdd-supply: > + description: > + Phandle to vdd regulator device node > + > + vddio-supply: > + description: > + Phandle to vdd-io regulator device node > + > + vdda-supply: > + description: > + Phandle to vdda regulator device node > + > required: > - compatible > - reg > @@ -135,6 +147,9 @@ required: > - assigned-clocks > - assigned-clock-parents > - ports > + - vdd-supply > + - vddio-supply > + - vdda-supply > > additionalProperties: false >
On 08/11/2022 12:59, Dmitry Baryshkov wrote: >> >> Warnings about missing regulators can be resolved by updating the >> relevant >> dtsi files to point to fixed always-on regulators where appropriate. > > Ugh. Are they missing or are they optional/not used on these platforms? Some platforms either don't implement them or worse possibly do implement but don't model them when they should. > Can you possibly list all regulator warnings? Downstream we have arch/arm/boot/dts/qcom/msm8916-mdss.dtsi mdss_dsi0: qcom,mdss_dsi@1a98000 { vdda-supply = <&pm8916_l2>; vdd-supply = <&pm8916_l17>; vddio-supply = <&pm8916_l6>; }; Looking at something like arch/arm/boot/dts/qcom/msm8916-mtp.dtsi which references arch/arm/boot/dts/qcom/dsi-panel-jdi-1080p-video.dtsi it doesn't appear to delete andy of the vdd*-supply references apq8016-sbc.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-a3u-eur.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-a5u-eur.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-e5.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-e7.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-grandmax.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8996-xiaomi-natrium.dtb: dsi@994000: 'panel@0', 'vcca-supply' do not match any of the regexes: 'pinctrl-[0-9]+' msm8996-xiaomi-scorpio.dtb: dsi@994000: 'vdda-supply' is a required property qrb5165-rb5.dtb: dsi@ae94000: 'vdd-supply' is a required property qrb5165-rb5.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-idp.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-idp.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r3-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r3-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-homestar-r2.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r2.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-homestar-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-kingoftown-r0.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-kingoftown-r0.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-kingoftown-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-kingoftown-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r0.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r0.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r1-kb.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r1-kb.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r3-kb.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r3-kb.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r3-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r3-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r9.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r9.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r9-kb.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r9-kb.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r9-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r9-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-r9.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-r9.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r5.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r5.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r9.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r9.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev0-auo.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev0-auo.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev0-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev0-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev1-auo.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev1-auo.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev1-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev1-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-lte-parade.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-lte-parade.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-lte-ti.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-lte-ti.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-parade.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-parade.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-ti.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-ti.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r2.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r2.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r2-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r2-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r3-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r3-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-quackingstick-r0.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-quackingstick-r0.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-quackingstick-r0-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-quackingstick-r0-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev0-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev0-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev0-inx.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev0-inx.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sda660-inforce-ifc6560.dtb: dsi@c994000: 'vdd-supply' is a required property sda660-inforce-ifc6560.dtb: dsi@c994000: 'vddio-supply' is a required property sdm845-cheza-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-cheza-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-cheza-r2.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-cheza-r2.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-cheza-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-cheza-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-db845c.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-db845c.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-mtp.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-mtp.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-mtp.dtb: dsi@ae96000: 'vdd-supply' is a required property sdm845-mtp.dtb: dsi@ae96000: 'vddio-supply' is a required property sdm845-oneplus-enchilada.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-oneplus-enchilada.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-oneplus-fajita.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-oneplus-fajita.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-xiaomi-beryllium.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-xiaomi-beryllium.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-xiaomi-polaris.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-xiaomi-polaris.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-shift-axolotl.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-shift-axolotl.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm850-lenovo-yoga-c630.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm850-lenovo-yoga-c630.dtb: dsi@ae94000: 'vddio-supply' is a required property apq8016-sbc.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-a5u-eur.dtb: dsi@1a98000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property
On Tue, 8 Nov 2022 at 17:42, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 08/11/2022 12:59, Dmitry Baryshkov wrote: > >> > >> Warnings about missing regulators can be resolved by updating the > >> relevant > >> dtsi files to point to fixed always-on regulators where appropriate. > > > > Ugh. Are they missing or are they optional/not used on these platforms? > > Some platforms either don't implement them or worse possibly do > implement but don't model them when they should. > > > Can you possibly list all regulator warnings? > > > Downstream we have > > arch/arm/boot/dts/qcom/msm8916-mdss.dtsi > > mdss_dsi0: qcom,mdss_dsi@1a98000 { > vdda-supply = <&pm8916_l2>; > vdd-supply = <&pm8916_l17>; > vddio-supply = <&pm8916_l6>; > }; > > Looking at something like > > arch/arm/boot/dts/qcom/msm8916-mtp.dtsi which references > arch/arm/boot/dts/qcom/dsi-panel-jdi-1080p-video.dtsi it doesn't appear > to delete andy of the vdd*-supply references Good example. We have vdda-supply and vddio-supply in msm8916-pm8916.dtsi (correct). And the mentioned vdd-supply is not applicable to this platform. It powers up the external DSI-to-HDMI bridge. I'd assume that the same regulator was destined to power up the panel. So, I'd suggest defining all supplies at the top level and then pushing all the required: parts into the per-SoC entries.
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. Mark the supplies as required as was previously the case in the > .txt implementation. > > Warnings about missing regulators can be resolved by updating the relevant > dtsi files to point to fixed always-on regulators where appropriate. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index cf782c5f5bdb0..0f7747e55b9be 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -124,6 +124,18 @@ properties: > - port@0 > - port@1 > > + vdd-supply: > + description: > + Phandle to vdd regulator device node Drop "Phandle to" and "device node", so just "VDD regulator". You describe hardware rather (when applicable), not Devicetree syntax. The same in other places and with that: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index cf782c5f5bdb0..0f7747e55b9be 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -124,6 +124,18 @@ properties: - port@0 - port@1 + vdd-supply: + description: + Phandle to vdd regulator device node + + vddio-supply: + description: + Phandle to vdd-io regulator device node + + vdda-supply: + description: + Phandle to vdda regulator device node + required: - compatible - reg @@ -135,6 +147,9 @@ required: - assigned-clocks - assigned-clock-parents - ports + - vdd-supply + - vddio-supply + - vdda-supply additionalProperties: false