From patchwork Mon Nov 7 21:33:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Namhyung Kim X-Patchwork-Id: 16735 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2309120wru; Mon, 7 Nov 2022 13:37:01 -0800 (PST) X-Google-Smtp-Source: AMsMyM4vXz5YfsG/ijlFNAAJa4rq+3Y86uVsT811a9k+nIbbmSvL6jt7fsZQpsV9XiZpnjYBymSU X-Received: by 2002:a17:907:744:b0:741:36b9:d2cc with SMTP id xc4-20020a170907074400b0074136b9d2ccmr48142035ejb.613.1667857020931; Mon, 07 Nov 2022 13:37:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667857020; cv=none; d=google.com; s=arc-20160816; b=Tz8kSN6M4Ga5RRcK9VzHZ/qhzK5C7Zrp1JsbMhfd5zaJiIvRXyx1c8dVFQ9DrLmz2R 2+9Uh6O41dRJ1k8c/jyWtjYdCg/71ePdXRGqkebeYIWr+3aOSRzK1RVqLRJ3kOAA11jf Y/gPw8fiFzOMaONXIzxOjQyQFEcoXRvtuDxDWGDzS9ZOLcZmqVeE+N6SGBMvQGZNEbZH byaTBPHimr5ZbrODgSmz3+lSyLfkqaNVy5dq2ek+3Z/qGsWqiZ5K0GLIe+9v7anyujFZ 9Jq3Kucc5Bazo1CfOynDHef9G4XR9wx8KNf/On7Sd5lWbs23Ri3OcWeWQuHMaY9MPk89 UCRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=mWSDNfZ2wImW4xPzQ9jDtU6vpg7XH7BhaLU95Jwpr2Y=; b=oj0nCoCJUs5DUrM4Arf95NuN2UaSrZAVnXgsHhzmCQmmceGWQxKMt+u4+P4VlFaGuU p1/XH24FHQt93ErL3VVHlYEUfm6ZFYAM4osH/bTNkERrmUMOxvP6/laUXZ7ZYWvjBth7 DWriOJYsq5QIK7bOrWF7k4alF5R0SfXDb0r1eb/qbVn1sHiR2Ju94Gt4GtM8+a/pbDb/ 0hrxDst+DliGq/z4pFzN+bNljzVUZStHwfCZ+ooneMK8zfkI7rRdjsd//gxB0G4Ss2BP tBC9kt/kwBERMHyAubsYOvldySKY6mQEYQAypoTAEkZZV0TVXVj46MSsGyxNnWk+Rt87 +xSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BqNGbFdH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h3-20020a1709060f4300b007a7fc67c880si6904111ejj.71.2022.11.07.13.36.37; Mon, 07 Nov 2022 13:37:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BqNGbFdH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233571AbiKGVeC (ORCPT + 99 others); Mon, 7 Nov 2022 16:34:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233510AbiKGVdp (ORCPT ); Mon, 7 Nov 2022 16:33:45 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35EAACFC; Mon, 7 Nov 2022 13:33:28 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id y203so11915803pfb.4; Mon, 07 Nov 2022 13:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=mWSDNfZ2wImW4xPzQ9jDtU6vpg7XH7BhaLU95Jwpr2Y=; b=BqNGbFdHwFQxBhVekowAdOUNERDGn2+AWTAyyiZCzt5B/9GCH0SUZ66R7ZrHk9eGZf BfkM9JDgUIkojWuYTxAGCA0Lpd4t21URmF/n/ybGbQaCggsJgy6F7/EbwPflwodxtq9Q 8queCZb++T6Aqvi9QoVSdlpoua1q/gjjTpRJuVuq8M4f6JO5KPxJboIil3/T0bbZ3imc 7M6KNqczmjl/QRcX3jMKvHFQA+rtlEsdd+LMI59y49ANRrEv3Wdswe6XfrUQku825XaL PPObpYYXhLJE3ocialaJlNqBvAnxLpmAkDSRCqva3pCXPoviaatiREdqAAsJK1/FLa08 yq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mWSDNfZ2wImW4xPzQ9jDtU6vpg7XH7BhaLU95Jwpr2Y=; b=qYiBIrbG+w+dSjXp3xiEsesSVaNlwoEU32EtRqdQMyWRwFtN5accz9nlui58vssFJM qQB3a9l/0Eakq9r4UvIey2nCDWuSnoNv6HesZNhb1urN3lSB7qek3ooNBdXO54byxZkq f0hG9TNo6h1Y9k0ofQtY7aCsXYsjZYrck8ur345gglh3rdg1kLjA8PnXfk00KeMq8h8q ypGmX4GVXOjZu1F81oCXVEVXQe68j5mDhz+ZRJlI2TQTBO/itaQgRTmjGzxuJMOlTQzq XpuWeO3ewE0ibObd6t8bO9SbuPkyZyqNz355OenoRE9BJPND6bIFg2roOKvtgs7Fwzlp A2hw== X-Gm-Message-State: ACrzQf0mbs/Dl82bhzwvLopK6HzJ6RMAT3pzODQ2sNqbqo6KqeyjOPsj 11LLWGqi9AsriLERay+ExJ8= X-Received: by 2002:a62:860b:0:b0:56d:a2be:ebe4 with SMTP id x11-20020a62860b000000b0056da2beebe4mr873244pfd.28.1667856807633; Mon, 07 Nov 2022 13:33:27 -0800 (PST) Received: from youngsil.svl.corp.google.com ([2620:15c:2d4:203:5850:5958:9c77:f623]) by smtp.gmail.com with ESMTPSA id a1-20020a1709027e4100b0017f5ba1fffasm5366413pln.297.2022.11.07.13.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 13:33:27 -0800 (PST) Sender: Namhyung Kim From: Namhyung Kim To: Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Kan Liang , Zhengjun Xing , James Clark Subject: [PATCH 7/9] perf stat: Add header for interval in JSON output Date: Mon, 7 Nov 2022 13:33:12 -0800 Message-Id: <20221107213314.3239159-8-namhyung@kernel.org> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog In-Reply-To: <20221107213314.3239159-1-namhyung@kernel.org> References: <20221107213314.3239159-1-namhyung@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748874843230701235?= X-GMAIL-MSGID: =?utf-8?q?1748874843230701235?= It missed to print a matching header line for intervals. Before: # perf stat -a -e cycles,instructions --metric-only -j -I 500 {"unit" : "insn per cycle"} {"interval" : 0.500544283}{"metric-value" : "1.96"} ^C After: # perf stat -a -e cycles,instructions --metric-only -j -I 500 {"unit" : "sec"}{"unit" : "insn per cycle"} {"interval" : 0.500515681}{"metric-value" : "2.31"} ^C Signed-off-by: Namhyung Kim Acked-by: Ian Rogers --- tools/perf/util/stat-display.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 25f67fb37f6d..aab2576bd40f 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -860,6 +860,10 @@ static void print_metric_headers(struct perf_stat_config *config, if (!config->iostat_run) fputs(aggr_header_csv[config->aggr_mode], config->output); } + if (config->json_output) { + if (config->interval) + fputs("{\"unit\" : \"sec\"}", config->output); + } if (config->iostat_run) iostat_print_header_prefix(config);