From patchwork Mon Nov 7 20:28:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 16672 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2284895wru; Mon, 7 Nov 2022 12:45:32 -0800 (PST) X-Google-Smtp-Source: AMsMyM4xEvKhXLEYSe8Ji7XBmaAy26fOcC3/OlyundDZ9ganpeNCKUOCiuIp5jZkM9ZL53XuxKce X-Received: by 2002:a17:907:7e85:b0:7ad:bf64:b5de with SMTP id qb5-20020a1709077e8500b007adbf64b5demr48429168ejc.20.1667853931808; Mon, 07 Nov 2022 12:45:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667853931; cv=none; d=google.com; s=arc-20160816; b=kEMkAQ4eO4+ogfPqRm4Ljn958YBEM09jL2Cf6uiGqv1AwIkglXoIYEkrIKNOswus3N zQlhzuKyEYRbtN9MVa5QtqqFf1br92BVSekWSEVY+vadn1iUUXjfveviQPztPBCVCCFD QRclwUBRA9zraAsfL2uDdnRX2dPjTacV8IRc25kyZVSeZlf15wSWysJpaeNe6ISk64XT 0MpJR/BY2S5BcQnRKDVWAxUEeGICZ5clqHuWCb6z7rfpwuaAufCOd+Rt+QpY2M0g8mGQ sIWkTAhckxDyfl+/yPnSjVej0Ob8WNtrM1o2m0+5lkHnfSwJ2ACrQ2FISlD6/E684uOg Dfmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uDyOvkm6/+OKBHgvu7fmcFq3OmFFRwHI49Wxj7re1+o=; b=ssTBlC3IthDp8jyS03hIm7+z1N2Jdfl0u9j+wSKBa58zimuA7G+bJYfRrcfErTf0Po qrqP3vk/gMXt7sj0cSOwrBY7u5JsaglqyybLXHbJYsezX7a/Cc2Dws4LAiYT476CXYV9 OlzgxgEmu6kxFaq4KxHSZrd0TdueViu6NzM1XyPanNVb2XrnUm/eqkF6DjO/5N3jF7ZL mmBE9dKlin+7Wjx28zPvMM5YBp9NjMcDwgKxPMG+z4WnBIvwEtdTlwt9ocDz4Tb29cx+ 1yUJjrMv24LKpRFzD/2eqfWR/f4d/rIgQqp7TEK7QNjjeUZo1byIcmuxNIZt9nO5RBdC JOow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf42-20020a1709077f2a00b007701a050273si11029643ejc.942.2022.11.07.12.45.08; Mon, 07 Nov 2022 12:45:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232971AbiKGU24 (ORCPT + 99 others); Mon, 7 Nov 2022 15:28:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232942AbiKGU2r (ORCPT ); Mon, 7 Nov 2022 15:28:47 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9795B20BE7 for ; Mon, 7 Nov 2022 12:28:46 -0800 (PST) Received: from ipservice-092-217-067-198.092.217.pools.vodafone-ip.de ([92.217.67.198] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1os8jX-0004bP-Ri; Mon, 07 Nov 2022 21:28:39 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 2/3] staging: r8188eu: drop another removal/stop check Date: Mon, 7 Nov 2022 21:28:23 +0100 Message-Id: <20221107202824.61431-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221107202824.61431-1-martin@kaiser.cx> References: <20221107202824.61431-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748871604250093051?= X-GMAIL-MSGID: =?utf-8?q?1748871604250093051?= There's no need to check bDriverStopped and bSurpriseRemoved in issue_probereq_ex. The code path looks like issue_probereq_ex _issue_probereq dump_mgntframe or dump_mgntframe_and_wait_ack All paths from dump_mgntframe check the two variables. dump_mgntframe_and_wait_ack contains a check as well. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 17803aca83c8..bfd6afd7266e 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -4496,9 +4496,6 @@ int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *pssid, i++; - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) - break; - if (i < try_cnt && wait_ms > 0 && ret == _FAIL) msleep(wait_ms);