Message ID | 20221107191535.624371-2-swboyd@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2243037wru; Mon, 7 Nov 2022 11:20:16 -0800 (PST) X-Google-Smtp-Source: AMsMyM7ESlaTc6xRj92TN7/97lXmPsQNynXlNbJ6JCUq/KsWlfPnV/OjXKIZeEHlBt1mTPtU5hjH X-Received: by 2002:a05:6402:a46:b0:461:ed76:cb56 with SMTP id bt6-20020a0564020a4600b00461ed76cb56mr54507221edb.264.1667848816046; Mon, 07 Nov 2022 11:20:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667848816; cv=none; d=google.com; s=arc-20160816; b=CBLDX/yvzY5jlXgPrdobMcska51wt0HfjGuR9/PFrfHRovkkToi1g/ULRCfTVCNI3j VmUPs1oyfJHBbTaHiyE+cW6omfm003z0FGKO/DEhhCenx8WUiY8QM/aJCL+o8w8mm8+R NKln1GSF5Tn2nxmo9sYiwpxbFzTszktLA3rCOWbt93lo4rXC5QqT0+pUkmlcYf8DXkh3 F87fpwvxa2LhPy+Tzsd6pzp4BxA1UtRkjcePftUPXWdzKuti3wkDDYe0HkOTu6MGtmsr q1I5bQaFGkCP0HMNMT/YsSzOPee4A/JEKPs0ubPpcJa9d+RZXVA3ZCqmil69jvEjS87F /5xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Et5rcDaKTeSODyH0ma6yTSI3d3kE/5OPATF9JyW6zgI=; b=BlMPEAVfOcmrMXQIfVYrlEMjMH4Db51fZ24QHIBm2f4494AlQbP8ZpTfa4xhr5dA04 jXiK+CP1zKhmw++gfrxpn8nytfEnnzm3MJAh2MMOzPk2kQYJnp9toFv1tfmcVbZ70F5N Us7Ikn86t2nD7FQVoEIsUfCJ6tAo7dlROeUrL4d1otf22NYBHk7gkWmIU1pIgC4DuIRk wm4G4kluBJ+QIVtZBbaF2IhGR8me3Pyjkkv/lLLm2DH9qNDjxDeLx5I49ve2WMqFDz2r yY7Rer4TR9nzo6+CgF1ct7Oi3xJbAw3zg4Cggb75JXWKj/VNJGWvVRoDqsqqBrlV69UK 9wug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HCojWqdb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a50eacb000000b00461b93cfe9dsi9759778edp.55.2022.11.07.11.19.52; Mon, 07 Nov 2022 11:20:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HCojWqdb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231846AbiKGTPs (ORCPT <rfc822;hjfbswb@gmail.com> + 99 others); Mon, 7 Nov 2022 14:15:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbiKGTPl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 7 Nov 2022 14:15:41 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7999F27B01 for <linux-kernel@vger.kernel.org>; Mon, 7 Nov 2022 11:15:40 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id v3so11301763pgh.4 for <linux-kernel@vger.kernel.org>; Mon, 07 Nov 2022 11:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Et5rcDaKTeSODyH0ma6yTSI3d3kE/5OPATF9JyW6zgI=; b=HCojWqdbpZ0XdltA7pCayQz4VWGZ0DOeCtn7O5AQ0AQk45wxFNUvbpn1hSIXT2u2kg bjE9wyYHwl2TUWdx85D99f0I+NpFteFqIFsrXqLJ8lGrD4bbNlEDJBMyXTIJkVv+ecJG D6zU/DDwQjCFIMEUDtSL8PJMewHbpqlh61JDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Et5rcDaKTeSODyH0ma6yTSI3d3kE/5OPATF9JyW6zgI=; b=T4Bn3JAH+L4PqK4XGlYZZX2FOqEuyenjAQ/0MxDHX6O8JNKPWhvw4RmY+Y71BXg85M l8y9NTAJNS0bGEO5lVM1nrUDc89TllFCKAukvCrBrv1z4SgY67tR8HnvpRbHLec8zDLL Y4kj/HQ33mBxnok8SCO4p1RlONjVAB9MbUwzeUmMhlhOdd3aZ7DSTtjyGBYo+I7Pwn9z 5HY/RSPQmuUdz7sd4TqDpDnX5Ey4T3elowP4+izkXYS7WKnoMUlnWu8eTrCu1x5TGxIj YxyOzxSfjFK+eT8fLn9CbaIu8Hh9dwURfscSlxLkt+CCqCs4cQLONPuHXrNgmRUYZYHR U8qg== X-Gm-Message-State: ACrzQf0l/Cf7CImwC2uDklifpKaIGw2/SozLJOJWhMyaQTjZu3SfekvQ LwxkJuGaYa6JoFKA4JVldS8Eog== X-Received: by 2002:a63:b59:0:b0:434:2374:6d12 with SMTP id a25-20020a630b59000000b0043423746d12mr44379966pgl.311.1667848539848; Mon, 07 Nov 2022 11:15:39 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:11a:201:4652:3752:b9b7:29f9]) by smtp.gmail.com with ESMTPSA id r11-20020a170902c60b00b001830ed575c3sm5306627plr.117.2022.11.07.11.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 11:15:39 -0800 (PST) From: Stephen Boyd <swboyd@chromium.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org> Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-arm-msm@vger.kernel.org, Douglas Anderson <dianders@chromium.org>, Matthias Kaehlcke <mka@chromium.org>, Alexandru M Stan <amstan@chromium.org> Subject: [PATCH v2 1/2] arm64: dts: qcom: Fully describe fingerprint node on Herobrine Date: Mon, 7 Nov 2022 11:15:34 -0800 Message-Id: <20221107191535.624371-2-swboyd@chromium.org> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog In-Reply-To: <20221107191535.624371-1-swboyd@chromium.org> References: <20221107191535.624371-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748866239830191326?= X-GMAIL-MSGID: =?utf-8?q?1748866239830191326?= |
Series |
Update fingerprint node on herobrine/trogdor
|
|
Commit Message
Stephen Boyd
Nov. 7, 2022, 7:15 p.m. UTC
Update the fingerprint node on Herobrine to match the fingerprint DT
binding. This will allow us to drive the reset and boot gpios from the
driver when it is re-attached after flashing. We'll also be able to boot
the fingerprint processor if the BIOS isn't doing it for us.
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Alexandru M Stan <amstan@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Comments
Hi, On Mon, Nov 7, 2022 at 11:15 AM Stephen Boyd <swboyd@chromium.org> wrote: > > Update the fingerprint node on Herobrine to match the fingerprint DT > binding. This will allow us to drive the reset and boot gpios from the > driver when it is re-attached after flashing. We'll also be able to boot > the fingerprint processor if the BIOS isn't doing it for us. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) From Bjorn's recent comment [1], I think your subject needs modification to: arm64: dts: qcom: sc7280: Fully describe fingerprint node on Herobrine Other than that this seems fine and is a better description of hardware, so: Reviewed-by: Douglas Anderson <dianders@chromium.org> I guess we're still leaving gpio77 alone (AKA not describing it in the fingerprint regulator)? [1] https://lore.kernel.org/r/20221017224853.stuy5qeqxjxntob4@builder.lan/
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index ca02ef26f161..448da9794722 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -503,13 +503,16 @@ ap_spi_fp: &spi9 { cs-gpios = <&tlmm 39 GPIO_ACTIVE_LOW>; cros_ec_fp: ec@0 { - compatible = "google,cros-ec-spi"; + compatible = "google,cros-ec-fp", "google,cros-ec-spi"; reg = <0>; interrupt-parent = <&tlmm>; interrupts = <61 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&fp_to_ap_irq_l>, <&fp_rst_l>, <&fpmcu_boot0>; + boot0-gpios = <&tlmm 68 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 78 GPIO_ACTIVE_LOW>; spi-max-frequency = <3000000>; + vdd-supply = <&pp3300_fp_mcu>; }; };