diff mbox series

[printk,v3,10/40] kdb: kdb_io: use console_is_enabled()

Message ID	20221107141638.3790965-11-john.ogness@linutronix.de
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: John Ogness <john.ogness@linutronix.de> To: Petr Mladek <pmladek@suse.com> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>, Steven Rostedt <rostedt@goodmis.org>, Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org, Jason Wessel <jason.wessel@windriver.com>, Daniel Thompson <daniel.thompson@linaro.org>, Douglas Anderson <dianders@chromium.org>, Luis Chamberlain <mcgrof@kernel.org>, Aaron Tomlin <atomlin@redhat.com>, kgdb-bugreport@lists.sourceforge.net Subject: [PATCH printk v3 10/40] kdb: kdb_io: use console_is_enabled() Date: Mon, 7 Nov 2022 15:22:08 +0106 Message-Id: <20221107141638.3790965-11-john.ogness@linutronix.de> In-Reply-To: <20221107141638.3790965-1-john.ogness@linutronix.de> References: <20221107141638.3790965-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	reduce console_lock scope \| [printk,v3,00/40] reduce console_lock scope [printk,v3,01/40] rcu: implement lockdep_rcu_enabled for !CONFIG_DEBUG_LOCK_ALLOC [printk,v3,02/40] serial: kgdboc: Lock console list in probe function [printk,v3,03/40] printk: Convert console_drivers list to hlist [printk,v3,04/40] printk: Prepare for SRCU console list protection [printk,v3,05/40] printk: fix setting first seq for consoles [printk,v3,06/40] um: kmsg_dump: only dump when no output console available [printk,v3,07/40] console: introduce console_is_enabled() wrapper [printk,v3,08/40] printk: use console_is_enabled() [printk,v3,09/40] um: kmsg_dump: use console_is_enabled() [printk,v3,10/40] kdb: kdb_io: use console_is_enabled() [printk,v3,11/40] um: kmsg_dumper: use srcu console list iterator [printk,v3,12/40] tty: serial: kgdboc: document console_lock usage [printk,v3,13/40] tty: tty_io: document console_lock usage [printk,v3,14/40] proc: consoles: document console_lock usage [printk,v3,15/40] kdb: use srcu console list iterator [printk,v3,16/40] printk: console_flush_all: use srcu console list iterator [printk,v3,17/40] printk: console_unblank: use srcu console list iterator [printk,v3,18/40] printk: console_flush_on_panic: use srcu console list iterator [printk,v3,19/40] printk: console_device: use srcu console list iterator [printk,v3,20/40] printk: __pr_flush: use srcu console list iterator [printk,v3,21/40] printk: introduce console_list_lock [printk,v3,22/40] console: introduce console_is_registered() [printk,v3,23/40] serial_core: replace uart_console_enabled() with uart_console_registered() [printk,v3,24/40] tty: nfcon: use console_is_registered() [printk,v3,25/40] efi: earlycon: use console_is_registered() [printk,v3,26/40] tty: hvc: use console_is_registered() [printk,v3,27/40] tty: serial: earlycon: use console_is_registered() [printk,v3,28/40] tty: serial: pic32_uart: use console_is_registered() [printk,v3,29/40] tty: serial: samsung_tty: use console_is_registered() [printk,v3,30/40] tty: serial: xilinx_uartps: use console_is_registered() [printk,v3,31/40] usb: early: xhci-dbc: use console_is_registered() [printk,v3,32/40] netconsole: avoid CON_ENABLED misuse to track registration [printk,v3,33/40] printk, xen: fbfront: create/use safe function for forcing preferred [printk,v3,34/40] tty: tty_io: use console_list_lock for list synchronization [printk,v3,35/40] proc: consoles: use console_list_lock for list iteration [printk,v3,36/40] tty: serial: kgdboc: use console_list_lock for list traversal [printk,v3,37/40] tty: serial: kgdboc: synchronize tty_find_polling_driver() and register_console() [printk,v3,38/40] tty: serial: kgdboc: use console_list_lock to trap exit [printk,v3,39/40] printk: relieve console_lock of list synchronization duties [printk,v3,40/40] tty: serial: sh-sci: use setup() callback for early console

Commit Message

John Ogness Nov. 7, 2022, 2:16 p.m. UTC

  Replace (console->flags & CON_ENABLED) usage with console_is_enabled().

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
 kernel/debug/kdb/kdb_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Thompson Nov. 9, 2022, 8:22 a.m. UTC | #1

On Mon, Nov 07, 2022 at 03:22:08PM +0106, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

Petr Mladek Nov. 9, 2022, 2:59 p.m. UTC | #2

On Mon 2022-11-07 15:22:08, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>  kernel/debug/kdb/kdb_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
> index 67d3c48a1522..550fe8b456ec 100644
> --- a/kernel/debug/kdb/kdb_io.c
> +++ b/kernel/debug/kdb/kdb_io.c
> @@ -559,7 +559,7 @@ static void kdb_msg_write(const char *msg, int msg_len)
>  	}
>  
>  	for_each_console(c) {
> -		if (!(c->flags & CON_ENABLED))
> +		if (!console_is_enabled(c))

Same as with the 9th patch. I would prefer to merge this with
the patch switching to the srcu console list iterator.

It will explain why the racy check is needed here. This change
does not make sense without the other.

Best Regards,
Petr

diff mbox series

Patch

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 67d3c48a1522..550fe8b456ec 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -559,7 +559,7 @@  static void kdb_msg_write(const char *msg, int msg_len)
 	}
 
 	for_each_console(c) {
-		if (!(c->flags & CON_ENABLED))
+		if (!console_is_enabled(c))
 			continue;
 		if (c == dbg_io_ops->cons)
 			continue;