From patchwork Mon Nov 7 09:29:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakesh Sankaranarayanan X-Patchwork-Id: 16228 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1818538wru; Sun, 6 Nov 2022 20:03:34 -0800 (PST) X-Google-Smtp-Source: AMsMyM6AbZ4iSl/DcPKWLE4LXNLDZYviWnWONltMUdJnV91fEfUt9jcF40bqyOcaROWgd87dUu9+ X-Received: by 2002:a17:902:e54e:b0:187:ba9:4305 with SMTP id n14-20020a170902e54e00b001870ba94305mr44418446plf.167.1667793814473; Sun, 06 Nov 2022 20:03:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667793814; cv=none; d=google.com; s=arc-20160816; b=JNbIZFSsP+0aw3f77cLXRDCY/5GGsAB05Xi1QLUBDbUbLFLWW6bbv3gGxAsJeSdPsU SO/o8G2l9M0eFxQG5vlMK/m9HLw09fXSKT5qRlC8mrhiUOyTD8V2q1676qoVnD8QTk2g jGNsI/7xAKW5wR28Uzbfim1NvkTy8aSHd0xbndwN8t0GU0Advy/ceT5TcO1oFApUHEVS ZgTMWPHgdWwNTm0Vq67Qs7xmxHt0/YfJuaZ7DURo5qoxyIzEL/C/XKAy+7E8/SjT6Nma HG3QfVysjrDzMMpv7iQxufXg2GdSfBC764pgtnXngaeskOMnFr/7KYKi5Dx+tRpTn2I4 NQJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SxHiO70i9PsvluYl8QEPfvHjq+Kxe7Zx7Z8JewlmLQw=; b=EOKNsh1euT1IEcoSCABphANy/sYQSaYTuu6pKevAAjfh1h96gruLoyOXcnI2G7MYWI xZaIUA7Ue9GvhZMvw8OH/YoDrLffBNnoZAVbWoIGtGUfNWjRg3CrXI8asLda4eV8GT0r ySGLLjesuUwo/9vqs6byunCNjf2uNLZXusl9pGUGPp+p4wi8jk1VYgoBldYpa3zq+qLw Ta7TkiyplP/sgVxMh/WZmaGACRsznywFKasXSryF6gm+1cuI77eyfbqHK6mM01+c6x+Q DUM1D8Z615U4iy1EODKnt1hgaMg4zXYF5uO4XR5VL3NvEVGzFOTVNKgJ+U08PBWDxUEa VFpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Aw0cPgCV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v25-20020a637a19000000b0046265702353si9672371pgc.203.2022.11.06.20.03.20; Sun, 06 Nov 2022 20:03:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Aw0cPgCV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231324AbiKGD5o (ORCPT + 99 others); Sun, 6 Nov 2022 22:57:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231346AbiKGD5g (ORCPT ); Sun, 6 Nov 2022 22:57:36 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2454EFAC2; Sun, 6 Nov 2022 19:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1667793452; x=1699329452; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sZkHzp4axHvnVQJ1e6P/AN6YKQRNToLw1Xi9YPFU8ms=; b=Aw0cPgCVFiAPMTLHIT/iKppt69I+cGbtxwi3RajBcBCNNJkOn83XsJKb tgHXn1JOEihe1A6JiJdBmWEmOS4deNQiHXp2F9WZVKlcregU/C0tmjdr2 MmmWTP16lMdNXCuS2L8pjrBm99H3Qi8xTezQb6oQXu/tJB5MxQKWLvbSZ zhOheD4X8pGQvlWsdN+XoGimt58l0hE0APgVe5kvMqt4ZFSXYYPhpMeXZ +zGU2Af8wJgvp3s2FRrLztztwfmIyPpsKl3sf7FsAz8cxSKpQKuT9daey aSyyDvaiJYHatfvhrEHhBv/16CNd054DfVJsmc2IKlCjJAY+fHwrxn2Y+ A==; X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="122073048" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 06 Nov 2022 20:57:31 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Sun, 6 Nov 2022 20:57:30 -0700 Received: from che-lt-i67786lx.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Sun, 6 Nov 2022 20:57:26 -0700 From: Rakesh Sankaranarayanan To: , CC: , , , , , , , , , Subject: [PATCH net-next v2 3/5] net: dsa: microchip: add error checking for ksz_pwrite Date: Mon, 7 Nov 2022 14:59:20 +0530 Message-ID: <20221107092922.5926-4-rakesh.sankaranarayanan@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221107092922.5926-1-rakesh.sankaranarayanan@microchip.com> References: <20221107092922.5926-1-rakesh.sankaranarayanan@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748808566560564543?= X-GMAIL-MSGID: =?utf-8?q?1748808566560564543?= Add status validation for port register write inside lan937x_change_mtu. ksz_pwrite and ksz_pread api's are updated with return type int (Reference patch mentioned below). Update lan937x_change_mtu with status validation for ksz_pwrite16(). Link: https://patchwork.kernel.org/project/netdevbpf/patch/20220826105634.3855578-6-o.rempel@pengutronix.de/ Signed-off-by: Rakesh Sankaranarayanan --- drivers/net/dsa/microchip/lan937x_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/lan937x_main.c b/drivers/net/dsa/microchip/lan937x_main.c index 7e4f307a0387..06d3d0308cba 100644 --- a/drivers/net/dsa/microchip/lan937x_main.c +++ b/drivers/net/dsa/microchip/lan937x_main.c @@ -242,7 +242,11 @@ int lan937x_change_mtu(struct ksz_device *dev, int port, int new_mtu) } /* Write the frame size in PORT_MAX_FR_SIZE register */ - ksz_pwrite16(dev, port, PORT_MAX_FR_SIZE, new_mtu); + ret = ksz_pwrite16(dev, port, PORT_MAX_FR_SIZE, new_mtu); + if (ret) { + dev_err(ds->dev, "failed to update mtu for port %d\n", port); + return ret; + } return 0; }