Message ID | 20221107052201.65477-2-samuel@sholland.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1849242wru; Sun, 6 Nov 2022 21:33:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf4c0Dnri1zVM3lrO5DW+oRBHSQ4hS8jNC+KljhTn/uKiVUvYKfC5ZejuC/BpKNGEgVaAq57 X-Received: by 2002:a17:902:9042:b0:188:6fc9:1da with SMTP id w2-20020a170902904200b001886fc901damr12430213plz.162.1667799191962; Sun, 06 Nov 2022 21:33:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667799191; cv=none; d=google.com; s=arc-20160816; b=LmY8MOV+iAUT6rUoaXShfvEKg61pYNJsGhnurpYVb0Ezh+1DFPfk2dq8goRibWuHLr QuTEDwNP9rt9L0L8dJ0SB+MKtr21FuE1GzC197QvImDKzczxqGu2xWM3P+8e8A1e4mcs +8JRwssorxc4GzvYr+IhGI6f8sVITJsDTIw5mYJ6OIfyL1eYlCuFpaXmsS4v/FxmeDdC 9OfdcbCNbFhV2OkF8jfzpp66VrzsG4uQGkvO1VeI1uVzcyLvnyzBy7k+SNQOTolAugYn J/SehOJD1zfNkWmy5bdYoc+6qwd9/zMeUkuTkFFn+asQlu60O/RQAkzYcBwVKhU/OVBS YMGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=XDA3FKsc76rlojguBycbOIx3Fn5VWhQv5XilLE+sJ+A=; b=fWm22MucFPHi0B+VWfYJRtg67KPgDXMW5mGwLAGLJAIwEmlhZBLeQsY1+OiSvPONfQ t3EnwqckXx7buFBtw5+tYHeLGySyDY8cWBmXlVvucq/StLOv1OGnWqhj//ARZ1SAotQw AuhXCkVJUsk48zIOdSKbPckokRFPoHvYeIbP4409LYGCaKleGOwos+pe1Dk4kkYDTVcq 8j62dMpMkglLft8W/2HdCj1aKzKAWCaQ+/xmNkDhMjoiLk971BT/YU2Wtg3JiPQ0J9wc zZwCDnY4XUN+ornqpEhtH0IdgWKYIki1NK9DeyGKoomJBgVp7aFzeG1RK8a0XrpefzcJ O4AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sholland.org header.s=fm1 header.b=PJJ03aom; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=LO2jjsdM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a170902f54600b00186bb4a081csi11482417plf.393.2022.11.06.21.32.59; Sun, 06 Nov 2022 21:33:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sholland.org header.s=fm1 header.b=PJJ03aom; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=LO2jjsdM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbiKGFWM (ORCPT <rfc822;hjfbswb@gmail.com> + 99 others); Mon, 7 Nov 2022 00:22:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiKGFWI (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 7 Nov 2022 00:22:08 -0500 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5A0163C2 for <linux-kernel@vger.kernel.org>; Sun, 6 Nov 2022 21:22:05 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 465B75C00E4; Mon, 7 Nov 2022 00:22:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 07 Nov 2022 00:22:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1667798524; x=1667884924; bh=XD A3FKsc76rlojguBycbOIx3Fn5VWhQv5XilLE+sJ+A=; b=PJJ03aomEKNvG4K++e y1aLwfUnffFpdWsTfmTKJpxoXP7t59VqioldNaNEti2Cb7+rjVjmNgjsirdgfGOV UmMJw+hzGgjLmj4xwSqlJYwtRWofjcsRqENODjO2MCdFCQHKwhvHY/LDe97q0FQe wU82LfaqWvNotZKToK0iC9AhfhTF4zynFsAsxNIZZme3ztaSL0e5uFbmzmIOm77Y fMBeEqeCmxcXTC4VlyxVyUWJTpinvjLcEFfTbKIfz0AudlbCro2R69AeE/xOrO1q wfmAU3GfU9a9T5DM7VhTI06I/FoPFpiPHpH8ZPHNXU83AFoPt60Rfkv0/TM7EPsq xloQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1667798524; x=1667884924; bh=XDA3FKsc76rlo jguBycbOIx3Fn5VWhQv5XilLE+sJ+A=; b=LO2jjsdMv3AVo4I43Pu1T2H1FSvhI bgWREETf65iS8638m79Tnm6/qLCLDhBP+yab6F+QaUxIXiuQjhIv5b/tUVE3Uk2k TJ0bpgFsMm7QWG/qnn2CCYS06m6QnTMBQGBpcXTsHXOsVcGgG9YN+wASHeTArSC+ ErUFW+oh3BQgxBrRmoOrhgHh6rHgfaoSHjNv9DjTVQPquhSZDKAcjJ0zQbuYNgsB 1FgYX9Cbyor5yU2LY6bnbv2iDZyA0cyvMa8CGxNMBvBiMyvV81RBqlvrnigFS1LC NCNmDt2obSbmBgxYQ7xyDXlf3wKNp50MLf9xDEfKTxU7MRvz5nSa75VvA== X-ME-Sender: <xms:_JVoY3si8I-auicL329w1gGD_AoH88pEuD4AMidzgjrJlRbbY4_ggg> <xme:_JVoY4dMk8N8sAlXgxPMerML94zaCuNwdKWVSkyoV2xOlheAHGCkfnq1tiu6MGkSr hxjv37lP97-p6NlDg> X-ME-Received: <xmr:_JVoY6w3TTJ6dll9n9hr9icLzXBf8CHz4_3Bov7FgjrucinmLTziNeYKrTHh8hJfroCkta5NOJi0W682Hax7gRn0qmcTdxWy55DaMC2U-mWbLZfSMIYfb8hoy6cnYa0HXEVBWw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdejgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeehgfdu feeitdevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: <xmx:_JVoY2OoWIoJ4jHBKgHISppBN6nOXyg_-yFjodwqLRGjqiv9inLpbg> <xmx:_JVoY39okOD9a9kufzLpnnJ6ddJrUxcBmTADBTG21kwWvG5NBBuFog> <xmx:_JVoY2U0WVMRaHjyk1nknA0ncR1qhRDymv-QFlT-kL7uuYXkB7RqWA> <xmx:_JVoYykcCPs9r_ILBS6-V0RdLtOCP8nAJDqTSK0xWaM69wYwpkruWA> Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Nov 2022 00:22:03 -0500 (EST) From: Samuel Holland <samuel@sholland.org> To: Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Samuel Holland <samuel@sholland.org> Subject: [PATCH v2 1/2] bus: sunxi-rsb: Remove shutdown callback Date: Sun, 6 Nov 2022 23:21:59 -0600 Message-Id: <20221107052201.65477-2-samuel@sholland.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221107052201.65477-1-samuel@sholland.org> References: <20221107052201.65477-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748814205283816974?= X-GMAIL-MSGID: =?utf-8?q?1748814205283816974?= |
Series |
bus: sunxi-rsb: Fix poweroff issues
|
|
Commit Message
Samuel Holland
Nov. 7, 2022, 5:21 a.m. UTC
Shutting down the RSB controller prevents communicating with a PMIC inside pm_power_off(), so it breaks system poweroff on some boards. Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Fixes: 843107498f91 ("bus: sunxi-rsb: Implement suspend/resume/shutdown callbacks") Signed-off-by: Samuel Holland <samuel@sholland.org> --- (no changes since v1) drivers/bus/sunxi-rsb.c | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 4cd2e127946e..17343cd75338 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -812,14 +812,6 @@ static int sunxi_rsb_remove(struct platform_device *pdev) return 0; } -static void sunxi_rsb_shutdown(struct platform_device *pdev) -{ - struct sunxi_rsb *rsb = platform_get_drvdata(pdev); - - pm_runtime_disable(&pdev->dev); - sunxi_rsb_hw_exit(rsb); -} - static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = { SET_RUNTIME_PM_OPS(sunxi_rsb_runtime_suspend, sunxi_rsb_runtime_resume, NULL) @@ -835,7 +827,6 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); static struct platform_driver sunxi_rsb_driver = { .probe = sunxi_rsb_probe, .remove = sunxi_rsb_remove, - .shutdown = sunxi_rsb_shutdown, .driver = { .name = RSB_CTRL_NAME, .of_match_table = sunxi_rsb_of_match_table,