From patchwork Sun Nov 6 12:49:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 16126 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1477029wru; Sun, 6 Nov 2022 04:51:23 -0800 (PST) X-Google-Smtp-Source: AMsMyM7jU+Wr5rsEaUiFJ3Zs19RCoUA806wy94BkD5Eodc0JC8OZWTVOaBuEAaRSpw2BzBkpdVyX X-Received: by 2002:a17:906:5d10:b0:7ad:e132:bb85 with SMTP id g16-20020a1709065d1000b007ade132bb85mr32341470ejt.367.1667739083745; Sun, 06 Nov 2022 04:51:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667739083; cv=none; d=google.com; s=arc-20160816; b=vXjTv43QU+cU9nsUCs8e1N3Nf6eAiIFD2q2GF5CCzzulcVgB3oYm+P5Rpg+uUlt6Ld C3PDTvt/oHfVl/u9/R+M1cAiu+hNNjgpRNeilwOEwKNmMeu7UVxeo8SffuWyUydvukUS gwfxjnNq3QGNaGdyophd0vu5pUOoIMeuferaT6hZBESzsVXD7iWMdFgTi+ZndW+WpejI NckMTi0Se8esuoB6rqCHziCGwCB62Io8zuivbmwZeK+93izEj1RJDCDqNe7rqcPtuGnR /ag0aYtzH3s5cyHgGRM44SJ+FUsv0Id4XrBchR4XKDljOy6yrv4TxTIWOfzb2w3p9Gdm Fpog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=F1qygqGhD2zLgW/uuEeApHSTD7Ku7C61JEds3dlLSMk=; b=GQQKm7vai6ZedcKQAD7ISVHgSqp6HUE0iDKUDKdPJZWphk5Wj6ALrTOWHxUItylj2L tt3T1yXR57k3yAo1I6PfKj7QrXn93SjErAQ1fzKnJJ4vrYsmSuPNcbcE2kwFOzcFV0Q1 g3TbNpS9AG6/r5DpHGvzOcSrPIrC18NDb2YZtcdfeFGCx9f6ocelxXOnbAFibWV4+k9G hHsGb0Si/iZzdS1j0Suwhuw/wi797GbK39XPON8ikXYGcHgJxPaFJ78qY4QCZ6PYR55s 2gxyLGOS9EcA/l+zMuU09lm9nxsqAqYCdJ7W93Mi2tYbQF3PuTf7poFP8wpwwtHpxc/1 c5QA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4-20020a05640235c400b004615855c483si7223007edc.98.2022.11.06.04.51.00; Sun, 06 Nov 2022 04:51:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbiKFMtj (ORCPT + 99 others); Sun, 6 Nov 2022 07:49:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbiKFMtS (ORCPT ); Sun, 6 Nov 2022 07:49:18 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2B36462 for ; Sun, 6 Nov 2022 04:49:17 -0800 (PST) Received: from ipservice-092-217-068-220.092.217.pools.vodafone-ip.de ([92.217.68.220] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1orf5P-0008Dj-5T; Sun, 06 Nov 2022 13:49:15 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 9/9] staging: r8188eu: remove checks in dump_mgntframe Date: Sun, 6 Nov 2022 13:49:01 +0100 Message-Id: <20221106124901.720785-10-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221106124901.720785-1-martin@kaiser.cx> References: <20221106124901.720785-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748751177194025288?= X-GMAIL-MSGID: =?utf-8?q?1748751177194025288?= There's no need to check for bSurpriseRemoved and bDriverStopped in dump_mgmtframe. The sequence of function calls is dump_mgntframe rtl8188eu_mgnt_xmit rtw_dump_xframe loop over all fragments For each fragment, rtw_write_port is called. This function checks bSurpriseRemoved and bDriverStopped. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 324757699716..17803aca83c8 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3959,9 +3959,6 @@ void update_mgntframe_attrib(struct adapter *padapter, struct pkt_attrib *pattri void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe) { - if (padapter->bSurpriseRemoved || padapter->bDriverStopped) - return; - rtl8188eu_mgnt_xmit(padapter, pmgntframe); }