From patchwork Sat Nov 5 06:01:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp830218wru; Fri, 4 Nov 2022 23:05:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM65TdmQypcQXCtkBpeYzy8mLGyxHbIPDpSHxVvgv6UvFv5r+QFsEFtxc/fNDRbNis4/cjhe X-Received: by 2002:a17:90b:1d09:b0:213:773a:b4b2 with SMTP id on9-20020a17090b1d0900b00213773ab4b2mr49781299pjb.40.1667628342405; Fri, 04 Nov 2022 23:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628342; cv=none; d=google.com; s=arc-20160816; b=n1cnBZPOys2mmpe5fUMUsgsXsUvlMIqIoLRf5OJ8Zg5gvWpjcaNdMAxfoYhLiZ6LLo G0bFb54N0R37dAm7fWxVQTwlERAgRiJpvf4DhwxF+SMCTIwDeojY2U9tN3U+Fqphcn9d SfI0k5bYgC2vT7JgYMWWRUZK0iiTMDlrgxGZDQJAX48y5s8x6rzkBCHkZV8hw/k8fSXm R4+XsxSHhNM1KFljDxznpEyWUKfE5SsIcxPIVsu1zkNuJwNtGz8H1HzOkp2mmGQZ8eCF IeWy3OODmC2FGYfcsVYjg/Z3dqGWRbH2R6nOIKS4aVO6vtA9nrXxecKjAx2oXvC/MELw clEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=RMykPRkJh8nqd/DCR/zs9jXXZ/X5utPEAbrRyFNANxA=; b=xDSAgSTdSFSC7jDvnCsnUcNI2DA2ZWqbKNewtjStKcYR4S6ci7MPYfHixltRp0l2m4 RJjyD/2iLL4LatIY+KLnyrO5++E4DjtqAJ5fpoL0y1/OGwE9alkFv/33adQDSFWQwABk R94MzcqfIb3zlf6/bBpYBOgFBZ+1d9QV917zXPeQ/w+kxWJ6cVylTfr1QXYu4eAEqCca U28HyBG3K+hj+rvqiuX8CrH7zlbk97Q7ASNIbYDW6vGyuVWDg3SBkQd17F+2YJjpCRdb Tt5k6hCRmkVBPflfc3wbvmpQ7jPs9VR7E7nVbUL8fTbOxRKIVGcJfImFwehQPDgsIBFP 9d6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c11-20020a170902d48b00b00186a2274386si2275830plg.469.2022.11.04.23.05.30; Fri, 04 Nov 2022 23:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbiKEGDS (ORCPT + 99 others); Sat, 5 Nov 2022 02:03:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbiKEGBf (ORCPT ); Sat, 5 Nov 2022 02:01:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B08EA3123E for ; Fri, 4 Nov 2022 23:01:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9115360AB6 for ; Sat, 5 Nov 2022 06:01:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C0B7C43470; Sat, 5 Nov 2022 06:01:33 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFl-007Oz9-20; Sat, 05 Nov 2022 02:02:01 -0400 Message-ID: <20221105060201.459104132@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:01:00 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , openipmi-developer@lists.sourceforge.net, Corey Minyard Subject: [PATCH v4a 36/38] timers: ipmi: Use timer_shutdown_sync() before a module is released References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748635056919971795?= X-GMAIL-MSGID: =?utf-8?q?1748635056919971795?= From: "Steven Rostedt (Google)" Before a module is released, timer_shutdown_sync() must be called on its timers. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: openipmi-developer@lists.sourceforge.net Acked-by: Corey Minyard Signed-off-by: Steven Rostedt (Google) --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 49a1707693c9..5cfb85e22d65 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -5540,7 +5540,7 @@ static void __exit cleanup_ipmi(void) * here. */ atomic_set(&stop_operation, 1); - del_timer_sync(&ipmi_timer); + timer_shutdown_sync(&ipmi_timer); initialized = false;