From patchwork Sat Nov 5 06:00:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15910 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp830078wru; Fri, 4 Nov 2022 23:05:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5xgJ1XyBKtO7H1lsw85R9ChaZN9xdHFfdzoGSz/Qv+VJNYDs1MW3X69XnWD1tCS06c0e0v X-Received: by 2002:a17:902:b117:b0:186:a1fd:c3df with SMTP id q23-20020a170902b11700b00186a1fdc3dfmr38824575plr.23.1667628311055; Fri, 04 Nov 2022 23:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628311; cv=none; d=google.com; s=arc-20160816; b=iZyBz6u0B/JLOiJ74CY3M50GCtzu18ZxUs/Kb4UCSACc0E1ZnRKB+Ju6mXghHkwT2T lNK8rME5S67VvuGhDtWNPo1quqC4z2++0EizWQwHmfsj6WokYtkWyr4yu/GWOW0w0332 wRQrrwbgfMzNXY0D3NoE5dWCv/K9/y0stHZSTJXfdoF5XUcD6NZ2a88Ae/YALtD/WF4n 87Yyj3srQjVABjklfIRyUWK75TqZ8gyogaQ7a9YxvJn3q39J31+SoO7ugX8W7XCJ/jr4 gUlGr/By/4yLQ69ogTR8Hhp5ndFfh4GenGjfPDr8/P0wB07ZIxf7TuWz11Ldf6zd3F7t yzMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=JfGj1rAGiTgKeqaHA4ZUyTqSGOgMGU3pY0tJVSJH3NM=; b=0JXJPBV4JaBUpghg6/sfQb6TQTCyXYZpyNxuoKkgzm3L5C0qkevro1Bj5xrSsPg4Cd tJ4TbkY17I2a5PdOdSb4MzunXUn1e4yDvG26TwXdTUH3CgZ1O6hGEXL4x8MkvoepfYtj 3nvvkwDYKt0BXsna4cFe1TRD+7tF2nCjEPm3udB6SMsZY0UraFSaFvWjD7EUQ/FMnV57 13j58RLf11PowWKO3fxk00CclktwcePw+Wr4Us9SM4kq2y5w+xcGH2+/GLTjWvOunRS1 DzBKO0z6qDSpHKYFXqkRV4SwyhT4OowmgN4S3NGpiI/6/Yfj7MfzbVvQ/2/28oxeit46 gJTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b16-20020a170902d51000b001853ad3944dsi2402722plg.480.2022.11.04.23.04.58; Fri, 04 Nov 2022 23:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbiKEGDL (ORCPT + 99 others); Sat, 5 Nov 2022 02:03:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbiKEGBf (ORCPT ); Sat, 5 Nov 2022 02:01:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53AC631238; Fri, 4 Nov 2022 23:01:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3582960AB2; Sat, 5 Nov 2022 06:01:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10253C4347C; Sat, 5 Nov 2022 06:01:33 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFl-007Oy1-0o; Sat, 05 Nov 2022 02:02:01 -0400 Message-ID: <20221105060201.081948530@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:58 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH v4a 34/38] timers: atm: Use timer_shutdown_sync() before a module is released References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748635024394989339?= X-GMAIL-MSGID: =?utf-8?q?1748635024394989339?= From: "Steven Rostedt (Google)" Before a module is released, timer_shutdown_sync() must be called on its timers. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Chas Williams <3chas3@gmail.com> Cc: linux-atm-general@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- drivers/atm/idt77105.c | 4 ++-- drivers/atm/iphase.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atm/idt77105.c b/drivers/atm/idt77105.c index bfca7b8a6f31..cc4a5449ca42 100644 --- a/drivers/atm/idt77105.c +++ b/drivers/atm/idt77105.c @@ -366,8 +366,8 @@ EXPORT_SYMBOL(idt77105_init); static void __exit idt77105_exit(void) { /* turn off timers */ - del_timer_sync(&stats_timer); - del_timer_sync(&restart_timer); + timer_shutdown_sync(&stats_timer); + timer_shutdown_sync(&restart_timer); } module_exit(idt77105_exit); diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index 324148686953..9be45d9d66b3 100644 --- a/drivers/atm/iphase.c +++ b/drivers/atm/iphase.c @@ -3280,7 +3280,7 @@ static void __exit ia_module_exit(void) { pci_unregister_driver(&ia_driver); - del_timer_sync(&ia_timer); + timer_shutdown_sync(&ia_timer); } module_init(ia_module_init);