From patchwork Sat Nov 5 06:00:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15894 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp829231wru; Fri, 4 Nov 2022 23:03:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM73UE+u0iZT2P9xak36AZoSXuOauCBVHJPE9/fyVk0BgnaYGs0PGO24zMowK79or2C+rgRs X-Received: by 2002:a17:90b:30c1:b0:213:a155:949c with SMTP id hi1-20020a17090b30c100b00213a155949cmr40821140pjb.76.1667628194113; Fri, 04 Nov 2022 23:03:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628194; cv=none; d=google.com; s=arc-20160816; b=EvqlswqwPSlmAE3+z2Sz94dtO3B6ycX4M5cjIlIiNUXmdQxy/A4LsN/7gsLlFN97FU 1JetCWNCoTbtHF7MiYkNk0srPYJK4qW+GECNDCq1AJw/wyoZfVVCTJM23oCQqKWFJaKU B7Bke+2shy+2m2dOD3TCTmyDw9D/XL5Nfv3zX6QjRHWeQye597m7vtsQ7ost2qfqJpI8 YXvd8bCdNpbJpnuZlnyaCOzJds8xTw4oQQZ7FSPA7CQXx3W7DKu6i5tDJOImMhKiKj6z 2BB/LrVHuNYEppEg2tVBSHMYcwlvUVsSCbqoq90F5fCA29XMcv01cyD11PdKtXRDfYH3 uwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=16n1BYpYtSopzGMr7U/svmzw+5t5uvVZQr2/uUoaCCw=; b=TH4qnlsc9NvaTgkrRNCJvq+jFulE/Mt+YOBs2VYHJqcR+SIwGObrU3NZ5V8BixEFwO +fnpyWopPPi86W53gcIIECgxIAFZRyKUNO0kfsrAu5Wj5kpY8Q7nSj2EiiN4JOOSuA9F 9Z55tRvvISo3umyH29RIPHbnEX8lvaVyIkDpUBnGkzb53X6ca35wPXF9lovqZSFsYySk rd4LIq66aq2K0RFWD+sNoymTa7A00qsAvldWKp8vRVNnlpK2DYLyCIyXH4Y+hCcGknUQ XCMntSOLs+u/Oc1IRIEKPiLSMfjTxwrwu0ujg5cMq2uk0iyhiDQs3fcFh8d8tl2U3IhD kxcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a65580d000000b0046f580656c8si2170956pgr.351.2022.11.04.23.03.00; Fri, 04 Nov 2022 23:03:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229789AbiKEGCI (ORCPT + 99 others); Sat, 5 Nov 2022 02:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiKEGBe (ORCPT ); Sat, 5 Nov 2022 02:01:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AEF330548 for ; Fri, 4 Nov 2022 23:01:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CFB5609AD for ; Sat, 5 Nov 2022 06:01:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27DB0C43470; Sat, 5 Nov 2022 06:01:32 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFk-007OvC-15; Sat, 05 Nov 2022 02:02:00 -0400 Message-ID: <20221105060200.173378298@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:53 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , "Theodore Tso" , "Jason A. Donenfeld" Subject: [PATCH v4a 29/38] random: use timer_shutdown_sync() for on stack timers References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748634901141221443?= X-GMAIL-MSGID: =?utf-8?q?1748634901141221443?= From: "Steven Rostedt (Google)" Before a timer is released, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: "Theodore Ts'o" Acked-by: Jason A. Donenfeld Signed-off-by: Steven Rostedt (Google) --- drivers/char/random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 69754155300e..943b4b2712a5 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1233,7 +1233,7 @@ static void __cold try_to_generate_entropy(void) stack.entropy = random_get_entropy(); } - del_timer_sync(&stack.timer); + timer_shutdown_sync(&stack.timer); destroy_timer_on_stack(&stack.timer); mix_pool_bytes(&stack.entropy, sizeof(stack.entropy)); }