From patchwork Sat Nov 5 06:00:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp830802wru; Fri, 4 Nov 2022 23:07:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/HJgEQLh4klfgkVOqLC31ghIDqrADmWoRBuyXoVHFQL+Z6YOuUSiRJaCXEI2E/FDyHQF1 X-Received: by 2002:aa7:8d17:0:b0:560:485a:e242 with SMTP id j23-20020aa78d17000000b00560485ae242mr39115597pfe.31.1667628463958; Fri, 04 Nov 2022 23:07:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628463; cv=none; d=google.com; s=arc-20160816; b=Zz7buLXqXcZqCpcg+aYRotDoZ9afN1oJwfUv8CSKpHEftIsrN5UDbuj+nA4gxZgoqM OxS37p4QhJGnyAJ460QQZBANadSZ9W+45vMxux6EQUPWeREl+w0qyLxVXLvx5m0iOoRJ 3UKW1c+ksjrYpU88fjG9uERFg0Hkod8o6JOAOnU6FV3UhA23ZLh2Dnz6JIFfr85Goxvb ayoDrSXNApMXY1CoI/LG1d91eTOdQHlARvP31Xhup8ytJZlnEW62VzxuvNFPnp+CB7TA JHsszMKlIk3qgLx09X46FY3wlZ3kI0TKWq6+2iq86n/4BKYAQZ+vCZNse269+sJvEcS4 F29g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=xf+1COUy22vuKe2EBC1hSgEKdt0sVUJK5Wk6pWpV/cU=; b=S1FP2kcQRi6+e4ZvQTpNuXYWDcJGIzcaob7cBwnWW6PwMg+FJJgD3Ynz9db4TAyPYJ bZAZHV0qXLqvwt3phPb6JYUhofA8PiNjp+nQpwBRkJU1JDElbPJfiS53vMOaAe8j1AxM 5rVxg9FWXieOD0ywOFIYYwDh0VPmW5ukVGQ/hUHzAZzjmFnNGNMGZfD1uihlVXlCQDHP 6yooC4V8uSNcemG4Bg+N5hiKvOt+keMIs300Nfl3pNz6B+YUX8sx5hiFMRY3lX4wtsyQ vtTJIpieV4hb8495BU1hdKk69OfNDXm/8En3DTWHbx60bZtA8rEsKqgTh5iPV/XLj3oi 4fNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 26-20020a630c5a000000b0046ebe02836fsi2091923pgm.504.2022.11.04.23.07.29; Fri, 04 Nov 2022 23:07:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbiKEGDd (ORCPT + 99 others); Sat, 5 Nov 2022 02:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiKEGBf (ORCPT ); Sat, 5 Nov 2022 02:01:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 887C330562 for ; Fri, 4 Nov 2022 23:01:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 45DA2B830BD for ; Sat, 5 Nov 2022 06:01:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 055FAC433B5; Sat, 5 Nov 2022 06:01:32 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFk-007Oud-0U; Sat, 05 Nov 2022 02:02:00 -0400 Message-ID: <20221105060159.989028673@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:52 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Tejun Heo , Lai Jiangshan Subject: [PATCH v4a 28/38] timers: workqueue: Use timer_shutdown_sync() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748635184382647163?= X-GMAIL-MSGID: =?utf-8?q?1748635184382647163?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Tejun Heo Cc: Lai Jiangshan Signed-off-by: Steven Rostedt (Google) --- kernel/workqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 7cd5f5e7e0a1..2bbea15be4c8 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -3608,8 +3608,8 @@ static void put_unbound_pool(struct worker_pool *pool) wait_for_completion(pool->detach_completion); /* shut down the timers */ - del_timer_sync(&pool->idle_timer); - del_timer_sync(&pool->mayday_timer); + timer_shutdown_sync(&pool->idle_timer); + timer_shutdown_sync(&pool->mayday_timer); /* RCU protected to allow dereferences from get_work_pool() */ call_rcu(&pool->rcu, rcu_free_pool);