From patchwork Sat Nov 5 06:00:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15915 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp830506wru; Fri, 4 Nov 2022 23:06:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5dry6402AAvxFfZyr4OyLPb2UUQuYgnMNUdEXGEItFaY08YI/JB/eoNlp1ph4OM0jXKJL5 X-Received: by 2002:a63:3182:0:b0:46f:ed32:54a6 with SMTP id x124-20020a633182000000b0046fed3254a6mr19006345pgx.69.1667628404389; Fri, 04 Nov 2022 23:06:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628404; cv=none; d=google.com; s=arc-20160816; b=HXOk+cbdjkmHh6+5ZomF9YbzeITd8HXR1lY/toQ4hXfXbQsO+h40FiLd6TTdfBUKJA d6RlZcIqbZZzw1lSAPbVwZVVgc5EpSdEcdguHyHi7ndypyL1R0OscbZ4uD5uABNRxvmh NkEWC7NJMx5kPKYadrmGHaaYftwr42EdJ+uYykogZtxZPDXmQICZWz8emALRa7Pq9X5i 5t5XQwBztydqsu59oDy5+D+FXfH0td9WuVmi59fGtWa6OAbmKdbwbDNnau0VSozp7Ism NOM+p6UY5nCf/z7tmpinWAEGEw3Wxk1eAkr378x4b+r7zuXkOIChNMGy65e8SZcm4mGF SS5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=7vFJhrnylY1JvvO8pW+uN4POqaMSpNYfbRYWRXHFx3U=; b=EoEIv5elqla4GIYyCx7pBgsEGT4o0Z/UsHw+GC4UgugWnu47WaGaRunrKVQEs5MZ0g uGsx2W6HWcvlK7gunqWD98IymcRqDy5DzMsFs1mriT8WsirEDhsJnOUAUvUJ59bgAcrM yjN7plVVMK19g3EqgXp6z+4mFZMCxVxqDdcjD/Vz4I9py7DrjnqEEvFFX5BtxUiFbj0O ekEA4ATBN7Mfaaimz398Gl0a2c+H706GqGMTcj8g1Bdupfvv6KsmdLCCtAxLw5J8FPHV rYsCGV/HL6YF7247Qo86S6n5Aw1DwyU4mNFarGCivu18RMgG147q1l6FuiNViT19Xv+Y 5wGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q18-20020a17090311d200b001769fce8c2fsi2276726plh.485.2022.11.04.23.06.30; Fri, 04 Nov 2022 23:06:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbiKEGD2 (ORCPT + 99 others); Sat, 5 Nov 2022 02:03:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiKEGBf (ORCPT ); Sat, 5 Nov 2022 02:01:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB6D2D763 for ; Fri, 4 Nov 2022 23:01:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F1BBB830BE for ; Sat, 5 Nov 2022 06:01:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C41B9C43143; Sat, 5 Nov 2022 06:01:31 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFj-007Ou4-34; Sat, 05 Nov 2022 02:01:59 -0400 Message-ID: <20221105060159.794397196@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:51 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Johannes Weiner , Suren Baghdasaryan Subject: [PATCH v4a 27/38] timers: sched/psi: Use timer_shutdown_sync() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748635122090766953?= X-GMAIL-MSGID: =?utf-8?q?1748635122090766953?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Ben Segall Cc: Mel Gorman Cc: Daniel Bristot de Oliveira Cc: Valentin Schneider Acked-by: Johannes Weiner Reviewed-by: Suren Baghdasaryan Signed-off-by: Steven Rostedt (Google) --- kernel/sched/psi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index ee2ecc081422..f5f2613c4292 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -1033,6 +1033,7 @@ void psi_cgroup_free(struct cgroup *cgroup) cancel_delayed_work_sync(&cgroup->psi->avgs_work); free_percpu(cgroup->psi->pcpu); + timer_shutdown_sync(&cgroup->psi->poll_timer); /* All triggers must be removed by now */ WARN_ONCE(cgroup->psi->poll_states, "psi: trigger leak\n"); kfree(cgroup->psi);