From patchwork Sat Nov 5 06:00:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15895 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp829266wru; Fri, 4 Nov 2022 23:03:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM519RM84FdySWVaFMarIf0CCEHKIcz4FxEPk6xdepY9gnn+os6CMZCUsX9YcNZ7rs8Cm587 X-Received: by 2002:a17:902:d1d3:b0:187:3d23:3490 with SMTP id g19-20020a170902d1d300b001873d233490mr21008064plb.149.1667628198248; Fri, 04 Nov 2022 23:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628198; cv=none; d=google.com; s=arc-20160816; b=yHoyCvQDEm/XOqhjpNkvHD+9QEev0XTVMTCP5IWYllMFxUnG0Xx1x9Xit4XLStKb0N nTfkROxRJXVAygqfL+tYfL0RpZoVV6xT4WN5V8f9OwrU7A0eXDBzpDzzyPsLizSAyWgv OiatU0w8UcZzd+LWlbvP/VITZGoN5K8z1ltoZ7Zb6LiFprWUPIH3+UoI2AwTQjqYLkIM cy8W64DaNhhd60+A50bl3SPqgheJYJF3FO1OO9blWj4uZg18piFt8sDddpx6Y9ZXFmCp 00DgAv5dtBtxwANcr9dMMHmvHry2P5baf+fFNTduurvbkj2Dip6wGkhDkP49KdITmu/D kimg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=Axm+5dzR0kf7WsruM1SV3u2EM8oQp0lKkRwYE8wIbvs=; b=zTn3jh9aqs/RBqFCnV7ckkfkp3S6OF91un+pKUoo7TyJNo3MTdC/LE7zvogxuyZ3/+ C6ayjKhCGYN6g5d206/vp83M2lU5ICjSWhufxGIg5ifwxLlA7FXyWdwm/pPzzmwdCkUM xXeaGp7i7XiKSKqZs/+Ly/Zf2FxAp6EMK/x5TEyQthqVWAOoS5ed5F923IUhFCMS7I/H WJj3bSl5mr9dZ9FbeeyZs7dzb5I5TY5QctQN1wGY6QBnnavDZyCTAW/Di8gkRFMa06cr OPal+B3tTLWn1v3a4db0Fqak/HBBshAXWIDWE9W5JXgwIUGzfJwQ1/amQsnaIJvIDxXF WG1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a17090a8a0600b0021406fde039si1675324pjn.156.2022.11.04.23.03.05; Fri, 04 Nov 2022 23:03:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbiKEGCV (ORCPT + 99 others); Sat, 5 Nov 2022 02:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbiKEGBe (ORCPT ); Sat, 5 Nov 2022 02:01:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252CD3121F for ; Fri, 4 Nov 2022 23:01:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0636760A2C for ; Sat, 5 Nov 2022 06:01:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D65C43470; Sat, 5 Nov 2022 06:01:31 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFj-007Osw-1v; Sat, 05 Nov 2022 02:01:59 -0400 Message-ID: <20221105060159.433729602@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:49 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Jaroslav Kysela , Austin Kim , alsa-devel@alsa-project.org, Takashi Iwai Subject: [PATCH v4a 25/38] timers: ALSA: Use timer_shutdown_sync() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748634905256798028?= X-GMAIL-MSGID: =?utf-8?q?1748634905256798028?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Jaroslav Kysela Cc: Austin Kim Cc: alsa-devel@alsa-project.org Reviewed-by: Takashi Iwai Signed-off-by: Steven Rostedt (Google) --- sound/i2c/other/ak4117.c | 2 +- sound/synth/emux/emux.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/i2c/other/ak4117.c b/sound/i2c/other/ak4117.c index 1bc43e927d82..640501bb3ca6 100644 --- a/sound/i2c/other/ak4117.c +++ b/sound/i2c/other/ak4117.c @@ -47,7 +47,7 @@ static void reg_dump(struct ak4117 *ak4117) static void snd_ak4117_free(struct ak4117 *chip) { - del_timer_sync(&chip->timer); + timer_shutdown_sync(&chip->timer); kfree(chip); } diff --git a/sound/synth/emux/emux.c b/sound/synth/emux/emux.c index a870759d179e..0006c3ddb51d 100644 --- a/sound/synth/emux/emux.c +++ b/sound/synth/emux/emux.c @@ -129,7 +129,7 @@ int snd_emux_free(struct snd_emux *emu) if (! emu) return -EINVAL; - del_timer_sync(&emu->tlist); + timer_shutdown_sync(&emu->tlist); snd_emux_proc_free(emu); snd_emux_delete_virmidi(emu);