From patchwork Sat Nov 5 06:00:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15898 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp829315wru; Fri, 4 Nov 2022 23:03:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4fLB8zzj1dMsvssS5uQQjZO3iN8pS0FqCLzZYXKs8tsMgaCdrpjfwwverPJj9TjCjrle0O X-Received: by 2002:a05:6a02:192:b0:43c:a0cb:44d3 with SMTP id bj18-20020a056a02019200b0043ca0cb44d3mr34639389pgb.139.1667628204540; Fri, 04 Nov 2022 23:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628204; cv=none; d=google.com; s=arc-20160816; b=HUwfUcxELO+tUnS2jqbqDX1G6fbTvyG25NsFrMDqdjQz7ve5zNrPjujy9e5oPbpGsL A77jhjvs4ot6L1hUKzV4I79bvMUBk6x84qGfJBEBZLYWGEoVp7zOlxaA5vNbPqoJgk32 fO/Yn2gs0J57LKbYbE70+YrFA34+8oMUQOsGtLwoqY/2Y6SAs99dGG4qKHjDqPMV6NSR 8uHGMfr8l+COo0Q+CdbvA0FaDMIH+h/9wE9gCcmsDVNkr7EGKeJZ5Js0bXfinOvL2KvG ApZUrKbQs9djuHJrAEcYBzisqBvovkgqMBkjkucJUUnK2TQ9YrdutDmQomH1UDPra4+A nBdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=UtwdN/2ce11CHhCdK/ZVgvt5gRvffYj5ZcYkrq4yEwQ=; b=bOFxK5uvb3NJZ5CoGmj1+9grHXajmQAuOPS721/jFAzH4qjUU+PNBD8zwi0hp/nOqx yYf2eqKtPLbQJ2yed/7kX+eU29XoqUSRVBA9jLP6nLAb/9odzWBMnEUNPDCk99KZLGtE o3D5QoWHakE4zlc9EA8/vN/DrXt6qSWWcKxrEmuyxIcWcG6n+ep/NXz6g10nLfrg61tN X+0OPdXnFkiPC9wb9ImKnJ98+KSIomvnhWsTjSIJzZS9jBUI+1Z+GtUW2T1sIjtrB7bE tczWUKLGCOfwkR5Jb+kgAyr9Q29tQ1CIVdf8ut5pIi8XmqaGjeTq2Tf0QNrLrHB5OmWO nl6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds3-20020a056a004ac300b00557e3e7c420si1575616pfb.213.2022.11.04.23.03.11; Fri, 04 Nov 2022 23:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbiKEGCS (ORCPT + 99 others); Sat, 5 Nov 2022 02:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbiKEGBe (ORCPT ); Sat, 5 Nov 2022 02:01:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 125E73121D; Fri, 4 Nov 2022 23:01:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D40F609EB; Sat, 5 Nov 2022 06:01:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08763C433D7; Sat, 5 Nov 2022 06:01:31 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFj-007Orn-0j; Sat, 05 Nov 2022 02:01:59 -0400 Message-ID: <20221105060159.054190416@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:47 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , linux-ext4@vger.kernel.org Subject: [PATCH v4a 23/38] timers: ext4: Use timer_shutdown_sync() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748634911721838620?= X-GMAIL-MSGID: =?utf-8?q?1748634911721838620?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc :"Theodore Ts'o" Cc :Andreas Dilger Cc: linux-ext4@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 7950904fbf04..f54ed936d800 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1225,7 +1225,7 @@ static void ext4_put_super(struct super_block *sb) } ext4_es_unregister_shrinker(sbi); - del_timer_sync(&sbi->s_err_report); + timer_shutdown_sync(&sbi->s_err_report); ext4_release_system_zone(sb); ext4_mb_release(sb); ext4_ext_release(sb);