From patchwork Sat Nov 5 06:00:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15900 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp829343wru; Fri, 4 Nov 2022 23:03:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4le2AQ4TJnvecpxUAVHrnX4qde2GZ4+qzfvq1KrBFCZonyzyWk6UXH91SQEjeUPosziOAT X-Received: by 2002:a17:90b:128a:b0:213:26c2:2c06 with SMTP id fw10-20020a17090b128a00b0021326c22c06mr56136958pjb.26.1667628208313; Fri, 04 Nov 2022 23:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628208; cv=none; d=google.com; s=arc-20160816; b=vtQzE/Hf4BWQqL8HmiBnCH7jDvy4J/1qQCVhvRHVpHyUrorLuOFXn401xY3vtDzbfY NSgCfVdVpsygohyGzCgGMRhqJDCYjYTljMzYLUwg1UkGx/17GVQztlF6X42Fb9lBbXJ3 2HuzpqfVB/y2jLO40dLjw7fUtL/qFdcGIaeT3SaGSiF4cd/tGdrVQYxDVJsagw5Pk1wP 908Y74iS9pVTvNDiMYJKm45sMRoonuJ/l87Yl/ha+MiiEV+xYx8FA8As/xPhHgy1yFwR dp+kaEl/bHmFEarRPLexojxh77SIJrIk/vvgyCZtbSaLtLQAMgKTEUaPtgiTzdRwodzf dSyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=au/n49Q8tQrqMo441qcmAIzJYGvrLwmLpcOThtIFNYI=; b=j/ofKrOIPRQHnd4lk4ZoD9mWU5NGlLnW//pCQD4lPqqbvwl5D9pjPt2SdYixRe/pT+ k+HndXKGTy/g+O4tW8fE/TwEHZGNHodeK9WrcHgPOeGeNd0i9qovlxuP+7KG9Ph/AuZv 4p4I7gaGb062//966jXA5TyIut5X7dPHl9EpX/E7400GhQDVZLVowbcb+ONRTB+R7Gom S+LF7e/YSxXDkU1p+EmH4lq+KMSast/DkV3rtLFlVz6CKKSPTd2rToz/pSjSSPRfywGc 51KQoWl/ZcTjH+C0QfPPHUgTbgmljxrTkh0w27edkDR67P0enoxWS9ufo6C7wrz42JDU SYTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a63de02000000b0046271a622cfsi2159378pgg.550.2022.11.04.23.03.15; Fri, 04 Nov 2022 23:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbiKEGCc (ORCPT + 99 others); Sat, 5 Nov 2022 02:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbiKEGBe (ORCPT ); Sat, 5 Nov 2022 02:01:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B416A2D1F7; Fri, 4 Nov 2022 23:01:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C756160A48; Sat, 5 Nov 2022 06:01:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A268CC43141; Sat, 5 Nov 2022 06:01:30 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFi-007Oqg-2k; Sat, 05 Nov 2022 02:01:58 -0400 Message-ID: <20221105060158.686330249@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:45 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH v4a 21/38] timers: scsi: Use timer_shutdown_sync() and timer_shutdown() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748634916313976896?= X-GMAIL-MSGID: =?utf-8?q?1748634916313976896?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called, or timer_shutdown() if it's already known that the timer is disabled. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Nilesh Javali Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- drivers/scsi/qla2xxx/qla_edif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c index 00ccc41cef14..7f3a3c8673b5 100644 --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -416,7 +416,7 @@ static void __qla2x00_release_all_sadb(struct scsi_qla_host *vha, */ if (edif_entry->delete_sa_index != INVALID_EDIF_SA_INDEX) { - del_timer(&edif_entry->timer); + timer_shutdown_sync(&edif_entry->timer); /* build and send the aen */ fcport->edif.rx_sa_set = 1; @@ -2799,7 +2799,7 @@ qla28xx_sa_update_iocb_entry(scsi_qla_host_t *v, struct req_que *req, "%s: removing edif_entry %p, new sa_index: 0x%x\n", __func__, edif_entry, pkt->sa_index); qla_edif_list_delete_sa_index(sp->fcport, edif_entry); - del_timer(&edif_entry->timer); + timer_shutdown_sync(&edif_entry->timer); ql_dbg(ql_dbg_edif, vha, 0x5033, "%s: releasing edif_entry %p, new sa_index: 0x%x\n",