From patchwork Sat Nov 5 06:00:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15906 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp829447wru; Fri, 4 Nov 2022 23:03:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM56ZpBtWFFRMpXCl///OJml3QglDWmBdAa0WIMyM84yE8qZH/zFTXHcNcMhTOVxJDmvQBX5 X-Received: by 2002:a17:902:ec81:b0:187:226d:7f9a with SMTP id x1-20020a170902ec8100b00187226d7f9amr30102368plg.164.1667628222429; Fri, 04 Nov 2022 23:03:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628222; cv=none; d=google.com; s=arc-20160816; b=BLvn5PzZLx1KtTxv+DnmDNLK2pGkT/3RpF7Ce/rLeN1+p7lFJ3ilzcs2BDziXwHkw8 JdzQH0roFHiX1JcFLA9706R68BXjgUl8hwYgSw8YtoTYu5JUA1PXEazsljXHulW9u9Xo WPXJap66z4gpCu9dDLX+bWg/bz6zoSRjtitFQskG3vk1NMcPGlWMTlM5t4CDxUkRuPXz YqEno59fJH/Abn73IZD2vmuzosj8kZv6ORGWZmAtHRrKKzYdbrc40JNerJ6suhYlY8DF lS8xzRK+XyHUkTy8h2TADfvOuwbzBvuF/AkZqIuflrnGOU9oulMDTVdTq5I8ujfWrrnM 3mfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=h3EvqLoy6pfqFb5s8t0W3WRphuqrx+hdmxxXiIUMaQk=; b=FgI1gPwJRcK47i64CvwOBFshVHJJupK3/Q4D8Beu6sky4OCqS1d4Md2BkcOzxOnmp0 t1ef5yFDU12en5+X+HYEH16hhqLx+EUmDf2NKVBXIEOM3pICtlPw39xxpnWquJLjBvjl mSLrDeQj0XQ28P+/Km7fJSK+YIQNsIbDaRLQLclwa6gYqaXcdgkjVQhc4mouUNrniTzc cuX4xrXWj4pD/V5NuN+0BckFbp53gYKWstgPLYsZsm3s9VkEzcmaVsbb3fg59oC2zXr1 o5ciZswwCUYVj1GCH8pqz1FP8GiYhYZgHrC1Cul0eQGscHKsUIeD2Qms75TLWfDwE+Aq P5bQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c11-20020a65674b000000b0041b577f3356si2170758pgu.720.2022.11.04.23.03.29; Fri, 04 Nov 2022 23:03:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbiKEGCt (ORCPT + 99 others); Sat, 5 Nov 2022 02:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbiKEGBc (ORCPT ); Sat, 5 Nov 2022 02:01:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14E030F46; Fri, 4 Nov 2022 23:01:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B5A0B60A25; Sat, 5 Nov 2022 06:01:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 900FAC43470; Sat, 5 Nov 2022 06:01:29 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFh-007OnI-2T; Sat, 05 Nov 2022 02:01:57 -0400 Message-ID: <20221105060157.600537824@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:39 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Pavel Machek , linux-leds@vger.kernel.org Subject: [PATCH v4a 15/38] timers: leds: Use timer_shutdown_sync() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748634930574575327?= X-GMAIL-MSGID: =?utf-8?q?1748634930574575327?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Pavel Machek Cc: linux-leds@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- drivers/leds/trigger/ledtrig-pattern.c | 2 +- drivers/leds/trigger/ledtrig-transient.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c index 43a265dc4696..e996d61e3bd6 100644 --- a/drivers/leds/trigger/ledtrig-pattern.c +++ b/drivers/leds/trigger/ledtrig-pattern.c @@ -430,7 +430,7 @@ static void pattern_trig_deactivate(struct led_classdev *led_cdev) if (led_cdev->pattern_clear) led_cdev->pattern_clear(led_cdev); - del_timer_sync(&data->timer); + timer_shutdown_sync(&data->timer); led_set_brightness(led_cdev, LED_OFF); kfree(data); diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c index 80635183fac8..f111fa7635e5 100644 --- a/drivers/leds/trigger/ledtrig-transient.c +++ b/drivers/leds/trigger/ledtrig-transient.c @@ -180,7 +180,7 @@ static void transient_trig_deactivate(struct led_classdev *led_cdev) { struct transient_trig_data *transient_data = led_get_trigger_data(led_cdev); - del_timer_sync(&transient_data->timer); + timer_shutdown_sync(&transient_data->timer); led_set_brightness_nosleep(led_cdev, transient_data->restore_state); kfree(transient_data); }