From patchwork Sat Nov 5 06:00:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15909 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp829933wru; Fri, 4 Nov 2022 23:04:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5d4ImkBK9eGvPwNXZaRIjU/7SpnQCabtYsmk731EwoBmiJY8EmLzbExKeUV0fPJ+eEKJrg X-Received: by 2002:a17:90a:7061:b0:213:da75:f149 with SMTP id f88-20020a17090a706100b00213da75f149mr32262604pjk.85.1667628289013; Fri, 04 Nov 2022 23:04:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667628289; cv=none; d=google.com; s=arc-20160816; b=K/Gjm9mgt2W+KRQ6JWPzXMIsRNJYhtvNHTYwhqT0QPa/TWdxi/w+lZICJHVmCAu/k8 U1djMNDwkf4cMyilkAfGngvvTy/9byLOM9YWw+GTqpMKcoxGSJAOlxKAOL7kiW3WP5A5 78W7cGMC211XODE9v2kuLOapfpft/rCDOhiHb0i+o5ufeWFck8aSJx+Ikbsa37OtDuuZ ifKIbiyaDWSNlnnV/VDWgJw9P9OOmcrhlkp8R3gkNMRllCkvR5Fso/SLgLsVYy7IcCt+ uVsBHCaQX6HuhsX73TVfc3X4Rpn7+DqUrc/qtpS2CW74lR2m3oeyP5wVRr7G33NQgTZb YBHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=CqBFgolRWgug6E2gGNJzXZFY/P7ssFQv95w87kGNbXk=; b=NAhydTv5qjFrYxaW88GLqc8j4yedJ2A+omKwJurrMCVkv+kO5z5kAzC2ncYluNX8og avOOHr46YmJJzv5dTubMO9Z5aSjY0y1xTjEdRF8rITTU3RMGTGhVC0LEKVzK9CZTuK0B 9z0UHjH+oCz79le6q04XNufuxAp1yqm2Yb22WGOyal/sxjR+1rWUNNwOnvJO68xCyzUU pQaULa100XQopPEqTxuoJtqiMm/MahmWV2YHDf+Sx8SNkU5SzHg/OKE12ZxMx0muoE2t Rup1/qYuYtAt59h3pxu2XhwxH1jNStdPL4jkV7BRje9IAF0zuSy4Nd7XZ6uDpXQ5JfGo pN4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a170902e81200b0017f61ac5a53si2532599plg.111.2022.11.04.23.04.36; Fri, 04 Nov 2022 23:04:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbiKEGDH (ORCPT + 99 others); Sat, 5 Nov 2022 02:03:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbiKEGBa (ORCPT ); Sat, 5 Nov 2022 02:01:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 920273055C; Fri, 4 Nov 2022 23:01:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 063B0609AD; Sat, 5 Nov 2022 06:01:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 739A1C43152; Sat, 5 Nov 2022 06:01:28 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1orCFg-007Ojt-29; Sat, 05 Nov 2022 02:01:56 -0400 Message-ID: <20221105060156.498024847@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 05 Nov 2022 02:00:33 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH v4a 09/38] timers: atm: Use timer_shutdown_sync() before freeing timer References: <20221105060024.598488967@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748635000354513962?= X-GMAIL-MSGID: =?utf-8?q?1748635000354513962?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ Cc: Chas Williams <3chas3@gmail.com> Cc: linux-atm-general@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- drivers/atm/idt77252.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 681cb3786794..99cae174d558 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -2213,7 +2213,7 @@ idt77252_init_ubr(struct idt77252_dev *card, struct vc_map *vc, } spin_unlock_irqrestore(&vc->lock, flags); if (est) { - del_timer_sync(&est->timer); + timer_shutdown_sync(&est->timer); kfree(est); } @@ -3752,7 +3752,7 @@ static void __exit idt77252_exit(void) card = idt77252_chain; dev = card->atmdev; idt77252_chain = card->next; - del_timer_sync(&card->tst_timer); + timer_shutdown_sync(&card->tst_timer); if (dev->phy->stop) dev->phy->stop(dev);