From patchwork Fri Nov 4 05:41:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15362 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp191653wru; Thu, 3 Nov 2022 22:54:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4OkZ7t/HBxjhQ8gc7+RqnPm68hZEdUiQi7BpNTos1iW1Gtd79h9Qye5SbFvHzQdYIzm/W3 X-Received: by 2002:a17:907:7633:b0:7ad:df69:8abc with SMTP id jy19-20020a170907763300b007addf698abcmr22951131ejc.189.1667541243799; Thu, 03 Nov 2022 22:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667541243; cv=none; d=google.com; s=arc-20160816; b=bUGdZL2osmAK68cRUZh3OWI/aXUWpf1nJEesFLPNf1Ocb8e/6F+zZwVt2XZkYoVjrl lHtxOH7nVAGwPcYy33TD3YPkzigLyvog0Wi0rG1qxN7NLnIhVq4a/26mmU1EiTGuqxg0 cwoiAZ7ciLPcxM+gT9ctOkfsfvdNmjsEq11X2W1MRtJ8nx6iONduCrrNcgUkJu9vjIuD vUQ3C8prnX/+HDC5sg/QiHOjsn0rfBvsbrFf51dBkFHwBELk+QnKWAuf7vbkNi4gz3vQ Eaan+5XIrkuwwNVnsUdST6efUapkdiagr3/7MoK78/RVPqVIPR0yeBq6XajM5mYkt2/Z fADA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=v9WGMDWBQsiNM215VQeVdRMrnbLfSyiJ0+LKji4u86M=; b=BD7X+ARR86STWBxojYd4LYhrKa8KW4/4GgnBkXTys4Mjtrs587pAt/jibkMHcUa0SI NZdW2DelDUc29kJUtoaumI2IvZLlxrCIf+dpSCguFqWPrVC7hAuf5/7Lqqhw2M7/WjWh SK8N+6s/UKYosS8rCjwJ8j7wyMTw2q3zS38xnQfSSg6W0EIgxW7jmYHXc50XUDbSo0Rg EclFErCk6fxBnOVbxk5FARC0ritPdiytHNRkhHLs1vbh11wceczlt1EfnM7ozytIWVT2 AOWEz+iAyJFC2DkdHpFgjTvK1J9/pYAqIYid3j+Q+apWbFkV5xcAp8gZqWn3Shcza9R6 BSVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ba9-20020a0564021ac900b0045ddb2076casi3509496edb.177.2022.11.03.22.53.39; Thu, 03 Nov 2022 22:54:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbiKDFuq (ORCPT + 99 others); Fri, 4 Nov 2022 01:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbiKDFsy (ORCPT ); Fri, 4 Nov 2022 01:48:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F72A28E09; Thu, 3 Nov 2022 22:48:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B93FA620E5; Fri, 4 Nov 2022 05:48:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 960B6C433D6; Fri, 4 Nov 2022 05:48:50 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oqpZt-0071Da-0X; Fri, 04 Nov 2022 01:49:17 -0400 Message-ID: <20221104054917.009383303@goodmis.org> User-Agent: quilt/0.66 Date: Fri, 04 Nov 2022 01:41:21 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: [RFC][PATCH v3 28/33] timers: fs/nilfs2: Use timer_shutdown_sync() before freeing timer References: <20221104054053.431922658@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748543727288933581?= X-GMAIL-MSGID: =?utf-8?q?1748543727288933581?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Ryusuke Konishi Cc: linux-nilfs@vger.kernel.org Signed-off-by: Steven Rostedt (Google) Acked-by: Ryusuke Konishi --- fs/nilfs2/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index b4cebad21b48..c50dc377da26 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2752,7 +2752,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci) down_write(&nilfs->ns_segctor_sem); - del_timer_sync(&sci->sc_timer); + timer_shutdown_sync(&sci->sc_timer); kfree(sci); }