From patchwork Fri Nov 4 05:41:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp191135wru; Thu, 3 Nov 2022 22:52:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Ve65u1CEsNLSh82ZkZKAg8FztYyC+CF/luFsuj2WRRZKNoWW0ETzbi59mqBLhB65wKLQ7 X-Received: by 2002:a17:906:1252:b0:7ad:8f76:17c7 with SMTP id u18-20020a170906125200b007ad8f7617c7mr241002eja.315.1667541129535; Thu, 03 Nov 2022 22:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667541129; cv=none; d=google.com; s=arc-20160816; b=tbEc7zBI1jWY1rZMqdk9n9gRjlx+8I0NSUQDAW8LZ/sQGozJ87VL5mp6GupK7PWtHx j/J3PmUmIpLd23DrNN2UFP2aI6zxfPQviPXQpyu+mSBO7bm5YgI3eivIC5n5W+zr2JSr 1XVEp7WJbwV8tRe+kEx7dAxnmc0bklb5OWe6ieDaanutojhvOHDJdBjFu6Nb85Rdjo20 8wzmvZivNKddi/kH+B2zoNwj9s3eqnWUeLFg+EDiEwCVGoGEBy9nKbHnj6vZuHUzUZm6 0q08lUQRncZsPvnCbYlFLvd3LtZClKsvMZK0CEZJXfExoG95PQpQqUkq9T7QPx1JndUg Heag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=iaYjjqPOtJYI6z/6ICezKT8a8v5wbCspgI51zUD4D5g=; b=0fSWyGmxBe020YOsUsT3hfwA3LhwSiOTUUO9xR/0aXKOh5x8+x11Ban0+op7VrqFO7 TO9noffwvK2fjjScqTyqsl2+wwd96P81aUFFJ3/mAwPGKK0dXes58Uw2WclKyzCVkWtV 5z2PYXbg1iWVLbUovEOnMvzy4qbe8UAJxCIPPA0CcwlWKt7PcSRX2NCpx9m4rmgrpF+O DbVImqmO0pca3NaM69tqytvq8ZqGzpKEad2E8jKdWC1hWQ2mLZXPxG2k6nEuRuLke/Hc cms9WtzPGUuMBFTv9zDQB2O/bKCCeO57Ws7pR29rq/Ggn1ePDQKTGu+SIiauFEJ7tavA bwZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q18-20020a056402519200b00462bd784df2si4009452edd.542.2022.11.03.22.51.45; Thu, 03 Nov 2022 22:52:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231649AbiKDFui (ORCPT + 99 others); Fri, 4 Nov 2022 01:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231347AbiKDFsy (ORCPT ); Fri, 4 Nov 2022 01:48:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F66A27B30; Thu, 3 Nov 2022 22:48:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93F99620DF; Fri, 4 Nov 2022 05:48:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F669C43141; Fri, 4 Nov 2022 05:48:50 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oqpZs-0071Cy-3C; Fri, 04 Nov 2022 01:49:16 -0400 Message-ID: <20221104054916.827422353@goodmis.org> User-Agent: quilt/0.66 Date: Fri, 04 Nov 2022 01:41:20 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , linux-ext4@vger.kernel.org Subject: [RFC][PATCH v3 27/33] timers: ext4: Use timer_shutdown_sync() before freeing timer References: <20221104054053.431922658@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748543607349521656?= X-GMAIL-MSGID: =?utf-8?q?1748543607349521656?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc :"Theodore Ts'o" Cc :Andreas Dilger Cc: linux-ext4@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 7950904fbf04..f54ed936d800 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1225,7 +1225,7 @@ static void ext4_put_super(struct super_block *sb) } ext4_es_unregister_shrinker(sbi); - del_timer_sync(&sbi->s_err_report); + timer_shutdown_sync(&sbi->s_err_report); ext4_release_system_zone(sb); ext4_mb_release(sb); ext4_ext_release(sb);