From patchwork Fri Nov 4 05:40:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 15340 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp190241wru; Thu, 3 Nov 2022 22:49:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7jsGGGzDamwmyJSAdK/hpxVBqvgU2wYEVQN+9aXuavVi1YFbvAudoxpY44/JTnCHag4bEo X-Received: by 2002:a17:907:75cc:b0:7ad:b9b7:582b with SMTP id jl12-20020a17090775cc00b007adb9b7582bmr29810435ejc.150.1667540961403; Thu, 03 Nov 2022 22:49:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667540961; cv=none; d=google.com; s=arc-20160816; b=JtChp4IjPM1f9tS83atMMHn7ufpzHudYtnYiVVmA9w5TS6RKTeXGUuT8GFco6iX24s My8rjcRBcz2qqA4SJF3mxdkx8FWXqw3bGZcnBVE+C9V+1/skJHfIJBN2FaJ2fZekLSMt ELiYck+Pv+YDCiWimmL2Hrpmmen/ak3tGfOEgo0ykfNCBbFcHHkj3UsnXNjWj8A2dKLx umVoyOb0XSYrLD5F/8YY4PqlDdnO72QpLRW1dDIWv+m8crXlVqUldt3KDBGVduzlI3hx wGvFCr4FUuJi+NrgmhOeTAc5im9I1FakVh4EwKXVYK+DGXAKT8yyHnO8cDHh4+2f5Mea XlKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=9xDb1QSYwFLsPXeaWgCIXwyS/owh5fuZlYingDK/6zk=; b=fWLziKvth/eGRofdzPhwFxHbwPok3rAcOqfoSdQof307yX2xe79LbhwoxbY8lTRVog KjaYs1qk/WpZLZZWDN/cqWZ2SOHMgQmaTBYjrncmN0w8idmv16eM1GhTwP1skU4Oa10b q1yst97jeWvjGPvpiUSkj2rS66ZWHW//PZCtbf9xW2A9AvtTlHl/y1HL15aAWdrNRRMP r4aCuzhkWJ1EyCp3ZnCO/SqA9jVEkZ8AmLiokX5k8dCe16gik1g6iUbkttjGLXsGC/3K EyHOqpusHSz0LER673Zr67/6FzGHAQ6OG4xfg5TLRyMTSlLSj7uUlV2r2vF31iKWPO7I lPZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go44-20020a1709070dac00b007830f14fffesi4824924ejc.375.2022.11.03.22.48.58; Thu, 03 Nov 2022 22:49:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbiKDFsx (ORCPT + 99 others); Fri, 4 Nov 2022 01:48:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbiKDFst (ORCPT ); Fri, 4 Nov 2022 01:48:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C81F28E03; Thu, 3 Nov 2022 22:48:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83B4C620B6; Fri, 4 Nov 2022 05:48:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4B57C433D7; Fri, 4 Nov 2022 05:48:45 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oqpZo-0070yv-1J; Fri, 04 Nov 2022 01:49:12 -0400 Message-ID: <20221104054912.243707160@goodmis.org> User-Agent: quilt/0.66 Date: Fri, 04 Nov 2022 01:40:55 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: [RFC][PATCH v3 02/33] timers: s390/cmm: Use timer_shutdown_sync() before freeing timer References: <20221104054053.431922658@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748543431389040567?= X-GMAIL-MSGID: =?utf-8?q?1748543431389040567?= From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: linux-s390@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- arch/s390/mm/cmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index 9141ed4c52e9..1a0a8aa43ac6 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -419,7 +419,7 @@ static int __init cmm_init(void) #endif unregister_sysctl_table(cmm_sysctl_header); out_sysctl: - del_timer_sync(&cmm_timer); + timer_shutdown_sync(&cmm_timer); return rc; } module_init(cmm_init); @@ -432,7 +432,7 @@ static void __exit cmm_exit(void) #endif unregister_oom_notifier(&cmm_oom_nb); kthread_stop(cmm_thread_ptr); - del_timer_sync(&cmm_timer); + timer_shutdown_sync(&cmm_timer); cmm_free_pages(cmm_pages, &cmm_pages, &cmm_page_list); cmm_free_pages(cmm_timed_pages, &cmm_timed_pages, &cmm_timed_page_list); }