From patchwork Fri Nov 4 02:39:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 15286 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp119787wru; Thu, 3 Nov 2022 19:23:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4jpUgWLhMv4dZ486s6EsjZvgymuqEGbINJC7V4YyNaAegaw8g+73nk/Biq3N8HWde+W/8E X-Received: by 2002:a17:906:285a:b0:7ae:127a:cc2e with SMTP id s26-20020a170906285a00b007ae127acc2emr7331756ejc.229.1667528604060; Thu, 03 Nov 2022 19:23:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667528604; cv=none; d=google.com; s=arc-20160816; b=Tm5bY1qfi68JQJV+ZPkkpXqyZ9QJPyLq/V++wRcWh04ycHKq+OuPBGZXVPiP4N8usM mrujjeOxChWJo82ZBhIqs6vVxxeeh3ynFPF197mLblgV0fqerCycql8NF6XFUfS4jWRk y/nPOUPt9Pa8o4p8K9q/pHGj3fUE4zP8fyljVFQFoqVGMoIHyffUIqX1xw91EUGt6BxF UNQOxtlpDKBScjwaFAe2CqWirwMKevmnM8/Timn/ljQlmwUZ8+ygJosqYeHn07bsjDTe LMUiULZ9yGelOJiBBv8JttHpKFf/7qPvCrpn6h8nA8LTI6XdLzPd7P4tnMxU0OUiA0xG o8WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6Slk+Pkdg32wEAbwd1WHNkPgxOYKthT4xIRt4ZngIbY=; b=L6WHAhq1Nreukp6an0P5mjTu4DLM38GG6nGZ+r2U/102z1WD9qQIE8kqDU3GlIZMWs Tpa/iOXtPCP26usHIJpZxufhcJA8MqSJwayvbUGN8WL70wZvBPCU6Q8Di6VFEx/LFuV1 wtDRWRfUox/MmqmYHMS+9vB9jNgyYiXGXIke55R7Vm7QDSL5OP+abd+U2Rq7iZFeOtcy 62q24+r5O8ZNYRL4QKkJdvhhrStDiES6pTJkNOOzFHitI5VK1BmAVAirMTvyiUi3jE0v HjMiyODx79jzfUZVYdMcDWU7i46NoVKPbVAt0xS3ijrHu+PLrZ0Oi96NfyhZ/ab1X87A LuhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id em6-20020a056402364600b00461e322ec5dsi3371122edb.294.2022.11.03.19.23.00; Thu, 03 Nov 2022 19:23:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231387AbiKDCSN (ORCPT + 99 others); Thu, 3 Nov 2022 22:18:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230383AbiKDCSB (ORCPT ); Thu, 3 Nov 2022 22:18:01 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5880C38BB; Thu, 3 Nov 2022 19:18:00 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4N3PNy1GD9zlBh0; Fri, 4 Nov 2022 10:15:46 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP2 (Coremail) with SMTP id Syh0CgB3D9RTdmRjDShNBQ--.16192S7; Fri, 04 Nov 2022 10:17:58 +0800 (CST) From: Yu Kuai To: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: [PATCH v2 3/5] blk-iocost: don't allow to configure bio based device Date: Fri, 4 Nov 2022 10:39:36 +0800 Message-Id: <20221104023938.2346986-4-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221104023938.2346986-1-yukuai1@huaweicloud.com> References: <20221104023938.2346986-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgB3D9RTdmRjDShNBQ--.16192S7 X-Coremail-Antispam: 1UD129KBjvdXoWrKryxur13Zr1rCr4rJFWxXrb_yoWkJFg_Aa 4fW34qgFn5Gay8WF1jyF90qrZ3Gw4rXFWjvrW7JasxJF1DXas8tan3Xr18JF45uayj9a45 Ca97Cwn8Ars7WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY02 0Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM2 8EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AI xVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2IY04 v7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbJ73DUUUUU= = X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748530473352795621?= X-GMAIL-MSGID: =?utf-8?q?1748530473352795621?= From: Yu Kuai iocost is based on rq_qos, which can only work for request based device, thus it doesn't make sense to configure iocost for bio based device. Signed-off-by: Yu Kuai Reviewed-by: Christoph Hellwig --- block/blk-iocost.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index c532129a1456..2bfecc511dd9 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -3181,6 +3181,11 @@ static ssize_t ioc_qos_write(struct kernfs_open_file *of, char *input, return PTR_ERR(bdev); disk = bdev->bd_disk; + if (!queue_is_mq(disk->queue)) { + ret = -EPERM; + goto out; + } + ioc = q_to_ioc(disk->queue); if (!ioc) { ret = blk_iocost_init(disk); @@ -3364,6 +3369,11 @@ static ssize_t ioc_cost_model_write(struct kernfs_open_file *of, char *input, return PTR_ERR(bdev); q = bdev_get_queue(bdev); + if (!queue_is_mq(q)) { + ret = -EPERM; + goto out; + } + ioc = q_to_ioc(q); if (!ioc) { ret = blk_iocost_init(bdev->bd_disk);