Message ID | 20221104021334.618189-1-yangyingliang@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp118767wru; Thu, 3 Nov 2022 19:20:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4W06b2gva9dHpIRGR8Lrx+VjLV0/q4ml4qKuWQHwPsDlM1EU3PkLcRv3FJFAAAVuXgOxrO X-Received: by 2002:a05:6402:1c88:b0:461:94a0:33df with SMTP id cy8-20020a0564021c8800b0046194a033dfmr33262938edb.0.1667528442268; Thu, 03 Nov 2022 19:20:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667528442; cv=none; d=google.com; s=arc-20160816; b=qpp6lpbvhtKwgt1q9RNL0ZEczkbAnT0tLUwprH65vsTH8GZWtLpfgxIFvD8l2jpow4 3Not1JGJvxChDOHj/OwYxVWIF/DGJG+4RZBpPryL1OvoRnst9eTjNiJYr5qvqpCa8nvd Xg8Rcp3TU43wBXcFctuJY9lY8VuEb1zkanalKi37UhqYr1hZ2DhxiXvmNGtLvuK+1Rvx PZbNuJG/zGKamNRKrhkqG1nJYxMcWiCLQDERLXrcxQIT2QBjoTbQa943DpbNV054HEjL audKDlcS17ycs3VmOFGM5SZm2K+AX8wtNascYJRd7XY9dfC8KqvuHaWBzr0VJ7974/4r opDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gmGeeCEkfGomiskdgyp5eWdBeyueWskBePGP7FujgwQ=; b=nV58ksZRrwyIvp0mAUXEgnx5zIl7GKB/6Cz5B90mXRolyMA853BXhIraBGlkBRm/+H VBYQ1QaeNfV+g/B6CuDMLg2BkJluaXoy/QeGk0uf+wAmhQq9Dk+CAKriakxRjMXb+9FZ ia2ESsNmndZt/MhX6mO5ewbWVkhoSosR2N58d2oCDJkrQzUO3FsbDHR5FYhDVMz/pL4X RNaFa/8hQ53qUHknt6SYD3jid1ddczqnI0gJjVn3aiPxilNA2f+OxG/pdCQxQqf2+wPz b+lyiE1EFURtQCjDYld+9bwwgn0A9q/88gB8GuGT6qPtZDghdHPxwTRbfR5/a3Psf2w7 ayjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk17-20020a1709077f9100b007add6c865d8si3366437ejc.684.2022.11.03.19.20.19; Thu, 03 Nov 2022 19:20:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbiKDCPS (ORCPT <rfc822;jimliu8233@gmail.com> + 99 others); Thu, 3 Nov 2022 22:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbiKDCPP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 3 Nov 2022 22:15:15 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5340212C for <linux-kernel@vger.kernel.org>; Thu, 3 Nov 2022 19:15:15 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N3PNC3lB9zmVbw for <linux-kernel@vger.kernel.org>; Fri, 4 Nov 2022 10:15:07 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 10:15:13 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 10:15:13 +0800 From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org> CC: <t.scherer@eckelmann.de>, <u.kleine-koenig@pengutronix.de>, <kernel@pengutronix.de> Subject: [PATCH] siox: fix possible memory leak in siox_device_add() Date: Fri, 4 Nov 2022 10:13:34 +0800 Message-ID: <20221104021334.618189-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748530303823811157?= X-GMAIL-MSGID: =?utf-8?q?1748530303823811157?= |
Series |
siox: fix possible memory leak in siox_device_add()
|
|
Commit Message
Yang Yingliang
Nov. 4, 2022, 2:13 a.m. UTC
If device_register() returns error in siox_device_add(),
the name allocated by dev_set_name() need be freed. As
comment of device_register() says, it should use put_device()
to give up the reference in the error path. So fix this
by calling put_device(), then the name can be freed in
kobject_cleanup(), and sdevice is freed in siox_device_release(),
set it to null in error path.
Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/siox/siox-core.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hello, On Fri, Nov 04, 2022 at 10:13:34AM +0800, Yang Yingliang wrote: > If device_register() returns error in siox_device_add(), > the name allocated by dev_set_name() need be freed. As > comment of device_register() says, it should use put_device() > to give up the reference in the error path. So fix this > by calling put_device(), then the name can be freed in > kobject_cleanup(), and sdevice is freed in siox_device_release(), > set it to null in error path. > > Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/siox/siox-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c > index 7c4f32d76966..561408583b2b 100644 > --- a/drivers/siox/siox-core.c > +++ b/drivers/siox/siox-core.c > @@ -839,6 +839,8 @@ static struct siox_device *siox_device_add(struct siox_master *smaster, > > err_device_register: > /* don't care to make the buffer smaller again */ > + put_device(&sdevice->dev); > + sdevice = NULL; The problem is real and the fix works as intended. I don't like the necessity to set sdevice to NULL, but that's the easiest approach here, so: Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > err_buf_alloc: > siox_master_unlock(smaster); @gregkh: Could you pick up this patch please[1]? While I don't consider it very urgent, it's technically a fix. I don't care much if it goes in now or during the next merge window. Best regards Uwe [1] the original Message-Id is 20221104021334.618189-1-yangyingliang@huawei.com. Maybe this helps you to apply the patch even if you didn't get a Cc.
diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c index 7c4f32d76966..561408583b2b 100644 --- a/drivers/siox/siox-core.c +++ b/drivers/siox/siox-core.c @@ -839,6 +839,8 @@ static struct siox_device *siox_device_add(struct siox_master *smaster, err_device_register: /* don't care to make the buffer smaller again */ + put_device(&sdevice->dev); + sdevice = NULL; err_buf_alloc: siox_master_unlock(smaster);