diff mbox series

[2/2] arm64: dts: qcom: ipq6018: improve pcie phy pcs reg table

Message ID 20221103212125.17156-2-ansuelsmth@gmail.com
State New
Headers
Series [1/2] phy: qcom-qmp-pcie: split pcs_misc init cfg for ipq8074 pcs table |

Commit Message

Christian Marangi Nov. 3, 2022, 9:21 p.m. UTC 
  This is not a fix on its own but more a cleanup. Phy qmp pcie driver
currently have a workaround to handle pcs_misc not declared and add
0x400 offset to the pcs reg if pcs_misc is not declared.

Correctly declare pcs_misc reg and reduce PCS size to the common value
of 0x1f0 as done for every other qmp based pcie phy device.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Vinod Koul Nov. 10, 2022, 7:08 a.m. UTC | #1 
On 03-11-22, 22:21, Christian Marangi wrote:
> This is not a fix on its own but more a cleanup. Phy qmp pcie driver
> currently have a workaround to handle pcs_misc not declared and add
> 0x400 offset to the pcs reg if pcs_misc is not declared.
> 
> Correctly declare pcs_misc reg and reduce PCS size to the common value
> of 0x1f0 as done for every other qmp based pcie phy device.

Reviewed-by: Vinod Koul <vkoul@kernel.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 9ebb9e2371b1..95d7f49bc61a 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -406,7 +406,8 @@  pcie_phy: phy@84000 {
 			pcie_phy0: phy@84200 {
 				reg = <0x0 0x84200 0x0 0x16c>, /* Serdes Tx */
 				      <0x0 0x84400 0x0 0x200>, /* Serdes Rx */
-				      <0x0 0x84800 0x0 0x4f4>; /* PCS: Lane0, COM, PCIE */
+				      <0x0 0x84800 0x0 0x1f0>; /* PCS: Lane0, COM, PCIE */
+				      <0x0 0x84c00 0x0 0xf4>; /* pcs_misc */
 				#phy-cells = <0>;
 
 				clocks = <&gcc GCC_PCIE0_PIPE_CLK>;