diff mbox series

[v1,5/7] ARM: dts: hpe: Add UDC nodes

Message ID 20221103160625.15574-6-richard.yu@hpe.com
State New
Headers
Series Add USB Driver for HPE GXP Architecture |

Commit Message

Yu, Richard Nov. 3, 2022, 4:06 p.m. UTC 
  From: Richard Yu <richard.yu@hpe.com>

Add support for the USB drivers on HPE GXP SoC.

Signed-off-by: Richard Yu <richard.yu@hpe.com>
---
 arch/arm/boot/dts/hpe-gxp.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Krzysztof Kozlowski Nov. 8, 2022, 11:28 a.m. UTC | #1 
On 03/11/2022 17:06, richard.yu@hpe.com wrote:
> From: Richard Yu <richard.yu@hpe.com>
> 
> Add support for the USB drivers on HPE GXP SoC.
> 
> Signed-off-by: Richard Yu <richard.yu@hpe.com>
> ---
>  arch/arm/boot/dts/hpe-gxp.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..60f2d3b15d90 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -59,6 +59,36 @@
>  			ranges = <0x0 0xc0000000 0x30000000>;
>  			dma-ranges;
>  
> +			vuhc0: vuhc@80400000 {
> +				compatible = "hpe,gxp-vuhc", "syscon";
> +				reg = <0x80400000 0x80>;
> +			};
> +
> +			udc_system_controller: system-controller@80400800 {
> +				compatible = "hpe,gxp-udcg", "syscon";
> +				reg = <0x80400800 0x200>;
> +			};
> +
> +			gadget0: udc@80401000 {
> +				compatible = "hpe,gxp-udc";
> +				reg = <0x80401000 0x1000>;
> +				interrupts = <13>;
> +				interrupt-parent = <&vic1>;
> +				vdevnum = <0>;
> +				fepnum = <7>;
> +				hpe,syscon-phandle = <&udc_system_controller>;
> +			};
> +
> +			gadget1: udc@80402000 {
> +				compatible = "hpe,gxp-udc";
> +				reg = <0x80402000 0x1000>;
> +				interrupts = <13>;
> +				interrupt-parent = <&vic1>;
> +				vdevnum = <1>;
> +				fepnum = <7>;
> +				hpe,syscon-phandle = <&udc_system_controller>;

Based on your bindings explanation, UDC should be rather the device
with multiple children representing actual devices.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi
index cf735b3c4f35..60f2d3b15d90 100644
--- a/arch/arm/boot/dts/hpe-gxp.dtsi
+++ b/arch/arm/boot/dts/hpe-gxp.dtsi
@@ -59,6 +59,36 @@ 
 			ranges = <0x0 0xc0000000 0x30000000>;
 			dma-ranges;
 
+			vuhc0: vuhc@80400000 {
+				compatible = "hpe,gxp-vuhc", "syscon";
+				reg = <0x80400000 0x80>;
+			};
+
+			udc_system_controller: system-controller@80400800 {
+				compatible = "hpe,gxp-udcg", "syscon";
+				reg = <0x80400800 0x200>;
+			};
+
+			gadget0: udc@80401000 {
+				compatible = "hpe,gxp-udc";
+				reg = <0x80401000 0x1000>;
+				interrupts = <13>;
+				interrupt-parent = <&vic1>;
+				vdevnum = <0>;
+				fepnum = <7>;
+				hpe,syscon-phandle = <&udc_system_controller>;
+			};
+
+			gadget1: udc@80402000 {
+				compatible = "hpe,gxp-udc";
+				reg = <0x80402000 0x1000>;
+				interrupts = <13>;
+				interrupt-parent = <&vic1>;
+				vdevnum = <1>;
+				fepnum = <7>;
+				hpe,syscon-phandle = <&udc_system_controller>;
+			};
+
 			vic0: interrupt-controller@eff0000 {
 				compatible = "arm,pl192-vic";
 				reg = <0xeff0000 0x1000>;