From patchwork Thu Nov 3 08:08:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramona Bolboaca X-Patchwork-Id: 14751 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp386655wru; Thu, 3 Nov 2022 01:15:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM46G6Sjg8WB1genZAH4w5UhwT9cwQJjOBXMgrPP38YVb6uZY6YneJ9df1o2HETmTm3DeBef X-Received: by 2002:a17:906:cc0f:b0:7a0:b91c:855f with SMTP id ml15-20020a170906cc0f00b007a0b91c855fmr28703904ejb.26.1667463322884; Thu, 03 Nov 2022 01:15:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667463322; cv=none; d=google.com; s=arc-20160816; b=0CLTobn7BmbPRlVEdeinrZ9rK7yLXhog7l0ZVEi2gFA2u0Smm2Xph/A9Z1MGb8NtBK GyGrFS9UQn147OHYf3ThUgfORcBnElDC+ldi9mIRkkjO8rcLuoeLn1tluHJawCRXeCdW zI2TKMt/wgKK706R42fe3WjQ/Dbx+6xMhov+FLZ7unlqAKboOuJ5zZgYJeQaCw1ZusVr jlGyGVJf6+jX7AMslf6vPHtheSjVomQkD4rGic4zV7u5hRh0SoAkWoPNHqIQ+Jbd6jVn Avkpr2HSkDNmi5QLVwo9xjzDEWLlEMBmjzR00w3mHHDnEaJ7F9ylKO7vSKMFM/Nrivfg 1lCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AlSa9vnc1NXJ3NgyyZzX7+d2bWc5pSOJyAqK/FOY2/E=; b=aG2WfGcPnTKnjJWaDxd2M28QCz0hBniQrLYFMdpALrL4MIjKaMM1RHHvkrZ/QvHhM1 42IITdDrJkq4Z735sgs+2BkW23jSoDG+rdL+/LJfn+7qxwOSk6ReYhffyX/OhxJTwgkc 7KsJk14Rr9TmFkZd/8XaiToTsOeiUgRVR/v8xY6ZbqjGzetIzAehVTXKSarHxtVZ9F8s jh+7orKiWTSie2x2lAyC1TadbfbQndL0gFq3zT6bgC3R0G+ohmN7BAKU88inVHaMgBW9 UcZserSSvQ6N9DBlW+PE2ZarRjvL6VxKeOcS0TFoPQh3RmO6q9aORBojiZHWx80I9Ul3 dp2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs39-20020a1709072d2700b007adcf0dd301si501751ejc.747.2022.11.03.01.14.59; Thu, 03 Nov 2022 01:15:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231570AbiKCIJh (ORCPT + 99 others); Thu, 3 Nov 2022 04:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231337AbiKCIJO (ORCPT ); Thu, 3 Nov 2022 04:09:14 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74E46DD4; Thu, 3 Nov 2022 01:09:13 -0700 (PDT) Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A37Bpat019450; Thu, 3 Nov 2022 04:09:11 -0400 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3kkxe9keqk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 04:09:11 -0400 Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 2A389AWi004139 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Nov 2022 04:09:10 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Thu, 3 Nov 2022 04:09:09 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Thu, 3 Nov 2022 04:09:09 -0400 Received: from rbolboac.ad.analog.com ([10.48.65.139]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 2A388q0P009844; Thu, 3 Nov 2022 04:09:04 -0400 From: Ramona Bolboaca To: , , CC: Ramona Bolboaca Subject: [PATCH v2 7/8] staging: iio: accel: adis16240: Fix deadlock in probe Date: Thu, 3 Nov 2022 10:08:46 +0200 Message-ID: <20221103080847.162509-8-ramona.bolboaca@analog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221103080847.162509-1-ramona.bolboaca@analog.com> References: <20221103080847.162509-1-ramona.bolboaca@analog.com> MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: VQlMVAWjjUhLR6sl3Jds3UMFkmXGp00Y X-Proofpoint-ORIG-GUID: VQlMVAWjjUhLR6sl3Jds3UMFkmXGp00Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_15,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211030057 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748462021226765125?= X-GMAIL-MSGID: =?utf-8?q?1748462021226765125?= Use '__adis_initial_startup()' instead of 'adis_initial_startup()' to avoid deadlock. When using 'adis_initial_startup()' 'mutex_lock()' is called twice, without releasing it (once inside 'adis_initial_startup()' and once inside 'adis_enable_irq()'). Fixes: b600bd7eb3335 ("iio: adis: do not disabe IRQs in 'adis_init()'") Signed-off-by: Ramona Bolboaca --- changes in v2: - changed commit in 'Fixes' tag to the correct commit - added commas and brackets for functions in commit message drivers/staging/iio/accel/adis16240.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c index bca857eef92e..337492785f04 100644 --- a/drivers/staging/iio/accel/adis16240.c +++ b/drivers/staging/iio/accel/adis16240.c @@ -414,7 +414,7 @@ static int adis16240_probe(struct spi_device *spi) return ret; /* Get the device into a sane initial state */ - ret = adis_initial_startup(st); + ret = __adis_initial_startup(st); if (ret) return ret;