From patchwork Thu Nov 3 08:08:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramona Bolboaca X-Patchwork-Id: 14746 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp385748wru; Thu, 3 Nov 2022 01:12:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM681ULSEtidJ6BwDRzglPIiy+jCa8BI40zGKYbQFHTBJYngR7zCbJN441AuqgGlLwUuhpAg X-Received: by 2002:aa7:c78d:0:b0:454:fe1d:8eb1 with SMTP id n13-20020aa7c78d000000b00454fe1d8eb1mr28269212eds.59.1667463164154; Thu, 03 Nov 2022 01:12:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667463164; cv=none; d=google.com; s=arc-20160816; b=WPLnO/cnJ7Di+rKvJYrKVgaJuC4fLHZHeYdTpXmon5cmhBtAzN9P9NC4vMI8SqK094 eAsK1R+0HDUsbQypMqEW60fmMHnuu+YHE4bxqQTgWme9ayoXdSYEZxOS3jfYNY/MhSKo OnTBdU2n6cRVUMlbRJcO2L4bVcWmRBw9rOHFZ06qh1TBoBhNDFbrRwMtn1JHWZLiKUSF z36xJQ6zXxS7DSGIWAUOySBmxBPrnKKs+eECCEoc0kGtxKPzaq8dePZN5IqV6fzaFOZQ viBfk6J9JF9Ot+FXO4wFp34kfo6oJNrPgOIkcSlx/W/PrCtV4pGCsT9gAgHS2KlpirCX sRbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=i/WeLL2zGXLXsDv/TnX9gumc/HBqUts/nuOQ8vMXfdU=; b=L9uuSyQk/re1qETcTupD4rQZ8f5EWCnU1XuiHVJUSrSbIDplxuWZn06GbADhnb5jHS Sqv91eNLtODzZBgxwzY8yyJLhwJz4NzITCWJJyyWMrpVUO7y9MsEJPlOunJP1dUn7LtN ob3DvxbRkWWPcU/8vayZd2d1gd1IKYH9Z9QNpWvT7NgHpQE7xD3GnHjFgh8X00XyD7Pq GW8cBE9O30+vRZqQRVs3Wo8VSQzVrZ7C95faG/W7YmqSMerKSzOEfWvJTeinXagJ4oMz ld0w6xmbeabKBRrmV052rqzrkAvgB2ig6M6mPl4Ay2yWANqeBQMbPcMf9+fmyCNanwLW oWfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rp28-20020a170906d97c00b0078dbd939dacsi377745ejb.545.2022.11.03.01.12.20; Thu, 03 Nov 2022 01:12:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbiKCIJS (ORCPT + 99 others); Thu, 3 Nov 2022 04:09:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbiKCIJJ (ORCPT ); Thu, 3 Nov 2022 04:09:09 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C14F79; Thu, 3 Nov 2022 01:09:09 -0700 (PDT) Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A37Di7r019472; Thu, 3 Nov 2022 04:09:07 -0400 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3kkxe9kepw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 04:09:07 -0400 Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 2A3895PA004121 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Nov 2022 04:09:05 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Thu, 3 Nov 2022 04:09:04 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Thu, 3 Nov 2022 04:09:04 -0400 Received: from rbolboac.ad.analog.com ([10.48.65.139]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 2A388q0M009844; Thu, 3 Nov 2022 04:09:01 -0400 From: Ramona Bolboaca To: , , CC: Ramona Bolboaca Subject: [PATCH v2 4/8] iio: gyro: adis16260: Fix deadlock in probe Date: Thu, 3 Nov 2022 10:08:43 +0200 Message-ID: <20221103080847.162509-5-ramona.bolboaca@analog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221103080847.162509-1-ramona.bolboaca@analog.com> References: <20221103080847.162509-1-ramona.bolboaca@analog.com> MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: y8d-dhxxcIrSmzInMK8Ophnl0ur1E2JY X-Proofpoint-ORIG-GUID: y8d-dhxxcIrSmzInMK8Ophnl0ur1E2JY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_15,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211030057 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748461854769890005?= X-GMAIL-MSGID: =?utf-8?q?1748461854769890005?= Use '__adis_initial_startup()' instead of 'adis_initial_startup()' to avoid deadlock. When using 'adis_initial_startup()' 'mutex_lock()' is called twice, without releasing it (once inside 'adis_initial_startup()' and once inside 'adis_enable_irq()'). Fixes: b600bd7eb3335 ("iio: adis: do not disabe IRQs in 'adis_init()'") Signed-off-by: Ramona Bolboaca --- changes in v2: - changed commit in 'Fixes' tag to the correct commit - added commas and brackets for functions in commit message drivers/iio/gyro/adis16260.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/adis16260.c b/drivers/iio/gyro/adis16260.c index eaf57bd339ed..112d635b7dfd 100644 --- a/drivers/iio/gyro/adis16260.c +++ b/drivers/iio/gyro/adis16260.c @@ -395,7 +395,7 @@ static int adis16260_probe(struct spi_device *spi) return ret; /* Get the device into a sane initial state */ - ret = adis_initial_startup(&adis16260->adis); + ret = __adis_initial_startup(&adis16260->adis); if (ret) return ret;