From patchwork Thu Nov 3 08:08:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramona Bolboaca X-Patchwork-Id: 14747 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp385827wru; Thu, 3 Nov 2022 01:12:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM78QTzQxWtQZ5SjW5ij+bYQ0BSDV8cke/OHZRphIRJMtF81tZ0KrefUbku088jgJ7gCOp8D X-Received: by 2002:a17:907:6296:b0:787:d066:9fcf with SMTP id nd22-20020a170907629600b00787d0669fcfmr26003358ejc.692.1667463175621; Thu, 03 Nov 2022 01:12:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667463175; cv=none; d=google.com; s=arc-20160816; b=Uj7k9LbMW1fSq5TG2ice0B+R7kWcb9Wgot1Rki6CT/gn4+wFpPMKdHYb1gjwxceJC/ h03lBiCz2apfU5Xp51pUrlL/9gnA7OTwpN7/EuUu5qYSFMvYPwMsxBdV952qszn8yeoN wH9gc+EdUKm8vCpjnvkwLW2ES7KxHETIji5Gc/bKadNziqToFipwyFi+jRWMijC5leWX HJJpR/qk8JreP8mjfNi/VijvfcaegHAjU1Kxvi1wFpG97coEOZW+3e2IqmPPLGT+L2z7 cVEfWXtr1CwB3LLKZd6T7VVaujNiCqMr844kMWt2khCYBc5hOyGreJy1N0KcwtJrNclc FYcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=s24EWfTFBLf2xOAUs6USOAakN2p/4hxQq05Rt8caSh0=; b=Qi+97f4/luIakTzr/Jq4VlX2pvzaDOzS1YKFSL3kE5phqJGx5uIb8aPRYGrfNWHUvg LJcggVAqaSuDM2dmdcsONcrshPqacvpTIfcrCZPFswZng9JUsEyt6zOPAQM26drzNvZG YI95584TwGMQLuFO8QL67YGjmXUgpwUakR2/ymzmTnsluBkN3WhZtFveCAqZiwXN9nZl xKfVpt0bFWE7BMhD+DSKRScfI6Use49wWcRJxTpL47H3KMvkF1jFDbDMU+U3Li/CT6Ip va4VPWZ/sI+WyTrimIAjHGyCsbrz38FwcmGrzgCFwm/txzV3YXyaSQ1vHklNE0xGPNs5 wfxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz12-20020a1709077d8c00b0078e28a52d58si431247ejc.874.2022.11.03.01.12.32; Thu, 03 Nov 2022 01:12:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbiKCIJV (ORCPT + 99 others); Thu, 3 Nov 2022 04:09:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbiKCIJJ (ORCPT ); Thu, 3 Nov 2022 04:09:09 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4012FC66; Thu, 3 Nov 2022 01:09:09 -0700 (PDT) Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A37Bpaq019450; Thu, 3 Nov 2022 04:09:07 -0400 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3kkxe9kepx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 04:09:07 -0400 Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 2A3895Fj004120 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Nov 2022 04:09:05 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Thu, 3 Nov 2022 04:09:04 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Thu, 3 Nov 2022 04:09:04 -0400 Received: from rbolboac.ad.analog.com ([10.48.65.139]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 2A388q0K009844; Thu, 3 Nov 2022 04:08:58 -0400 From: Ramona Bolboaca To: , , CC: Ramona Bolboaca Subject: [PATCH v2 2/8] iio: accel: adis16209: Fix deadlock in probe Date: Thu, 3 Nov 2022 10:08:41 +0200 Message-ID: <20221103080847.162509-3-ramona.bolboaca@analog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221103080847.162509-1-ramona.bolboaca@analog.com> References: <20221103080847.162509-1-ramona.bolboaca@analog.com> MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: 0E8h23Ws-SoddfDSvpoc3K4v7zpVzXDC X-Proofpoint-ORIG-GUID: 0E8h23Ws-SoddfDSvpoc3K4v7zpVzXDC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_15,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211030057 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748461866753934529?= X-GMAIL-MSGID: =?utf-8?q?1748461866753934529?= Use '__adis_initial_startup()' instead of 'adis_initial_startup()' to avoid deadlock. When using 'adis_initial_startup()' 'mutex_lock()' is called twice, without releasing it (once inside 'adis_initial_startup()' and once inside 'adis_enable_irq()'). Fixes: b600bd7eb3335 ("iio: adis: do not disabe IRQs in 'adis_init()'") Signed-off-by: Ramona Bolboaca --- changes in v2: - changed commit in 'Fixes' tag to the correct commit - added commas and brackets for functions in commit message drivers/iio/accel/adis16209.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c index 5a9c6e2296f1..0035e4f4db63 100644 --- a/drivers/iio/accel/adis16209.c +++ b/drivers/iio/accel/adis16209.c @@ -291,7 +291,7 @@ static int adis16209_probe(struct spi_device *spi) if (ret) return ret; - ret = adis_initial_startup(st); + ret = __adis_initial_startup(st); if (ret) return ret;