From patchwork Thu Nov 3 06:14:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Sae X-Patchwork-Id: 14673 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp349776wru; Wed, 2 Nov 2022 23:26:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6UMtDCzGaKZgwC2CJFs91QfL0nH078OZ7p7CuvKOlWwWQSSPbB5A3xW/6BkRcrI22jutOI X-Received: by 2002:a05:6a00:1a47:b0:52e:6a8c:5430 with SMTP id h7-20020a056a001a4700b0052e6a8c5430mr28311065pfv.48.1667456808007; Wed, 02 Nov 2022 23:26:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667456808; cv=none; d=google.com; s=arc-20160816; b=lrBTy4zJ6jnxip8FBsH3WQ4g0dEYgjEnxTtcaMuHw/1zZAuxamilwAokP2No0LPGx4 E/r6kRqeMCuG0O5Wp/z6bNlasaGugPwOnf2IJ+5rYfizklS7O5Jmc1UDFr4lfiVTFGkO cq/qi2qxeLIFBc4yCSSXgYzhAHWQPxIO1sN+DdaH9urxKRFyyVvMiT68OYqFZnkATfH4 nsl8d2NuHRWeydY2HbTvdzvm5LBCxcQyKUrUbpUTua8od7zbWONSyl9nnF78xbPz637M LySjLHkd75p1sh4JEovv1oxExdRizUfSpbinMAIIWUhQelhfw6jJEYWZtG42nuLIHuoU xqzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=mrBxGf+uk/ZFonLK7bImL7AyXylEQPygYEr5zWaRcDs=; b=Yq2jJmzY9UUjksj+4Z2TbBnRJRv0O+vQVDHZG+d89+/Pbx/US56ZWo8OO2WMMQXJhF 0wnK17nHLzwcc0g1yRL6hPTBdgtfmBiohMgCuT+dllh+4+BZAgMYzBvFOeD/vUFcpsMO /42K80UAHhp+PU8wSRcx2s8/8MU1IVHC/nRXNagBLBKvDJgQygOJsNszKfz/jmGKEX2r lY7Ne3RuGO5L3RmBxmZkqeP2nJoqrIMlvByeV72wIroV/WtQXrjQME7Mxo0jQELk5PXC Ok4OxrAF3u01C0zI7AUCCxcQNAl4MSFLmS19xDQUif/EyybBi0PCw+0HbuJUTkFL+meU oCYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a056a000a0b00b0056bb75c96d6si20557563pfh.227.2022.11.02.23.26.34; Wed, 02 Nov 2022 23:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbiKCGOX (ORCPT + 99 others); Thu, 3 Nov 2022 02:14:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbiKCGOV (ORCPT ); Thu, 3 Nov 2022 02:14:21 -0400 Received: from out28-1.mail.aliyun.com (out28-1.mail.aliyun.com [115.124.28.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1474518E02; Wed, 2 Nov 2022 23:14:19 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.4085879|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.00945261-0.000483737-0.990064;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047203;MF=frank.sae@motor-comm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.Q-ERKeq_1667456039; Received: from sunhua.motor-comm.com(mailfrom:Frank.Sae@motor-comm.com fp:SMTPD_---.Q-ERKeq_1667456039) by smtp.aliyun-inc.com; Thu, 03 Nov 2022 14:14:15 +0800 From: Frank To: Peter Geis , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: yinghong.zhang@motor-comm.com, fei.zhang@motor-comm.com, hua.sun@motor-comm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frank , kernel test robot , Julia Lawall Subject: [PATCH net-next v1.2] net: phy: fix yt8521 duplicated argument to & or | Date: Thu, 3 Nov 2022 14:14:13 +0800 Message-Id: <20221103061413.1866-1-Frank.Sae@motor-comm.com> X-Mailer: git-send-email 2.31.0.windows.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748449535795041343?= X-GMAIL-MSGID: =?utf-8?q?1748455190343450703?= cocci warnings: (new ones prefixed by >>) >> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or | drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or | drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or | drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or | The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx. Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy") Reported-by: kernel test robot Reported-by: Julia Lawall Signed-off-by: Frank --- v1.2 -remove "[net-next,v8.2] " in Fixes tag v1.1 -change PATCH net to PATCH net-next -add warnings info drivers/net/phy/motorcomm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index c7593f224177..bd1ab5d0631f 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy_device *phydev) switch (phydev->interface) { case PHY_INTERFACE_MODE_RGMII: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_RXID: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_RGMII_TXID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_ID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_SGMII: