From patchwork Thu Nov 3 01:10:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dionna Amalie Glaze X-Patchwork-Id: 14576 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp246061wru; Wed, 2 Nov 2022 18:14:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7nUgM20Qq4W88CvscDheztKXsD65Cl2gcd3qdDl2N+vDD/XqzECvt9n9ya+BmezNHkiofY X-Received: by 2002:a05:6a00:140f:b0:56e:1190:e731 with SMTP id l15-20020a056a00140f00b0056e1190e731mr6062209pfu.39.1667438070905; Wed, 02 Nov 2022 18:14:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667438070; cv=none; d=google.com; s=arc-20160816; b=IMV2fqE0HWh5HDd68QYE3ZyScc8tN8xg8WCfsmyD+I4M+GsjXn0ArSelOWVhbHMo1G 0dJFtXBJfDdJYWSgIB5yDo6M66ARaODfpQlKU8ZAo6tuHsuapnAIKTJdnUf7jod+rs5T DWapJvdh39LLtp6vSLwGRxX6JfkWrZ8dMa5mVOmoFKUkhK9lXCD36Z+ks6gQAP7XA+Uv tl97oeh19uglByjE85OBc9sQEWFG2xdKr+zmNWBapQ6ybCMSoHlh+QMKUwMGPgVHdkqy Z73rgZx0icP1zjlbEm7ufHvi8szfjvkWJRsp8zNmnVyhVsxoByRdWsVZFiaqYvkX/dC5 YhFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=kYKgV9ZKdPHZZFBhdSWAVOyv34GIciO94ig2I8LrdA4=; b=UmGKl8NNjkh8bSdhz+vA76DWewmbGYOYekglisJ/DihIsEgxIV5cqiWwBbBTXBWGJw kmmcfMqxxNHj7fTCJiPwsAPMFMkDzWd8h2kg8FAzDcIW4bapvgB6b+LeD4xTMRv3uJL+ qq/dbj7fNYWjricEe7hBDFBjcxMw9hLvCqxCXFzHH5kvTx6OMSKPKLe3Yx9eq5SqqVUt QZPnNGcQb1tEWn03c0hIzB88Yhn5NaFAsTbi6WUBrx7TvSx4++HB2o0sxHabohk44dJw 7S2pPgIHB4oIpclvZSBrWzpAnIAnLhh1NNGdQohxi7n4Cilkm0Oa5QoNEVMrltVKcJpc nWQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ZR0RSLAa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lx2-20020a17090b4b0200b00213b6c822acsi4848502pjb.167.2022.11.02.18.14.17; Wed, 02 Nov 2022 18:14:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ZR0RSLAa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbiKCBLK (ORCPT + 99 others); Wed, 2 Nov 2022 21:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbiKCBKw (ORCPT ); Wed, 2 Nov 2022 21:10:52 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA7411275C for ; Wed, 2 Nov 2022 18:10:51 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id r10-20020a17090a1bca00b002137a500398so155363pjr.5 for ; Wed, 02 Nov 2022 18:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=kYKgV9ZKdPHZZFBhdSWAVOyv34GIciO94ig2I8LrdA4=; b=ZR0RSLAayV722yrywG8UZrXnkFylDrfMVQ4McNTD7Q7gC9kmJxj3hvwxDXQgmYVVTG fmYIEaLPfGyJonImhII7Zh5wZ5m6bOPtwFbR97/hptQ5Os4QrLF4ypLuH/bUVlKg8tgX CJmwp9dJ7yqfLXGeCpxwuoUK4aNJE/MT75lTQU5rQci8JK0KbLB2DZZyfHDxRuDb473P 3Q4GxFoyacakJIZfnXmik1KmljKX1rVypYGajd00ZU7pPS8ZUnezR8dfDFd+SqK7puMA fZbPlJ7qdMLQoU9iEgy2sR5vjH/2MaHC9k5KXfOOK5GR7g0wrYDNhHIn3SuRNLBLHvmY HDBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kYKgV9ZKdPHZZFBhdSWAVOyv34GIciO94ig2I8LrdA4=; b=fm4bH588fzaX7iTpdSul9VtsrTLCOR8/NHSK6dhIAgRt7C1dtQVVX/iMwMqTkyqK0q P1GYnk43aUnwgZkKuOLrrL0Oul3o3S2GvEd0txTL5siAXgq9Wlo69y9d0bY0kuzO0TPF pMb+n01e6RoakwOkDpR25RKpoCoufOnkxlEaceOPnerPqPpMMAsshoXupHwoTI2fFGCB xs0dkhWD69p1zKZ/UAh3HeZVXytIVqExPamkflvYRW4LIzQ7nazuGdDY20t8HdYMWNcg /FmN9gk83qCIlOaZagtL2sg1Iewpdxwaw9G02HxLcSobheo3iXbrAZQmzCvVahEwLzrE C0ZA== X-Gm-Message-State: ACrzQf3q1x/Cy62G4dmLo+2ZOe7RDyrXqiZYzitBlj0uhtOtk6UnkhlA nHfWpJAZ+HMo6h9KjBstsf0vJ/8nf9vNr2QOJEk2Ma9UrFmVkt3TH8d6y4uCqa2kyy1ReX4D57N 4z8CESckQsNzNaS8kXqwc3VXadi34f8m8Vo26Okw2mWGQSFUT8SqFV0i/7Dy+uxVWgzkI2cJpxK P+VF4PAqY= X-Received: from dionnaglaze.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2ee6]) (user=dionnaglaze job=sendgmr) by 2002:a05:6a00:1394:b0:56d:2237:c1b0 with SMTP id t20-20020a056a00139400b0056d2237c1b0mr25343702pfg.5.1667437851396; Wed, 02 Nov 2022 18:10:51 -0700 (PDT) Date: Thu, 3 Nov 2022 01:10:38 +0000 In-Reply-To: <20221103011038.1542614-1-dionnaglaze@google.com> Mime-Version: 1.0 References: <20221103011038.1542614-1-dionnaglaze@google.com> X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog Message-ID: <20221103011038.1542614-5-dionnaglaze@google.com> Subject: [PATCH v6 4/4] virt: sev-guest: interpret VMM errors from guest request From: Dionna Glaze To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Dionna Glaze , Tom Lendacky , Peter Gonda , Borislav Petkov , Tom Lendacky , Liam Merwick , Yang Yingliang , Haowen Bai X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748435542796146680?= X-GMAIL-MSGID: =?utf-8?q?1748435542796146680?= The GHCB specification states that the upper 32 bits of exitinfo2 are for the VMM's error codes. The sev-guest ABI has already locked in that the fw_err status of the input will be 64 bits, and that BIT_ULL(32) means that the extended guest request's data buffer was too small, so we have to keep that ABI. We can still interpret the upper 32 bits of exitinfo2 for the user anyway in case the request gets throttled. For safety, since the encryption algorithm in GHCBv2 is AES_GCM, we cannot return to user space without having completed the request with the current sequence number. If we were to return and the guest were to make another request but with different message contents, then that would be IV reuse. When throttled, the driver will reschedule itself and then try again after sleeping half its ratelimit time to avoid a big wait queue. The ioctl may block indefinitely, but that has always been the case when deferring these requests to the host. Cc: Tom Lendacky Cc: Peter Gonda Cc: Borislav Petkov Cc: Tom Lendacky Cc: Liam Merwick Cc: Yang Yingliang Cc: Haowen Bai Signed-off-by: Dionna Glaze --- drivers/virt/coco/sev-guest/sev-guest.c | 50 ++++++++++++++++++++++--- include/uapi/linux/sev-guest.h | 18 ++++++++- 2 files changed, 60 insertions(+), 8 deletions(-) diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c index 0508c2f46f6b..43e110ad4aa9 100644 --- a/drivers/virt/coco/sev-guest/sev-guest.c +++ b/drivers/virt/coco/sev-guest/sev-guest.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -48,12 +49,22 @@ struct snp_guest_dev { struct snp_req_data input; u32 *os_area_msg_seqno; u8 *vmpck; + + struct ratelimit_state rs; }; static u32 vmpck_id; module_param(vmpck_id, uint, 0444); MODULE_PARM_DESC(vmpck_id, "The VMPCK ID to use when communicating with the PSP."); +static int rate_hz = 2; +module_param(rate_hz, int, 0444); +MODULE_PARM_DESC(vmpck_id, "The rate limit frequency to limit requests to."); + +static int rate_burst = 1; +module_param(rate_burst, int, 0444); +MODULE_PARM_DESC(rate_burst, "The rate limit burst amount to limit requests to."); + /* Mutex to serialize the shared buffer access and command handling. */ static DEFINE_MUTEX(snp_cmd_mutex); @@ -305,6 +316,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in u8 type, void *req_buf, size_t req_sz, void *resp_buf, u32 resp_sz, __u64 *exitinfo2) { + unsigned int vmm_err; u64 seqno; int rc; @@ -320,9 +332,33 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in if (rc) return rc; +retry: + /* + * Rate limit commands internally since the host can also throttle, and + * we don't want to create a tight request spin that could end up + * getting this VM throttled more heavily. + */ + if (!__ratelimit(&snp_dev->rs)) { + sleep_timeout_interruptible((rate_hz * HZ) / 2); + goto retry; + } /* Call firmware to process the request */ rc = snp_issue_guest_request(exit_code, &snp_dev->input, exitinfo2); + vmm_err = *exitinfo2 >> SNP_GUEST_VMM_ERR_SHIFT; + /* + * The host may return EBUSY if the request has been throttled. + * We retry in the driver to avoid returning and reusing the message + * sequence number on a different message. + */ + if (vmm_err == SNP_GUEST_VMM_ERR_BUSY) + goto retry; + + if (vmm_err && vmm_err != SNP_GUEST_VMM_ERR_INVALID_LEN) { + pr_err("sev-guest: host returned unknown error code: %d\n", + vmm_err); + return -EINVAL; + } if (rc) return rc; @@ -375,7 +411,7 @@ static int get_report(struct snp_guest_dev *snp_dev, struct snp_guest_request_io rc = handle_guest_request(snp_dev, SVM_VMGEXIT_GUEST_REQUEST, arg->msg_version, SNP_MSG_REPORT_REQ, &req, sizeof(req), resp->data, - resp_len, &arg->fw_err); + resp_len, &arg->exitinfo2); if (rc) goto e_free; @@ -415,7 +451,7 @@ static int get_derived_key(struct snp_guest_dev *snp_dev, struct snp_guest_reque rc = handle_guest_request(snp_dev, SVM_VMGEXIT_GUEST_REQUEST, arg->msg_version, SNP_MSG_KEY_REQ, &req, sizeof(req), buf, resp_len, - &arg->fw_err); + &arg->exitinfo2); if (rc) return rc; @@ -477,10 +513,10 @@ static int get_ext_report(struct snp_guest_dev *snp_dev, struct snp_guest_reques snp_dev->input.data_npages = npages; ret = handle_guest_request(snp_dev, SVM_VMGEXIT_EXT_GUEST_REQUEST, arg->msg_version, SNP_MSG_REPORT_REQ, &req.data, - sizeof(req.data), resp->data, resp_len, &arg->fw_err); + sizeof(req.data), resp->data, resp_len, &arg->exitinfo2); /* If certs length is invalid then copy the returned length */ - if (arg->fw_err == SNP_GUEST_REQ_INVALID_LEN) { + if (arg->vmm_error == SNP_GUEST_VMM_ERR_INVALID_LEN) { req.certs_len = snp_dev->input.data_npages << PAGE_SHIFT; if (copy_to_user((void __user *)arg->req_data, &req, sizeof(req))) @@ -515,7 +551,7 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned long if (copy_from_user(&input, argp, sizeof(input))) return -EFAULT; - input.fw_err = 0xff; + input.exitinfo2 = SEV_RET_NO_FW_CALL; /* Message version must be non-zero */ if (!input.msg_version) @@ -546,7 +582,7 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned long mutex_unlock(&snp_cmd_mutex); - if (input.fw_err && copy_to_user(argp, &input, sizeof(input))) + if (input.exitinfo2 && copy_to_user(argp, &input, sizeof(input))) return -EFAULT; return ret; @@ -696,6 +732,8 @@ static int __init sev_guest_probe(struct platform_device *pdev) if (ret) goto e_free_cert_data; + ratelimit_state_init(&snp_dev->rs, rate_hz * HZ, rate_burst); + dev_info(dev, "Initialized SEV guest driver (using vmpck_id %d)\n", vmpck_id); return 0; diff --git a/include/uapi/linux/sev-guest.h b/include/uapi/linux/sev-guest.h index 256aaeff7e65..8e4144aa78c9 100644 --- a/include/uapi/linux/sev-guest.h +++ b/include/uapi/linux/sev-guest.h @@ -52,8 +52,15 @@ struct snp_guest_request_ioctl { __u64 req_data; __u64 resp_data; - /* firmware error code on failure (see psp-sev.h) */ - __u64 fw_err; + /* bits[63:32]: VMM error code, bits[31:0] firmware error code (see psp-sev.h) */ + union { + __u64 exitinfo2; + __u64 fw_err; /* Name deprecated in favor of others */ + struct { + __u32 fw_error; + __u32 vmm_error; + }; + }; }; struct snp_ext_report_req { @@ -77,4 +84,11 @@ struct snp_ext_report_req { /* Get SNP extended report as defined in the GHCB specification version 2. */ #define SNP_GET_EXT_REPORT _IOWR(SNP_GUEST_REQ_IOC_TYPE, 0x2, struct snp_guest_request_ioctl) +/* Guest message request EXIT_INFO_2 constants */ +#define SNP_GUEST_FW_ERR_MASK GENMASK_ULL(31, 0) +#define SNP_GUEST_VMM_ERR_SHIFT 32 + +#define SNP_GUEST_VMM_ERR_INVALID_LEN 1 +#define SNP_GUEST_VMM_ERR_BUSY 2 + #endif /* __UAPI_LINUX_SEV_GUEST_H_ */