From patchwork Wed Nov 2 14:08:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhang.songyi@zte.com.cn X-Patchwork-Id: 14248 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3642275wru; Wed, 2 Nov 2022 07:09:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5u5QUEQIWItH7jUpfHgQpahxBAn4CalJSIBOfMSLd7ffWs/IGOwOxQei/hDgs4W+oYzVTu X-Received: by 2002:a63:5b5c:0:b0:440:8531:d3f6 with SMTP id l28-20020a635b5c000000b004408531d3f6mr22430032pgm.114.1667398172150; Wed, 02 Nov 2022 07:09:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667398172; cv=none; d=google.com; s=arc-20160816; b=P1xNDI0wgPnKh1a2FjcXv2Fp71Zex235aKaQJE0+1yZVRuiHxJd90E0GL1azyg9cgf EMqlcRvBUgqjWDmKdQrioinjK8nDsujB68M/4CQYg1oJi1SCFZRlMKj3DzrrrWn4vnYm NoZJTCRqgefg6wFMT3gbw4pLgRh4s8S3Rjwj4ZJXbmZFX29FPIjcvjRTve/HAJmd08h1 Puz0f1H8Z0NMnpAmVXGW2VTPlMncpnk+9vAaMC34Q0x/IRAJx28zVW51nbDy1Bs9E4tq doqAqUT4gauh4XfTAIpvQEqUciIpgGRqYlQ4ptJcPgVxUM1PhUwzK+QDflYtYzIshL1n wyWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=HBO5BCOZ2Z0WCLEjydupZUSukLDaExZDrJ4vrJVVImU=; b=lkp6PZV3lfAQULvImSG0QhYzCaV0SpykHMscrD7XwhaYUg7f2+wtYKVL87FeQl2+m/ wa5iwsqHeJgr960rZEHakn8K3ER9g9f03dIlBHwLmB2ooV8I66OLOPZ+d/1r9tQhcCSa nZDDgRZFS7BJN8QZkehGLLYkXf61JjxbabFoMshCgV/oFgB7P0ZP4ZvNKx/eYGtwLbOE dSuanppGDsorQSgtBLXAwsxlo0ORM9biWUqt/CjgttFOqchNV9nqZQuou/JfV8QVvTOj LzAA7p0NQbAI2MxkhMQ1qkh+a5RgCNuWwYPgRDEtSVkv70N/KiMKwCvcfiyRM7+7/0/L cBZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y2-20020a655a02000000b0045f7fc4b812si17002849pgs.295.2022.11.02.07.09.18; Wed, 02 Nov 2022 07:09:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbiKBOIm (ORCPT + 99 others); Wed, 2 Nov 2022 10:08:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231292AbiKBOIf (ORCPT ); Wed, 2 Nov 2022 10:08:35 -0400 X-Greylist: delayed 1312 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 02 Nov 2022 07:08:33 PDT Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A36B65F1 for ; Wed, 2 Nov 2022 07:08:31 -0700 (PDT) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4N2TJF3w9Wz4y3Zl; Wed, 2 Nov 2022 22:08:29 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2A2E8NHA021607; Wed, 2 Nov 2022 22:08:23 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 2 Nov 2022 22:08:27 +0800 (CST) Date: Wed, 2 Nov 2022 22:08:27 +0800 (CST) X-Zmail-TransId: 2af9636279db19c123a6 X-Mailer: Zmail v1.0 Message-ID: <202211022208274530566@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_soundwire=3A_qcom=3A_remove_redund?= =?utf-8?q?ant_ret_variable?= X-MAIL: mse-fl1.zte.com.cn 2A2E8NHA021607 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.251.13.novalocal with ID 636279DD.005 by FangMail milter! X-FangMail-Envelope: 1667398109/4N2TJF3w9Wz4y3Zl/636279DD.005/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 636279DD.005/4N2TJF3w9Wz4y3Zl X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748393705629125858?= X-GMAIL-MSGID: =?utf-8?q?1748393705629125858?= From ebc0be30e0c49d2d54a9aaa064c7f742e99e8eb2 Mon Sep 17 00:00:00 2001 From: zhang songyi Date: Wed, 2 Nov 2022 22:08:48 +0800 Subject: [PATCH linux-next] soundwire: qcom: remove redundant ret variable Return value from swrm_get_packed_reg_val() directly instead of taking this in another redundant variable. Reported-by: Zeal Robot Signed-off-by: zhang songyi --- drivers/soundwire/qcom.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.15.2 diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 335424870290..d92f421d38c8 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -260,7 +260,6 @@ static int qcom_swrm_cpu_reg_write(struct qcom_swrm_ctrl *ctrl, int reg, static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data, u8 dev_addr, u16 reg_addr) { - u32 val; u8 id = *cmd_id; if (id != SWR_BROADCAST_CMD_ID) { @@ -270,9 +269,8 @@ static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data, id = 0; *cmd_id = id; } - val = SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr); - return val; + return SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr); } static int swrm_wait_for_rd_fifo_avail(struct qcom_swrm_ctrl *swrm)