From patchwork Wed Nov 2 13:48:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhang.songyi@zte.com.cn X-Patchwork-Id: 14240 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3635929wru; Wed, 2 Nov 2022 07:01:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5i2CXV1c1/PER3DgshERWqGz6e2/oHHv/ArXWbFcqZ2ruZ9oTHmsPZUspzVo4mp5/iuofm X-Received: by 2002:a17:907:3205:b0:770:8554:c4ee with SMTP id xg5-20020a170907320500b007708554c4eemr24301865ejb.39.1667397680768; Wed, 02 Nov 2022 07:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667397680; cv=none; d=google.com; s=arc-20160816; b=jvpZC/v+mLQAkWSBVF4/ycSX8AY46obiSh61kejCFe1799YA0TBWS17beSdRRCCFKg muR/+vuJfKTK/Vztmuxg+HfCK77gcjqWns0YNuAanYsmH9kKNIMK9RX61jmK+eNn6/+/ cmBUATCdLFlJ7R/3CxtUojuibM4lgsO+W/sqeIaBVLLLbXMuRV5SyXqEVbZyuij6euhX JvhCE0uYH2NRK7zrYYCu/zarnydm1ZJSR5WyqbeXlrbnBcCstd1QF8+NztLzZrG4FNtF MN0ol5hiJw7OXP+4j732HQFJGNZL0U8PXRc8+f553OkE61JT7YxY8fVbNipH+NvuS27a oJ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=nL+pNrZBhfba9c4oBW7FO3KRYZzo5M33GPr8i4ehJdA=; b=nrWCukF4rN6u4MTvhNLj+ne+oaurGbH9+VReW7AJBcRa+AHdSF5Qn6+sDeZX+zs6MT FdIY7fpwf2coLwNnpjLuF7A4qbDfYW2qTSOzYcQb1Sd/jO4Nc6BAwNXgOUFWlRuV2Pfv Sh/w/RfjcEpIwFZSqLHTzWrEOJQY3CLnaecZjAjxMCeTZaQ07FOegbHYx/FNLk2pDr/q 9JD0VFnKYefXXnzYyzl0tXIZWZWHGX2ny/BAVhyUE5dUqoO+YmZeiu1D6UQ9jzkG8p3K dAPe5/ewhuiHsXwf1jg55fR6Svduu4gmfKHwkW8EXo4KaJseGNcxmYVD/3fmn92X9Uxq YNog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gv28-20020a1709072bdc00b0078db6f488cesi12545702ejc.112.2022.11.02.07.00.56; Wed, 02 Nov 2022 07:01:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbiKBNs2 (ORCPT + 99 others); Wed, 2 Nov 2022 09:48:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiKBNs0 (ORCPT ); Wed, 2 Nov 2022 09:48:26 -0400 X-Greylist: delayed 103 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 02 Nov 2022 06:48:24 PDT Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7E502AC51; Wed, 2 Nov 2022 06:48:24 -0700 (PDT) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4N2Ss338PDz5PkGw; Wed, 2 Nov 2022 21:48:23 +0800 (CST) Received: from xaxapp03.zte.com.cn ([10.88.40.52]) by mse-fl1.zte.com.cn with SMTP id 2A2DmGnv006058; Wed, 2 Nov 2022 21:48:16 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 2 Nov 2022 21:48:20 +0800 (CST) Date: Wed, 2 Nov 2022 21:48:20 +0800 (CST) X-Zmail-TransId: 2af963627524ffffffffb35f9d57 X-Mailer: Zmail v1.0 Message-ID: <202211022148203360503@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_ionic=3A_remove_redundant_ret_vari?= =?utf-8?q?able?= X-MAIL: mse-fl1.zte.com.cn 2A2DmGnv006058 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 63627527.000 by FangMail milter! X-FangMail-Envelope: 1667396903/4N2Ss338PDz5PkGw/63627527.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63627527.000/4N2Ss338PDz5PkGw X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748393190665752835?= X-GMAIL-MSGID: =?utf-8?q?1748393190665752835?= From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001 From: zhang songyi Date: Wed, 2 Nov 2022 20:57:40 +0800 Subject: [PATCH linux-next] ionic: remove redundant ret variable Return value from ionic_set_features() directly instead of taking this in another redundant variable. Reported-by: Zeal Robot Signed-off-by: zhang songyi Acked-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.15.2 diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index 4dd16c487f2b..a68d748502fd 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -1557,14 +1557,11 @@ static int ionic_set_features(struct net_device *netdev, netdev_features_t features) { struct ionic_lif *lif = netdev_priv(netdev); - int err; netdev_dbg(netdev, "%s: lif->features=0x%08llx new_features=0x%08llx\n", __func__, (u64)lif->netdev->features, (u64)features); - err = ionic_set_nic_features(lif, features); - - return err; + return ionic_set_nic_features(lif, features); } static int ionic_set_attr_mac(struct ionic_lif *lif, u8 *mac)