From patchwork Wed Nov 2 18:08:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 14418 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp59522wru; Wed, 2 Nov 2022 11:09:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6s14nQCHxiaNAKnmAjPP5pLbKXtjBLJeiYrFzgLI4hLnqeiYAY6rxGTedJKW9/eQEBXz5i X-Received: by 2002:aa7:9e85:0:b0:56c:683b:d31f with SMTP id p5-20020aa79e85000000b0056c683bd31fmr26571897pfq.48.1667412581395; Wed, 02 Nov 2022 11:09:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667412581; cv=none; d=google.com; s=arc-20160816; b=aGHV28Y+hBTEsxDKyOWHKkwTo2fg+iqvab86uFeg/d6SihQHaOkddSyO42ED0JNMvJ PFyU8EEY6jBkibku6bsa6mXSnKugXZEZFgNWtAc5s9n63JGb9PvHHKuzEF9kwEDfRrnq A/JXUtH7yVOq2KEfYqdB3iHh5ZIdQkhAQiieqoxoJcmxzn6PSgmsj9WF92OOMthCvH3+ +og76HVmwA2FDVZUscgZzmTHNLrD9ow2XJl76QFbNII39AT/tXR/M2w7l26ykgV84GXo 8fgd2G3JocxVdIiU97XPdfGY8RQTSGQIscUM7W6Y0kHo9DSrhyHZVbsopMrjb7GsFbE8 dtmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3bJiWx1wliVbcBA4hLVtU2HKADrW2hjL3FgeqkhgWtw=; b=LoveVhEv2we/NzJK/s9F5J1J0m8GWmKlWkC8xp4mQH3aNit31LsGzCcwP81gUrYtpO fYsi7KeUGDIASPdRF3XfizcrVU8v4IdW+qgbRY5NRQ0k4LQJEwpzCqzqjJPFVGsU5ZFL ubTF3KrwnLVAx1J9/pU37Mc0w1kqpHNRm1+5lrKvPylVHze6Wy6cLuwJxEPPDSIrPacN 1rKh2f3TJEE+6RheCcH4VHZA0LXbBgJ/yNSxhPtQAOGx8GlTrudc2+zcNn6xW+VOCD9z YzdOE/CKRRf6DOcHYh70a2iKKovTfMh6lLLrtS7h3krMvO564CsVjiMd6WZzFLnt1pwh S0RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MuOr6WgU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k14-20020a63d84e000000b0046ec396db31si16267907pgj.857.2022.11.02.11.09.28; Wed, 02 Nov 2022 11:09:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MuOr6WgU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbiKBSI3 (ORCPT + 99 others); Wed, 2 Nov 2022 14:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbiKBSIW (ORCPT ); Wed, 2 Nov 2022 14:08:22 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2897DFC; Wed, 2 Nov 2022 11:08:20 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id f27so47485738eje.1; Wed, 02 Nov 2022 11:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3bJiWx1wliVbcBA4hLVtU2HKADrW2hjL3FgeqkhgWtw=; b=MuOr6WgUNRTbGp0fKCLMkl/k7dGETn0MCPk6OvhPg3lmMvlQgmcuBFQ+ABDIQVEfIR wFZp5SWC4EFvbN0KmunKKO77/O/BC7U/qywpY2f1LZBtchRftfHVF3XlxDQXgmGoQ3Cu HRfmoLIhb4dl4QLwwj8v/orGggqh47FggbluTDhATnJPTKIyLEFUq6U5YhVS+2MCTQVG Gk2wEwdsPhpcbyRz3cEpnHhdYsYto1gGKo/qcRpNS7dSxQpynS9SIQ1g/wDHuap9qgst EArzOONtTazMJBiM1MR40HcTRdRrPXfFh+vXs2vu6s+5u1L8ble5iN+quusR0rM+WQoX JcKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3bJiWx1wliVbcBA4hLVtU2HKADrW2hjL3FgeqkhgWtw=; b=4ZAWPumnIsQTaMEfJV65iERLk4HGPIu9gSOyxFI2BUf1THW1X9+NgnxeXjPmzJZsLG a/xF9Z8YGiJhOQrUxFYjrA13bJt1T7RkZccRlq+Kgi8t7HLum4mRwBCNU6KBdv3snywS jO2zpoG9BpLWi7yiUGX/5LdhX+4LDN+lXw6XTmOXykM6Hq8YspSw69kPBmKNlFyRi3H6 PM7diodsjy+xsjr1jajq0eF+XwwRTmW4mySaPSPQlNuDr/vU76ZYKYHTyzt6uDGgyiPV kc5UYHWQzsNwKtp7nUWWLPeTXqv125miFVAn8Ivdky/l8x91rSW0iR4ZGM0nXmGov8wN TM9w== X-Gm-Message-State: ACrzQf3OYzeMulMo1OD9Ia5viidP9tfzhwidiUYHKRq5abOgCq9RJnKc xkiXGRFSM3Xa8/Br8Fb7F/Q= X-Received: by 2002:a17:907:b15:b0:7a7:19a3:e9e7 with SMTP id h21-20020a1709070b1500b007a719a3e9e7mr24606410ejl.361.1667412498590; Wed, 02 Nov 2022 11:08:18 -0700 (PDT) Received: from kista.localdomain (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id gy8-20020a170906f24800b007317f017e64sm5677460ejb.134.2022.11.02.11.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 11:08:18 -0700 (PDT) From: Jernej Skrabec To: mripard@kernel.org, paul.kocialkowski@bootlin.com Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH v2 01/11] media: cedrus: remove superfluous call Date: Wed, 2 Nov 2022 19:08:00 +0100 Message-Id: <20221102180810.267252-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102180810.267252-1-jernej.skrabec@gmail.com> References: <20221102180810.267252-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748408815309919925?= X-GMAIL-MSGID: =?utf-8?q?1748408815309919925?= cedrus_try_fmt_vid_out() is called two times inside cedrus_s_fmt_vid_out(), but nothing changes between calls which would influence output format. Remove first call, which was added later. Acked-by: Paul Kocialkowski Signed-off-by: Jernej Skrabec --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index 33726175d980..1c3c1d080d31 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c @@ -309,10 +309,6 @@ static int cedrus_s_fmt_vid_out(struct file *file, void *priv, struct vb2_queue *peer_vq; int ret; - ret = cedrus_try_fmt_vid_out(file, priv, f); - if (ret) - return ret; - vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type); /* * In order to support dynamic resolution change,