From patchwork Wed Nov 2 11:43:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuwei Guan X-Patchwork-Id: 14192 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3567552wru; Wed, 2 Nov 2022 04:46:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM74QxvpO4Hx03MKOYxbuXFm6Vj+fgTPatXtFHEbnxC9DAdt6V2geTcWSHCz1vf45R5n+MBd X-Received: by 2002:a17:90a:dd82:b0:213:fd7d:6a68 with SMTP id l2-20020a17090add8200b00213fd7d6a68mr11825047pjv.187.1667389560681; Wed, 02 Nov 2022 04:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667389560; cv=none; d=google.com; s=arc-20160816; b=qcTo65qyouGRObcPeSIheP11zjGudcadXpRxp8/sdJeq7AeRFhZ3P2qeUhfIX4RDsQ wtEC2cydrP3EyIxxkEr1SsZCFw6ECUW3Z80dx7ydHHzk7YOwjQETe2dqK++Hhk+4qACK U+ItyHFfwYIFhV9oL6BmkV8SK0z30lgQOeYHbxEECoHRATbX50Ro3j93GG4YTBZ2wC/+ KAtkMSeARv34R+HYT7g6n3d+7Ybpq4j1i19WGt7y8Dcb/WTaMoKe52pCcKdbxPZx+ae7 V6ZVhJ6DmzIe5Ny1fthgu0XrcjaNv9CS2ONxuI/2A4TPbm28TsPWumteiq2ePgWJ1GMh tGVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0TO3AKUnGTYlpFDHE0inxQ4G6Kp5byNURiimvggoLdA=; b=nvo6cAVlYM5avpO5Ua8cROOSjWKXfY9XwxfSJmk1bGj8/o8uosgEK8MAJn7go08y6T VJfvualc+aKm/itEQfR9KRZ36xEi6qbXtX4Sikvft4tgf0/ujD9/ur1Tn1C5RsSyJGc0 Vxj1MKOi3woWBoResTiM2C8iqLtsGrieGAGI7A8fbTD9vcQbbl5gIqo+v38knZ4zhaV9 Op4tOWrYFNirgvQy7/zTN1ka2s3QCk7OMaZaZn43ce3MqKTQHbi+Y+IJn53y/76vAs+J EQeW47SRQDHXKOhQbXBygWy+Ga/BnH+BWBot94WMNRnE0aXW1aCpWEp1ZSZqaEGHYxiR DuTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Dfn45f8q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p33-20020a634f61000000b0046edccffb8dsi4840151pgl.535.2022.11.02.04.45.47; Wed, 02 Nov 2022 04:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Dfn45f8q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbiKBLoj (ORCPT + 99 others); Wed, 2 Nov 2022 07:44:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbiKBLo2 (ORCPT ); Wed, 2 Nov 2022 07:44:28 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC33328716; Wed, 2 Nov 2022 04:44:24 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id k7so6600473pll.6; Wed, 02 Nov 2022 04:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0TO3AKUnGTYlpFDHE0inxQ4G6Kp5byNURiimvggoLdA=; b=Dfn45f8qMlZMxWk8SdtU4g1j/0dksy4HKNil57zO838ijzFZAvF94pr0JzkIJqBfCE xRyWpDyx0dwfOBqGQBnN4T1c1KjR16kBL0CPPaQccxbmDPbREWvCI+XI4fRhGvv7RusC F9j2/nqV0l/9FY/LuHNolayQKAOZtO9YGsBPBP5NjJaP7FcQyszh47B80tpIEdxJSqZ/ sp5vKwNEjQ8ZmoNyX3LEfvcSAyfioYKKnp0aDtbdWjAL7s6Cw9Y7sK8Kx/Q9MPIjhmbM ofpi6YBJHwpGYdcd7pccfr1BaG1HjobH03lbzFrTutIYM0d7qUkML8/YrBM+7f5j7AIo iPnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0TO3AKUnGTYlpFDHE0inxQ4G6Kp5byNURiimvggoLdA=; b=YZxUg2bDjxPRnWJxZhRDbUp2fGONIPpMiggTlwVJn38QynjGbrlC0fxASN4+ohguCJ bS4j+jXBn39xUdfVzcHpJjXhKY5U+bl0ax6a03UKZbU15pBJQaGHtxyAhgL8mWHStDBW hTJlwRJe1Q+xycU1zKQkcut5+eJpc5p4cVFlgeJKAD4ruw6UrjYan0Kn8YsgbtG8fcCV 1LKxqLqGvHN0tonmXL5eoHG/qFEDAAKGWpc+CLQXUTL0oRjFQph0aDMs5A29E59iZelL r+csJr9HMY6i27s637vrWOt1T52ZRgM91wOusj/uYdRkuadcXsSlG8rQXwJKcLxfXh7I 1ZwA== X-Gm-Message-State: ACrzQf1on3w2AA6QpvhdTOIfI56RpOcG+k5xQs85dsfkvehtWVhUDMzh rmTx0pAsrPHpwukJ5vDEsBClWMw3hTRerBup X-Received: by 2002:a17:90b:1d90:b0:213:d0a2:72ab with SMTP id pf16-20020a17090b1d9000b00213d0a272abmr18587259pjb.221.1667389464293; Wed, 02 Nov 2022 04:44:24 -0700 (PDT) Received: from Zbook.localdomain ([129.227.152.6]) by smtp.gmail.com with ESMTPSA id a11-20020a170902eccb00b00172e19c5f8bsm8169978plh.168.2022.11.02.04.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 04:44:23 -0700 (PDT) From: Yuwei Guan X-Google-Original-From: Yuwei Guan To: paolo.valente@linaro.org, axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Yuwei.Guan@zeekrlife.com Subject: [PATCH 3/5] block, bfq: remove redundant max_t() in bfq_bfqq_charge_time() Date: Wed, 2 Nov 2022 19:43:52 +0800 Message-Id: <20221102114354.162-4-Yuwei.Guan@zeekrlife.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221102114354.162-1-Yuwei.Guan@zeekrlife.com> References: <20221102114354.162-1-Yuwei.Guan@zeekrlife.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748384675759678093?= X-GMAIL-MSGID: =?utf-8?q?1748384675759678093?= The "tot_serv_to_charge" is great than or equal to "entity->service", so no need to do max_t() again. Signed-off-by: Yuwei Guan --- block/bfq-wf2q.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c index 8fc3da4c23bb..3da08f4be633 100644 --- a/block/bfq-wf2q.c +++ b/block/bfq-wf2q.c @@ -867,8 +867,7 @@ void bfq_bfqq_charge_time(struct bfq_data *bfqd, struct bfq_queue *bfqq, if (tot_serv_to_charge > entity->budget) entity->budget = tot_serv_to_charge; - bfq_bfqq_served(bfqq, - max_t(int, 0, tot_serv_to_charge - entity->service)); + bfq_bfqq_served(bfqq, tot_serv_to_charge - entity->service); } static void bfq_update_fin_time_enqueue(struct bfq_entity *entity,