From patchwork Tue Nov 1 21:40:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 13901 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3230235wru; Tue, 1 Nov 2022 14:57:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5VFn/rkFuZ5RSMNYMP/F8YhdFbTRndm6o0T5kCxjJrTppSNhXQ/iw5iPv3Mse98KJ40sSN X-Received: by 2002:a17:907:2bd7:b0:7ad:9ada:a6f3 with SMTP id gv23-20020a1709072bd700b007ad9adaa6f3mr19628543ejc.355.1667339844795; Tue, 01 Nov 2022 14:57:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667339844; cv=none; d=google.com; s=arc-20160816; b=iJUkoT2zyrVo9FmyMxdlbDHaWEVpx1l5523jcNKJ+rNlUlKVdZvWnfvjorqEW7p9Su t2+8aahSBMHJE+n+aWciIsOcBSqcbKn8WwQPvPaviB3GvNATddtdxzrWWoqubBJaK57y OXSl2XZPclQbhbiGl//jjtxl1AJBjqrZH4PgkawZHnYvT7DuGblC9ttTOv+8MNdzyi1a QxDFUV58+U9drq2gRcYSQ8XsGbnJvvBGR27RkhyAyvd9OQQhzDKyPUMxbUQ5xkuQ35BB BjbFH4x+prB2W7u44ojZM3Y99ql3DATnMStKa+zwS/Qj4Ki4zpGZWXIsniCEDohV5acQ EpgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iWEKtw3qUiAawaOxdqPs0umv7nzkxV855xae9pF938c=; b=w14eTyEidT7Ssnx4BFxqPXpl2tBCWygd2Gr1Rs6yQkhpdkyQYMW/R0LFmAmHpujIyk 6aMHwdYpkfPafY0avODrIYUQugssEOAQD1NpQy2/r2ksNXj1fqFgIZNICNIfa+DANSz5 GS3Xhp1l2jWAdxcxOMPucPY8Z9UygKcj7cVdIgD9R+i+q94dQjRLFNphOTiydh4CqjgX ZHbFSmh8Yi7Nph37BSx7FT8jTvR1N28w1hi2Vo0SyeZ4UJnyzGgl7r9teHWRvGHkRKS6 /WBeXa4KrdWshVEhnoRc0OsBZzf1ab7dZrXTiW1c7Qe1T8QzS7pJLKY5QsYEGiCUGN14 40jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VZJNFuV6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020a1709062ccc00b007ad9f03aa6fsi10613653ejr.283.2022.11.01.14.57.00; Tue, 01 Nov 2022 14:57:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VZJNFuV6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbiKAVke (ORCPT + 99 others); Tue, 1 Nov 2022 17:40:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiKAVkc (ORCPT ); Tue, 1 Nov 2022 17:40:32 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF281E725; Tue, 1 Nov 2022 14:40:31 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id k15so6603174pfg.2; Tue, 01 Nov 2022 14:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iWEKtw3qUiAawaOxdqPs0umv7nzkxV855xae9pF938c=; b=VZJNFuV6OqUqkfyPaVBqFRI+HviyopjecL9O6a9KR4Dnv8fxfloSbQqHTlU5JDSJOZ Pcaf0S6s8TcGkbxtKETFXAKgbzTe/IXDkokGzWw0acAPUzDDYfblLW7lLXrvM2LC0/vI x84dmhX0CRy3+gkufw6qBK8XWvFITUYtX0NmO61tuNL1Jjjzln3Np3G1vqLZGXwh9zId 7OaeIm9GBk+PK8wQ+66P7wutixk0nL26IhFmix49TwTXFN+2+pWTVTT+4K5uyteDmKpn JuC0iT2Lrr+kGhVth0CVFVoI3rZc/YIVMeaLh2Sofc9hoEVbmuOpZEvkL+vtSlk6+Fzx qNUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iWEKtw3qUiAawaOxdqPs0umv7nzkxV855xae9pF938c=; b=tr6E7QgsSN4VYeMf+/CeenMG7bRMIRgUyzb8cc5RZ2DKI+GN0kMvAWWuyrvTaPYwSe UTtt3rVI7yEoKzQIC/xd54I2RnehpocTUgWmw2WR57BtD608EEk0rFDVOm900xUk2ojE LcaqfMV5Ba23XcYKOhqfkV8/Ih56odpmMe9EOCbbWxue45SR3uA+iUK45M7xux/E6W2h csfY1RYp0gA//6PVFo/tmt6cX9NYVP4M2vtVBuQfQDY2hHbhiX25zokrfoq4SwuZg6B2 q8g5b4Szt5J9MA8m7tIfptHwOW9t42zXpSHqyj5Yh72BHfTf0OCaQRriP8t+po9dBNu0 /CGA== X-Gm-Message-State: ACrzQf3fF0FgBWJn93EbsNjGpiLqJ46hoUVnf+VcsDejrex52OeVfQN5 ej9um/91ZrXDrrCn1QqPyuY= X-Received: by 2002:a05:6a00:224c:b0:56c:40ff:7709 with SMTP id i12-20020a056a00224c00b0056c40ff7709mr21623319pfu.59.1667338831058; Tue, 01 Nov 2022 14:40:31 -0700 (PDT) Received: from localhost ([2a00:79e1:abd:4a00:2703:3c72:eb1a:cffd]) by smtp.gmail.com with ESMTPSA id y5-20020aa78f25000000b005544229b992sm6964575pfr.22.2022.11.01.14.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 14:40:30 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Daniel Vetter , Rob Clark , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK), linaro-mm-sig@lists.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK) Subject: [PATCH] drm/msm: Remove exclusive-fence hack Date: Tue, 1 Nov 2022 14:40:51 -0700 Message-Id: <20221101214051.159988-1-robdclark@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748332544946731548?= X-GMAIL-MSGID: =?utf-8?q?1748332544946731548?= From: Rob Clark The workaround was initially necessary due to dma_resv having only a single exclusive fence slot, yet whe don't necessarily know what order the gpu scheduler will schedule jobs. Unfortunately this workaround also has the result of forcing implicit sync, even when userspace does not want it. However, since commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") the workaround is no longer needed. So remove it. This effectively reverts commit f1b3f696a084 ("drm/msm: Don't break exclusive fence ordering") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 5599d93ec0d2..cc48f73adadf 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -334,8 +334,7 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) if (ret) return ret; - /* exclusive fences must be ordered */ - if (no_implicit && !write) + if (no_implicit) continue; ret = drm_sched_job_add_implicit_dependencies(&submit->base,