From patchwork Tue Nov 1 19:14:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Straube X-Patchwork-Id: 13850 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3156122wru; Tue, 1 Nov 2022 12:15:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6iu0QrOTfszjTjAHwVovRDOU8EhFUOsZdS7e//wsHiMxKpguhRev+ffMsI13yxZXHkYW++ X-Received: by 2002:a63:d241:0:b0:43c:474c:c6c6 with SMTP id t1-20020a63d241000000b0043c474cc6c6mr18398374pgi.523.1667330139677; Tue, 01 Nov 2022 12:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667330139; cv=none; d=google.com; s=arc-20160816; b=kTnPiSMqxFvdEGdelDyp34/HvdRgoARs7wVpuijHkRK6k6dutiX9fvOu96i3tBjFL1 E53D+jXZaf8ZzXxcQ9VbVNhV2+/lt7JmTyYJUySyglQJOoeKaaD6bjBr9Fh8AX7+MBM/ Hcu9cGCdGXQsQZtZjdelRlC1JiNCvDvpXtS2sPIytptZwgCMfUV0xpZmJxsdSyMoCOMM GTWf4UF674H3pEPuh01kq2fKvBS+g9nTJUvRorfI3t8B2FCNbXBZgJCkLCP7HEUWdtug /SHNGyy005NfezURD5E60Nktsg+M4ZkAutfWJOMfK7MHifHJLwfawpkaTzRzRJ1Bin3z T6iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D/oBXqxDLFWq3xQv029eFhBNmCMw5i5DAryxQ4apvwg=; b=Blti8u8ZusaI3p4Qf9epgpGfqJH3jsjvYhExexrSpW5e5Ccdomw2zRQ1lq4QQrguuv sBqSedWXX6tTGE0xCHXVD+yx9pzjDA1N+qUSF6RPdIrdWjQ2an5t1N1t66xq2uzwh8NM SF6dub5HErNhyC3x7okzQgzbdZzbujlRgx21uhcq3mrhA5VKWVN0Z+VXrtj/r6mfNCL4 CojlDv1syDhYBiiNwf7VuoA05iWnIczigrpuw0IokxSp0bkv13WnadgN8ET7g87A7Tu0 F3WV8EB7/c0VkjQy1TL2ADiBUtaT0+ScfSmdoAicRl+OUFdWhFRlw/NQ6WiXRxvwcemz wqWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="OZv+ITK/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a170903228d00b001870c4c2722si12478243plh.299.2022.11.01.12.15.24; Tue, 01 Nov 2022 12:15:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="OZv+ITK/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbiKATPK (ORCPT + 99 others); Tue, 1 Nov 2022 15:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiKATPG (ORCPT ); Tue, 1 Nov 2022 15:15:06 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AE90167F6 for ; Tue, 1 Nov 2022 12:15:05 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id f27so39543477eje.1 for ; Tue, 01 Nov 2022 12:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D/oBXqxDLFWq3xQv029eFhBNmCMw5i5DAryxQ4apvwg=; b=OZv+ITK/ZUL27cndkP0A26xz4Q7jyC4NJwrQeMhoFL3e9xZ5ctFxL520vVXl2y+hS3 jSQ6By4kG2U7FjQczlJmpsLLv7CsHs3bbqiJfmBQ4PCY7VLDCEMx7FFFm43UVGpG/49W 3WMd48nfmsSB09LTfSabYekkuyr3LwVlyn5Z7Qqzest2+o0T4pzXeyVs5YacocWckmT3 p/NYCy1ZhxAggbwp/qHj+ZK/97YXkBpp6gHU3gpeApNmor6B6/kaHJUtyueOUvYM4lQ2 TwqrTo8zrMz289HvYWmaC65eI6fauNUSJcsb7cTykQVz6lFeCfsTuDx41lfyVqezPbj0 s+xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D/oBXqxDLFWq3xQv029eFhBNmCMw5i5DAryxQ4apvwg=; b=hF+HRasF+hC/h7OCskmb1RP6E+ZXoGoCoc15WwAARKM4lNepxrGOU4sfFcROIBNRNu fiwmC2qDTIF6kUkK50cPBmzUj6gOUYsxwcGIcJFHRCq1pwNOFZcSawf9Fp0rzkuljbXx M6CCUepxnYEurGuf0WtNCoAbTR48+Zdn1UYrtyu+lUJw6/8V86UIiB/ZAMwbyF7FUfNK gXqJYwuA6tEg878DBpWZFFbaYk6Qy84tv1ArE9Hesqu6qp3eEFaD4/Ebma/6xrTBiPTU Yd+v8WO0ifD5kIFkKXXYaTu7PFVIce1FmT7CwpYLPISTZZzyqJTgE0MeC5EN7NXzYIsf 6LnA== X-Gm-Message-State: ACrzQf27f86/RYP6FXa2/4BMwlcS+Z9MJr46AqbAETdsJj6jXZKx1Rt3 4EiGLP56SDYsVQNzs9XwoZU= X-Received: by 2002:a17:906:5dda:b0:78d:ed96:2127 with SMTP id p26-20020a1709065dda00b0078ded962127mr19010501ejv.373.1667330104094; Tue, 01 Nov 2022 12:15:04 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb7a.dynamic.kabel-deutschland.de. [95.90.187.122]) by smtp.gmail.com with ESMTPSA id hw20-20020a170907a0d400b007ade5cc6e7asm1643853ejc.39.2022.11.01.12.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 12:15:03 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/2] staging: r8188eu: remove extern from function prototypes Date: Tue, 1 Nov 2022 20:14:57 +0100 Message-Id: <20221101191458.8619-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221101191458.8619-1-straube.linux@gmail.com> References: <20221101191458.8619-1-straube.linux@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748322368545584014?= X-GMAIL-MSGID: =?utf-8?q?1748322368545584014?= Declaring function prototypes extern is redundant and triggers checkpatch warnings. Remove all extern from function prototypes. Signed-off-by: Michael Straube --- .../staging/r8188eu/include/osdep_service.h | 2 +- drivers/staging/r8188eu/include/rtw_mlme_ext.h | 4 ++-- drivers/staging/r8188eu/include/sta_info.h | 18 +++++++++--------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/r8188eu/include/osdep_service.h b/drivers/staging/r8188eu/include/osdep_service.h index ec2631455f08..f8ed04f32cae 100644 --- a/drivers/staging/r8188eu/include/osdep_service.h +++ b/drivers/staging/r8188eu/include/osdep_service.h @@ -66,7 +66,7 @@ static inline int rtw_netif_queue_stopped(struct net_device *pnetdev) netif_tx_queue_stopped(netdev_get_tx_queue(pnetdev, 3)); } -extern int RTW_STATUS_CODE(int error_code); +int RTW_STATUS_CODE(int error_code); void *rtw_malloc2d(int h, int w, int size); diff --git a/drivers/staging/r8188eu/include/rtw_mlme_ext.h b/drivers/staging/r8188eu/include/rtw_mlme_ext.h index ce5b57e23e53..e234a3b9af6f 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme_ext.h +++ b/drivers/staging/r8188eu/include/rtw_mlme_ext.h @@ -388,7 +388,7 @@ struct mlme_ext_priv { void init_mlme_ext_priv(struct adapter *adapter); int init_hw_mlme_ext(struct adapter *padapter); void free_mlme_ext_priv (struct mlme_ext_priv *pmlmeext); -extern struct xmit_frame *alloc_mgtxmitframe(struct xmit_priv *pxmitpriv); +struct xmit_frame *alloc_mgtxmitframe(struct xmit_priv *pxmitpriv); unsigned char networktype_to_raid(unsigned char network_type); u8 judge_network_type(struct adapter *padapter, unsigned char *rate, int len); @@ -483,7 +483,7 @@ void report_add_sta_event(struct adapter *padapter, unsigned char *addr, int cam_idx); void beacon_timing_control(struct adapter *padapter); -extern u8 set_tx_beacon_cmd(struct adapter *padapter); +u8 set_tx_beacon_cmd(struct adapter *padapter); unsigned int setup_beacon_frame(struct adapter *padapter, unsigned char *beacon_frame); void update_mgnt_tx_rate(struct adapter *padapter, u8 rate); diff --git a/drivers/staging/r8188eu/include/sta_info.h b/drivers/staging/r8188eu/include/sta_info.h index f76e086b5701..55ea5edc2914 100644 --- a/drivers/staging/r8188eu/include/sta_info.h +++ b/drivers/staging/r8188eu/include/sta_info.h @@ -295,19 +295,19 @@ static inline u32 wifi_mac_hash(u8 *mac) return x; } -extern int _rtw_init_sta_priv(struct sta_priv *pstapriv); -extern void _rtw_free_sta_priv(struct sta_priv *pstapriv); +int _rtw_init_sta_priv(struct sta_priv *pstapriv); +void _rtw_free_sta_priv(struct sta_priv *pstapriv); #define stainfo_offset_valid(offset) (offset < NUM_STA && offset >= 0) int rtw_stainfo_offset(struct sta_priv *stapriv, struct sta_info *sta); struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int off); -extern struct sta_info *rtw_alloc_stainfo(struct sta_priv *stapriv, u8 *hwaddr); -extern u32 rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta); -extern void rtw_free_all_stainfo(struct adapter *adapt); -extern struct sta_info *rtw_get_stainfo(struct sta_priv *stapriv, u8 *hwaddr); -extern u32 rtw_init_bcmc_stainfo(struct adapter *adapt); -extern struct sta_info *rtw_get_bcmc_stainfo(struct adapter *padapter); -extern u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr); +struct sta_info *rtw_alloc_stainfo(struct sta_priv *stapriv, u8 *hwaddr); +u32 rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta); +void rtw_free_all_stainfo(struct adapter *adapt); +struct sta_info *rtw_get_stainfo(struct sta_priv *stapriv, u8 *hwaddr); +u32 rtw_init_bcmc_stainfo(struct adapter *adapt); +struct sta_info *rtw_get_bcmc_stainfo(struct adapter *padapter); +u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr); #endif /* _STA_INFO_H_ */