From patchwork Tue Nov 1 17:42:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13822 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3117533wru; Tue, 1 Nov 2022 10:57:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Rli5J1Tg+owXSMYcEQdHm7DJ7g0PI/C3E4e+3FgB0Gtf/OJETf/7Eja38rZ4vfP9b2PNQ X-Received: by 2002:a63:f346:0:b0:46f:6aff:b5ea with SMTP id t6-20020a63f346000000b0046f6affb5eamr17531640pgj.461.1667325437366; Tue, 01 Nov 2022 10:57:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667325437; cv=none; d=google.com; s=arc-20160816; b=MyU4vegxaQXOdkyMSzjycwM81LxRoBlofpdRcsUfEf8ko6N0zuRdIMs3knMgdLMCnP YqR4jQ6hucH9XQwqJemxRGAcsR2wCskiDhk2NlanQ0WV46Mstg07WFUWNFX+Dba1aeJS F8ozCuDE3cBExN30aQgbENBA6AX3L5VEPAaLfAZu4+Yh8Edy1DXqEhde+X1q2Z+OZmcy SHb8uFl7cfZiPoeaPS624XL4V9xkusdGei1TffF0fC6Pws5U8OIB25pPEzDbHY/Q62ZL +DkIViV4xSAWRKLo1INm/aYgpwyoII/OJlscSetmCGwh2c2M43CZhdyVdAMgGANxa6ue WwcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gcUszgcXB++WQ3rZU9ZUH65xdwxI+QkjQfVNfYzU3rM=; b=xqP4aKNJsKIfMJD2UnIi05CD4KUAbGGw+WKRYHOZRhKwGmCt3z+FxrDuTZ+5/fUdTU Emx+1aj+4aPu/G4N4TyuIquzWBLtycUWBessrdjm8aX77NW8DFKsz+JrhG0PgUvguf0z FIvXjcGPSxTMAkhPkt2u7ofkAd9IOtuHtK5fgp5ho4RjsnBMWMw+mM9lzBCUjT4RMLCv Eoy6p+Px9knQrcY0Ka9XtvlDUZz4lGFAecqdsVjHc3fJrZ18FVdiC/tWcH8c9WyaPTNx LQK5qj0fgczH8ggubq4FLytofdJgGa28ITJsJE/S7VUkuKO2akM5ryTPCbgM1zzZq74k LNcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fklKvWAO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r200-20020a632bd1000000b0045fc63bf52csi13356427pgr.764.2022.11.01.10.57.04; Tue, 01 Nov 2022 10:57:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fklKvWAO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbiKARmo (ORCPT + 99 others); Tue, 1 Nov 2022 13:42:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbiKARmi (ORCPT ); Tue, 1 Nov 2022 13:42:38 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE801D32F; Tue, 1 Nov 2022 10:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667324557; x=1698860557; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=oHHuxOzKVmiUxNopbnR8MZfBR9TH3eINRdcTm5mkIiE=; b=fklKvWAOUgxhzBXbMRj5KmpjzVkklz7DrGUEHl/9Azl4UlH4QPnrx4KI 2U2l9f0srdspN3xAKUoRTJRXT8Hx6830ysDtufjZjXpKWRklHGys4QvjK FhGRZWlG5l7vWuLRFbarirYzgMOrA9mFK8Owudpx0gjZAxIY3IwW52/Mh qrfcoxhtebX942LxJkOsXp/8Liw8cgqNlV2Cyo0oJf8faF1p6X0mPQBj4 GlSs26tDp7HfdDHSa1yAKfDSr0QCkaMOD1psJhH+JdO8Y97VVEN2JfGW5 dVFXQJyJeQH0Ng/O12F4SjrjEpfCfTLXExCBP/pS/Gg8k4lFfKImrxx3o A==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="292506333" X-IronPort-AV: E=Sophos;i="5.95,231,1661842800"; d="scan'208";a="292506333" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 10:42:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="636478620" X-IronPort-AV: E=Sophos;i="5.95,231,1661842800"; d="scan'208";a="636478620" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 01 Nov 2022 10:42:34 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DBDAAF7; Tue, 1 Nov 2022 19:42:57 +0200 (EET) From: Andy Shevchenko To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thierry Reding , Andy Shevchenko Subject: [PATCH v1 1/3] pwm: core: Refactor pwmchip_add() to avoid extra checks Date: Tue, 1 Nov 2022 19:42:53 +0200 Message-Id: <20221101174255.54452-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748317437689907922?= X-GMAIL-MSGID: =?utf-8?q?1748317437689907922?= When we already know that everything is fine there is no need to use ret variable. Refactor code accordingly. Signed-off-by: Andy Shevchenko --- drivers/pwm/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index d333e7422f4a..855abd0a776f 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -296,16 +296,16 @@ int pwmchip_add(struct pwm_chip *chip) INIT_LIST_HEAD(&chip->list); list_add(&chip->list, &pwm_chips); - ret = 0; - if (IS_ENABLED(CONFIG_OF)) of_pwmchip_add(chip); -out: mutex_unlock(&pwm_lock); - if (!ret) - pwmchip_sysfs_export(chip); + pwmchip_sysfs_export(chip); + + return 0; +out: + mutex_unlock(&pwm_lock); return ret; }