From patchwork Tue Nov 1 13:20:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13664 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2962420wru; Tue, 1 Nov 2022 06:23:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7nmqc3kyyHaFuS3/LcG5A0rcyeoSYvIPOg6s2rjcKcx1HvdNoR+wxdy+eLI2CnQIOcttyo X-Received: by 2002:a17:902:ecc8:b0:186:e2e6:f567 with SMTP id a8-20020a170902ecc800b00186e2e6f567mr19484950plh.11.1667308980845; Tue, 01 Nov 2022 06:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667308980; cv=none; d=google.com; s=arc-20160816; b=tJmBugEo60o49Dc7O4tlf+qR5gTQ2NxV2S9YDQmQLEhgifDpZmAcK55FRldh98ur7a nUxc7DmY4fgQzoVuATw4NHtineDo4j1LefFZXNOFIBfmfQ+mx7+AbC4PQNulniRnXWbm Gk1GRhHTG08pCNKa0cx/T31NCt3W54gAtDgIuzmL7ps4RraAg8/rApV4Zo/7wmscY7nQ zMj4oXdWMqfwbMzfGf+no+J4cRyj5vUZ6DmVxbTFZEK5TrnLl+nsbi8B59ihXKGxEnc4 RX+SK/65pY5zn7wa+D9LWMU8YfTYyXC1JILpjj2VQW/kTHZp/IfGnc3LFOZD0s/0lVum 5LXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=u2vkTmC0MUTy1TsDnElXxmMzsE3x/IEra0ctklTPu/s=; b=RANGg+Z9rV90ENZ5qKa0VMYAiVtz9fxGriIFG9+VwGR1/UUbDDxqWPnXJkURYVuesb fM12Ag2881Rh0WM1bE0owcudPAGajIV0eg3eXgjfZGm48ZCT1h5RrIVg9KsboHBeLSNL iHgLPC4iIopPh78s0gBYupXtuy5oT6VAfd9BXenahEmixV8/cJqNUXqeWysuG+pnUuIR 5ldfHvAySiBWSv7+jF+nxDlzzvm0faF2F8OELJuzaXCmQElutVw9kd8IMMyZJ2jOGq0T BSd97+jCD1IJ9wm0rJom0lZnA49gBxLCybZe6rl3DDFfSAp/+g5JcVUvMigCXrg7y4Jo XmOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=FX+7y83O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u16-20020a17090abb1000b0020adba9ec02si11745806pjr.82.2022.11.01.06.22.36; Tue, 01 Nov 2022 06:23:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=FX+7y83O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbiKANVA (ORCPT + 99 others); Tue, 1 Nov 2022 09:21:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbiKANU6 (ORCPT ); Tue, 1 Nov 2022 09:20:58 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7711FD08; Tue, 1 Nov 2022 06:20:57 -0700 (PDT) Received: from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD77D158A; Tue, 1 Nov 2022 14:20:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1667308854; bh=qqlP9y4CxrbgrpwUUQtSV2m4Q9RgrkWSjW1olrXBJFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FX+7y83Onmb73XKFQVu26+/w/AMpXDmSGEgqA/GFV5gACoI/bRG40e1LyZtPvQlTL fXTZlotT1Ejspi4Rs4fZhQeyVAN6Nip7mx8ui1nmAQ0ig3tRhidjTxNv7inrBpCndm +Nmkx4oJU6L+E7DSogpobL/nG4Iu7IDFV8CZamV0= From: Tomi Valkeinen To: devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: Hans Verkuil , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Luca Ceresoli , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Rob Herring , Sakari Ailus , Vladimir Zapolskiy , Wolfram Sang , satish.nagireddy@getcruise.com, Tomi Valkeinen Subject: [PATCH v4 1/8] i2c: core: let adapters be notified of client attach/detach Date: Tue, 1 Nov 2022 15:20:25 +0200 Message-Id: <20221101132032.1542416-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101132032.1542416-1-tomi.valkeinen@ideasonboard.com> References: <20221101132032.1542416-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748300181967213099?= X-GMAIL-MSGID: =?utf-8?q?1748300181967213099?= From: Luca Ceresoli An adapter might need to know when a new device is about to be added. This will soon bee needed to implement an "I2C address translator" (ATR for short), a device that propagates I2C transactions with a different slave address (an "alias" address). An ATR driver needs to know when a slave is being added to find a suitable alias and program the device translation map. Add an attach/detach callback pair to allow adapter drivers to be notified of clients being added and removed. Signed-off-by: Luca Ceresoli Signed-off-by: Tomi Valkeinen --- drivers/i2c/i2c-core-base.c | 18 +++++++++++++++++- include/linux/i2c.h | 16 ++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index b4edf10e8fd0..c8bc71b1db82 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -966,15 +966,23 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf } } + if (adap->attach_ops && + adap->attach_ops->attach_client && + adap->attach_ops->attach_client(adap, info, client) != 0) + goto out_remove_swnode; + status = device_register(&client->dev); if (status) - goto out_remove_swnode; + goto out_detach_client; dev_dbg(&adap->dev, "client [%s] registered with bus id %s\n", client->name, dev_name(&client->dev)); return client; +out_detach_client: + if (adap->attach_ops && adap->attach_ops->detach_client) + adap->attach_ops->detach_client(adap, client); out_remove_swnode: device_remove_software_node(&client->dev); out_err_put_of_node: @@ -996,9 +1004,17 @@ EXPORT_SYMBOL_GPL(i2c_new_client_device); */ void i2c_unregister_device(struct i2c_client *client) { + struct i2c_adapter *adap; + if (IS_ERR_OR_NULL(client)) return; + adap = client->adapter; + + if (adap->attach_ops && + adap->attach_ops->detach_client) + adap->attach_ops->detach_client(adap, client); + if (client->dev.of_node) { of_node_clear_flag(client->dev.of_node, OF_POPULATED); of_node_put(client->dev.of_node); diff --git a/include/linux/i2c.h b/include/linux/i2c.h index f7c49bbdb8a1..9a385b6de388 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -584,6 +584,21 @@ struct i2c_lock_operations { void (*unlock_bus)(struct i2c_adapter *adapter, unsigned int flags); }; +/** + * struct i2c_attach_operations - callbacks to notify client attach/detach + * @attach_client: Notify of new client being attached + * @detach_client: Notify of new client being detached + * + * Both ops are optional. + */ +struct i2c_attach_operations { + int (*attach_client)(struct i2c_adapter *adapter, + const struct i2c_board_info *info, + const struct i2c_client *client); + void (*detach_client)(struct i2c_adapter *adapter, + const struct i2c_client *client); +}; + /** * struct i2c_timings - I2C timing information * @bus_freq_hz: the bus frequency in Hz @@ -726,6 +741,7 @@ struct i2c_adapter { /* data fields that are valid for all devices */ const struct i2c_lock_operations *lock_ops; + const struct i2c_attach_operations *attach_ops; struct rt_mutex bus_lock; struct rt_mutex mux_lock;