From patchwork Tue Nov 1 09:34:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2845363wru; Tue, 1 Nov 2022 02:35:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5N14kvkk9kYHqsZLXnkDB1FQar6hFhiaE774hGmaJy8ibE+ri3cNDyXWaLdKkekpmIYE61 X-Received: by 2002:a05:6a00:18a8:b0:56c:702a:5f49 with SMTP id x40-20020a056a0018a800b0056c702a5f49mr19171823pfh.1.1667295346556; Tue, 01 Nov 2022 02:35:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667295346; cv=none; d=google.com; s=arc-20160816; b=m3eRNRiGq0VhVKJmZG1L8hPq4YPUch/uGTc5Jqp7apPPFDIho9a59irnkf+FetqH16 0ngK6UxXDse0VgWI8VobbSjh9cxIyWHCmwdozZ1VjATInZ5ZgMReLOfU7fwG0M31Z7uy 8+FIA8TvpmXGteVZX9aoWY/QuLm4ay108MA5UNcxlDQsnz19EiDyS/msdkQe6lPJqU4I kbweaYCMyqmYt1pSf0vi1vf1/0y58ebw3EbvkHv/hcNyj53WEvimykISJChFeTpbl4Dm MJAX+fO9Ne+X1285IwdPe7K7zzA0PoAZhlwG54gWx1QY31pPyaQzfWEi89Czgo1awBnY HLWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=BY/9DoMhT8HZDoRHSOR85JKwfuZs6vv/i0OS/chmxI0=; b=pFvJqzrbElXzunbVeTViB1V8dnwXP0GS9WBm94XEIByR1bJomolwRXr7hQ6TzFRAG+ 1eU4K1XJuwT+Es+SNKLQo9xz9bzqO1iHh/GMpteZ3PICMvfAil9YYtpEnVMiMFKxbRcu cm9YfHBXvay2zn0Iap7HvlK2PZVmadVthOkcTAUtNpqg7sv7e3KKeO89W/6pAxZaXdDw 2aBW/+lHmicVxRsQXBZ8yR+w4+iouN6M797+yUk5vpo6XvK7C6K9KHohmhvnZ5oGAK06 bu+ZXdzi2aFqZXdsp+ezwbrZ01PZSU/ffVwV7v1gcrKm21Qe3tBf7ufealOUrll7iN+F zdfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020a170902e94500b0017829e27195si11544847pll.521.2022.11.01.02.35.29; Tue, 01 Nov 2022 02:35:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbiKAJeo (ORCPT + 99 others); Tue, 1 Nov 2022 05:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230142AbiKAJeZ (ORCPT ); Tue, 1 Nov 2022 05:34:25 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8DE818E11; Tue, 1 Nov 2022 02:34:24 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N1lGN4RbhzmVT7; Tue, 1 Nov 2022 17:34:20 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 17:34:22 +0800 From: Kemeng Shi To: , CC: , , Subject: [PATCH 05/20] block, bfq: recover the "service hole" if enough budget is left Date: Tue, 1 Nov 2022 17:34:02 +0800 Message-ID: <20221101093417.10540-6-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221101093417.10540-1-shikemeng@huawei.com> References: <20221101093417.10540-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748285884990933455?= X-GMAIL-MSGID: =?utf-8?q?1748285884990933455?= If budget left is less than budget need by next request, the activated bfqq will be expired if it preempts the in-service queue. Avoid to cause useless overhead to check budget left is enough for next request. Signed-off-by: Kemeng Shi --- block/bfq-iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index be69b0e061f7..f4b4ba05f804 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -1623,7 +1623,7 @@ static bool bfq_bfqq_update_budg_for_activation(struct bfq_data *bfqd, * service. This would only cause useless overhead. */ if (bfq_bfqq_non_blocking_wait_rq(bfqq) && arrived_in_time && - bfq_bfqq_budget_left(bfqq) > 0) { + bfq_bfqq_budget_left(bfqq) >= bfq_serv_to_charge(bfqq->next_rq, bfqq)) { /* * We do not clear the flag non_blocking_wait_rq here, as * the latter is used in bfq_activate_bfqq to signal