From patchwork Tue Nov 1 09:34:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13589 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2847644wru; Tue, 1 Nov 2022 02:40:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5zD4oGmO3elB7fpIOL62C1rT15AQ9dSk5nc3wuPlNY30qT6vquMc7GW4sRa8iDU3yWELrN X-Received: by 2002:a17:906:cecc:b0:78d:408a:4a18 with SMTP id si12-20020a170906cecc00b0078d408a4a18mr88735ejb.261.1667295645300; Tue, 01 Nov 2022 02:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667295645; cv=none; d=google.com; s=arc-20160816; b=Irjx8f5gKVPCSYSGOXp178B88YgEAwIVozlIzTFe03gsakyXyjmQj/2sEF8OqwHDrF luMF/j++J1WiQKrsScK3bJqGSvnr0syBux2VZO3P+Ex1h4DtpLM50MzSEy1HyDFjMNEx MDS2Yg1anrc1mI1Ba4yae5bOY+SV/Z1JgnYLZU+Bc1YLJt/RQA5Wnbj9rrFVpHDWxV40 Ks3ssagOyaeQVXmLOsAoRvtq/e3La6dAXUvn1IDxUIbWZmeipYRVria4ojq7HOz1a+ng yfS8VrAuEtb+HjhX+Xi2IERyes+aEmTyAhEWZCalwPV57IuyGNjQmTvWMmo1H8yNmv6G eHzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Ikn10qeC2zv7iWipkTXziQpW+TINbgrgyaqH4nEVTi0=; b=G9c+R2yo8qvo6LYduMIXarfNqrXwSCQ5dWTyJ473QQC0WxpoP5sJWIRPXFZ5xZWY8c X6Tfda58vEC7Yn3M3OgvGQXozd7Zy/p97ZHeyX7he/FjMPEgC5VjV99+7o3Ss3r4sx0P Y/HkB8IAQWwW3pmhwt6t8/sqhVHmNAC7ydcsFJ1UDlXwKXi3K6g98cYVX7Dr5zIY6meB 7ANiwwNAihs8Xg/fLSNI/DKulwaHGoVwANW6zBMli262qKvCpBP7z4CMgtdC4frJ6HOg 3GZEko1mv/+FGZLxqRhvtpB9IyfgXP0GcDhVvD9olBRia01RfT+kE+0WhcgtDAvHYMaV nuwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020a1709064a0a00b00780a882d337si8648326eju.480.2022.11.01.02.40.21; Tue, 01 Nov 2022 02:40:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbiKAJft (ORCPT + 99 others); Tue, 1 Nov 2022 05:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbiKAJex (ORCPT ); Tue, 1 Nov 2022 05:34:53 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 391AC19002; Tue, 1 Nov 2022 02:34:33 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N1lGX6lj2zmVYP; Tue, 1 Nov 2022 17:34:28 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 17:34:30 +0800 From: Kemeng Shi To: , CC: , , Subject: [PATCH 19/20] block, bfq: remove unnecessary local variable __bfqq in bfq_setup_merge Date: Tue, 1 Nov 2022 17:34:16 +0800 Message-ID: <20221101093417.10540-20-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221101093417.10540-1-shikemeng@huawei.com> References: <20221101093417.10540-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748286198937023973?= X-GMAIL-MSGID: =?utf-8?q?1748286198937023973?= We could traversal bfqq->new_bfqq list without a local variable easily and intuitively. So remove unnecessary local variable __bfqq. Signed-off-by: Kemeng Shi --- block/bfq-iosched.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index d3f4d995f84a..589ab59abcf5 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -2741,7 +2741,6 @@ static struct bfq_queue * bfq_setup_merge(struct bfq_queue *bfqq, struct bfq_queue *new_bfqq) { int process_refs, new_process_refs; - struct bfq_queue *__bfqq; /* * If there are no process references on the new_bfqq, then it is @@ -2753,10 +2752,9 @@ bfq_setup_merge(struct bfq_queue *bfqq, struct bfq_queue *new_bfqq) return NULL; /* Avoid a circular list and skip interim queue merges. */ - while ((__bfqq = new_bfqq->new_bfqq)) { - if (__bfqq == bfqq) + while ((new_bfqq = new_bfqq->new_bfqq)) { + if (new_bfqq == bfqq) return NULL; - new_bfqq = __bfqq; } process_refs = bfqq_process_refs(bfqq);