diff mbox series

[RESEND,v2] staging: most: dim2: hal: aligning function parameters

Message ID 20221101080006.GA63438@rdm
State New
Headers
Series [RESEND,v2] staging: most: dim2: hal: aligning function parameters |

Commit Message

UMWARI JOVIAL Nov. 1, 2022, 8 a.m. UTC 
  According to Linux Kernel Coding Style, lines should not end with a '('
Fix-issue reported by checkpatch.pl script.

Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---

Changes in v2:
    1.Resending this patch because it was sent multiple times earlier.No
      functional changes.

 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Julia Lawall Nov. 1, 2022, 8:39 a.m. UTC | #1 
On Tue, 1 Nov 2022, UMWARI JOVIAL wrote:

> According to Linux Kernel Coding Style, lines should not end with a '('
> Fix-issue reported by checkpatch.pl script.

How about something like "To improve readability, start the list of
function parameters on the same line as the function name.  Issue reported
by checkpatch."

That would more clearly explain the intent behind the change.

julia


>
> Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> ---
>
> Changes in v2:
>     1.Resending this patch because it was sent multiple times earlier.No
>       functional changes.
>
>  drivers/staging/most/dim2/hal.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
>  		dim2_clear_ctr(ctr_addr);
>  }
>
> -static void dim2_configure_channel(
> -	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> -	u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
> +				   u16 hw_buffer_size, u16 packet_length)
>  {
>  	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
>  	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> --
> 2.25.1
>
>
>
UMWARI JOVIAL Nov. 1, 2022, 10:34 a.m. UTC | #2 
Will do. Thanks

On Tue, 1 Nov 2022 at 11:39, Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Tue, 1 Nov 2022, UMWARI JOVIAL wrote:
>
> > According to Linux Kernel Coding Style, lines should not end with a '('
> > Fix-issue reported by checkpatch.pl script.
>
> How about something like "To improve readability, start the list of
> function parameters on the same line as the function name.  Issue reported
> by checkpatch."
>
> That would more clearly explain the intent behind the change.
>
> julia
>
>
> >
> > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> > ---
> >
> > Changes in v2:
> >     1.Resending this patch because it was sent multiple times earlier.No
> >       functional changes.
> >
> >  drivers/staging/most/dim2/hal.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> > index a5d40b5b138a..6abe3ab2b2cf 100644
> > --- a/drivers/staging/most/dim2/hal.c
> > +++ b/drivers/staging/most/dim2/hal.c
> > @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
> >               dim2_clear_ctr(ctr_addr);
> >  }
> >
> > -static void dim2_configure_channel(
> > -     u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> > -     u16 packet_length)
> > +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
> > +                                u16 hw_buffer_size, u16 packet_length)
> >  {
> >       dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
> >       dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> > --
> > 2.25.1
> >
> >
> >
diff mbox series

Patch

diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@  static void dim2_clear_ctram(void)
 		dim2_clear_ctr(ctr_addr);
 }
 
-static void dim2_configure_channel(
-	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
-	u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+				   u16 hw_buffer_size, u16 packet_length)
 {
 	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
 	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);