From patchwork Mon Oct 31 18:02:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13391 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2461057wru; Mon, 31 Oct 2022 11:05:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ZzFUjStHARHolC6UsSYAOQq/C0nZOrp0VzShRLH60YWPQsVf8DsuRRj4n3FXxiYUQWVJD X-Received: by 2002:a17:90a:fa46:b0:20d:5efa:84fc with SMTP id dt6-20020a17090afa4600b0020d5efa84fcmr32553823pjb.20.1667239519485; Mon, 31 Oct 2022 11:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667239519; cv=none; d=google.com; s=arc-20160816; b=HfwwUjyekWQdEuJe03Q6YsurfqiZIRTCfwT464A5PAk8yPq0MBIARSRo5K7Uv5u7nI 6shHHeDuZr3v3yldJPWyESYTr0xf2vTiEVGNrC8aVM55BZHsFwx953v3zuZZQ8TpXnV/ 3SJ3UgPkwrl4BqsmGxUiG+PIF7/F6YwtKF9qVoVaG8mjYSD/AcdcAnNwOSrPH+jcE/Tq K0Linn2eH0VmupdtdAC/+Xw9G+xJtc5DE12QzWnY10OObmi/r1RJvqpjhvmyFlmeb8gg 0Jf7M1zV0npu7fv3ttZ5M1q9+WA7JBIU7FARIFJutwsLPhgkDN1BPWlsM5hcoYP2GgeR st2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3s4pb9x6UWl8wDrCXVlNY9pvnbipHUCj9wO5Sx7YnCg=; b=FGgrXiCSZcjy+ktZSpKnOhDtauci/QBLWUW6l0EInTJmwyJL2hkeVBiB+E8keKoA9u ZggaJn7i7QiWkP5Iuq3DcIzJR6FDDSgZy8J5eG5pnvjDFij85hOcayXKct49KR/q1mUu 1756pKaXDy1KIYcRSqV01tckAnUIbrd+Bzr/gTqrJjKOCJyUvJD1KzwNPP8Klo+L1sgq Gs+Dz5+x+KbagG6HHUwu/SCT0fJIsBdBAjmDg3EE8usiVi5ogxNwGrnledPNBJbW//Vp 5SRb+MXKaESNS8zX/ZtGO5+311jBQpUqL/BcW5iMoey0PdytoS4t95F9Rsu58m7Tnihi kY4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Aqxzg4D/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a63d00f000000b004588a5bd0bfsi9419512pgf.569.2022.10.31.11.05.06; Mon, 31 Oct 2022 11:05:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Aqxzg4D/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbiJaSEZ (ORCPT + 99 others); Mon, 31 Oct 2022 14:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbiJaSDx (ORCPT ); Mon, 31 Oct 2022 14:03:53 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFCE913E2E for ; Mon, 31 Oct 2022 11:03:43 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id h2so11365988pgp.4 for ; Mon, 31 Oct 2022 11:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3s4pb9x6UWl8wDrCXVlNY9pvnbipHUCj9wO5Sx7YnCg=; b=Aqxzg4D/i1JrHY1gvTUikcKWYvNIR6/SOWTFirfsyknenpTiNExSaqMPOO4XTOGMr0 WjaDMhmDlSBJFRherP07thMkDv9uP+ytT5h5rOISFFZfNOFMDV3dcQb3AOJoxziDHC+E aAg446XXtI5x1pD2GSVM/M9gsGM3Q7t49dONxrBYaSSRdpHjZwMhxxv+/dKs1WM3vZmv ez3Wo8Z7SEIaD4GAmyrhJwYWHha71PE38otRjY3zU9gjAae1GRWd/vgCujig7aX3uFP1 pDwfXQmLAJNarMjlLz7QQRiC30fJ8d0aTD4Bu3a4QfMpbHg8GU/5QC94xE889PcLnOZc XWlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3s4pb9x6UWl8wDrCXVlNY9pvnbipHUCj9wO5Sx7YnCg=; b=yTE+IkBXiW6jjsh2Z3r4WN5pCRg5mALDyW0PJGsQQDW/IWAHFHRABUbEuGMTInX5A4 M0vsu4efXURZTRVmuqU3sLgj7ECCb4cRErYvUrahdZmhVpNZUgK9XZS4pxfEsGnq+IUB uriIau6Wvfnas1zVlqEMHiy46l07uoz9kRc2WfX11tKrKeO3k+0lkUxZpNkGNEEXLCp9 zBUWYzfpu7uvRl/6nQiw91Binl4d6vLCkPKMwaXq0VlPINFHbb6N87qJJ7sXT0ZGWbHU rC7laMfz1cqeyIv2XlmrCtCdrl8a6Ld6rsEEe3IYtUG8RBPqmPlV7l1ER34YeVPwpYx6 D0Hw== X-Gm-Message-State: ACrzQf1unc+fweuGnY93Ucdzjr4pTJN9S2GVoAzt7k/PwRSmxt3uzL2o nAjEEvRd7pHTfmJGxewkl2ZM X-Received: by 2002:a63:e218:0:b0:448:5163:478f with SMTP id q24-20020a63e218000000b004485163478fmr13962942pgh.415.1667239423271; Mon, 31 Oct 2022 11:03:43 -0700 (PDT) Received: from localhost.localdomain ([117.193.209.221]) by smtp.gmail.com with ESMTPSA id q14-20020a170902a3ce00b00186c6d2e7e3sm4742224plb.26.2022.10.31.11.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 11:03:42 -0700 (PDT) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org, quic_cang@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, dmitry.baryshkov@linaro.org, ahalaney@redhat.com, Manivannan Sadhasivam Subject: [PATCH v2 09/15] scsi: ufs: ufs-qcom: Remove un-necessary WARN_ON() Date: Mon, 31 Oct 2022 23:32:11 +0530 Message-Id: <20221031180217.32512-10-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221031180217.32512-1-manivannan.sadhasivam@linaro.org> References: <20221031180217.32512-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748227346528152097?= X-GMAIL-MSGID: =?utf-8?q?1748227346528152097?= In the reset assert and deassert callbacks, the supplied "id" is not used at all and only the hba reset is performed all the time. So there is no reason to use a WARN_ON on the "id". Signed-off-by: Manivannan Sadhasivam Reviewed-by: Andrew Halaney --- drivers/ufs/host/ufs-qcom.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 7cd996ac180b..8bb0f4415f1a 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -895,8 +895,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) { struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); - /* Currently this code only knows about a single reset. */ - WARN_ON(id); ufs_qcom_assert_reset(host->hba); /* provide 1ms delay to let the reset pulse propagate. */ usleep_range(1000, 1100); @@ -908,8 +906,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) { struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); - /* Currently this code only knows about a single reset. */ - WARN_ON(id); ufs_qcom_deassert_reset(host->hba); /*