From patchwork Mon Oct 31 14:25:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: drake@draketalley.com X-Patchwork-Id: 13270 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2349676wru; Mon, 31 Oct 2022 07:35:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM76GhZU/m288vuUcLb84gjikHBkoy13/SYuDqBEuzibXZ4ettUf2BOHVMYU7NAnbLWQ7wUM X-Received: by 2002:a17:907:7f92:b0:78d:ed9c:d86f with SMTP id qk18-20020a1709077f9200b0078ded9cd86fmr12974298ejc.251.1667226920872; Mon, 31 Oct 2022 07:35:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667226920; cv=none; d=google.com; s=arc-20160816; b=Sk/dxrxmTCJ9nWAEFAvuBPHi9O/xj/4AjZpppWeCmDXHe7EagdX8sS5y3aV0HNdmgv A+i/EAJQkcz8ziyVRVudoXFDGGjxhcBwkm6TMEKbVJrWT9qCDU6EFwzN9tsK69nnSYG2 n+g5OUK7n7FcXZN82OhiNbBvrh36wek/m3fM9QfaGl+g/vnYkQqcrVM/DLug/hKdMLv4 4tnaeO6FWTvohwmvuAu8wMeDT+Cn5OcsfM8n5Eu43bl3E0ymLkPjf0ZWw7oUZmbe+77M hfbTZeXjfdQ+2GIBP094mxxRH94fKszW7njLRtQeI/ZxxC2wyIYh8Bs7OLm2N+7rtzl/ UdPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=r5Bh0x+yP3Enw40ZrvMyeMtrc6N5VMiX+6ju3M/Qv4Y=; b=SYqBLukUIsAZcBGUOIkhzcd93mUQBGUqsQiDoE4G4Gj7VazDlmXXLBI77oYFGnRGOq 99wLMdI4XDCUKoziVjmCDAPzfhmJU2EARAcoJINfq+0HT0eSBvcDYToYQHaG/YuU2XHD dwuBnRbKSkGSlch16yS461Q0J9LijlUJWksqv92PPjx9f7JJcWY8dRXZL3COUE9RPS0z 6dUvmn9jltKf/wPAvZWUqfpT3r3aw6BeEvDP696RozooAyaW6qxdkrv5v8LUYfiRlIFq U9/7++4ravFNJgc0FgsRlza/8tlYLKeZYcMMvdMVRErraJ11zdEVq180hWtK8pS3Dtoe jBfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t16-20020a056402241000b004534c7d4ebfsi8212222eda.434.2022.10.31.07.34.57; Mon, 31 Oct 2022 07:35:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbiJaOdF (ORCPT + 99 others); Mon, 31 Oct 2022 10:33:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbiJaOc5 (ORCPT ); Mon, 31 Oct 2022 10:32:57 -0400 Received: from mail.draketalley.com (mail.draketalley.com [3.213.214.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6671F58F; Mon, 31 Oct 2022 07:32:55 -0700 (PDT) Received: from pop-os.lan (cpe-74-72-139-32.nyc.res.rr.com [74.72.139.32]) by mail.draketalley.com (Postfix) with ESMTPSA id 9613655DD1; Mon, 31 Oct 2022 14:25:30 +0000 (UTC) From: drake@draketalley.com To: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Drake Talley Subject: [PATCH 1/3] staging: qlge: Separate multiple assignments Date: Mon, 31 Oct 2022 10:25:14 -0400 Message-Id: <20221031142516.266704-2-drake@draketalley.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221031142516.266704-1-drake@draketalley.com> References: <20221031142516.266704-1-drake@draketalley.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_SOFTFAIL, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748214135647584724?= X-GMAIL-MSGID: =?utf-8?q?1748214135647584724?= From: Drake Talley Adhere to coding style. Reported by checkpatch: > CHECK: multiple assignments should be avoided > #4088: FILE: drivers/staging/qlge/qlge_main.c:4088 > CHECK: multiple assignments should be avoided > #4108: FILE: drivers/staging/qlge/qlge_main.c:4108: Signed-off-by: Drake Talley --- drivers/staging/qlge/qlge_main.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 1ead7793062a..8c1fdd8ebba0 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -4085,7 +4085,12 @@ static struct net_device_stats *qlge_get_stats(struct net_device int i; /* Get RX stats. */ - pkts = mcast = dropped = errors = bytes = 0; + pkts = 0; + mcast = 0; + dropped = 0; + errors = 0; + bytes = 0; + for (i = 0; i < qdev->rss_ring_count; i++, rx_ring++) { pkts += rx_ring->rx_packets; bytes += rx_ring->rx_bytes; @@ -4100,7 +4105,10 @@ static struct net_device_stats *qlge_get_stats(struct net_device ndev->stats.multicast = mcast; /* Get TX stats. */ - pkts = errors = bytes = 0; + pkts = 0; + errors = 0; + bytes = 0; + for (i = 0; i < qdev->tx_ring_count; i++, tx_ring++) { pkts += tx_ring->tx_packets; bytes += tx_ring->tx_bytes;