From patchwork Mon Oct 31 12:13:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kajetan Puchalski X-Patchwork-Id: 13253 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2276690wru; Mon, 31 Oct 2022 05:16:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6I5GRt0cj/aYRQmA57HUrW5Oejk2D9RavCG0ZpHrC854XPjjdxhViuh+wTJ3EU+5wxOpnr X-Received: by 2002:a17:90a:e81:b0:213:d1ce:2580 with SMTP id 1-20020a17090a0e8100b00213d1ce2580mr7986730pjx.162.1667218582454; Mon, 31 Oct 2022 05:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667218582; cv=none; d=google.com; s=arc-20160816; b=xTsYAlM3Aw2Nhh3w5BVXkUu7EjoI4iicxObOoOuZffce5ubF9PZQs08IuxmGW2aDig NsYBO7reKzPI5WpNycHPWTN/N3LYyiBQVPfmkdx49fKVgIF/wP5N51rPG4P3arR2rS8G htDGnvbBqXo3b577W6XNcftDfCZp+G9JTEiTfYLQfNjk0YGkba9LfbrSFYcibQn9d0nV NJy0DRnDIymP4ObUwR09nSK+oJbFP1pKehEM+PDqsx/XaPQ/xo85opvjAmd/nvth6l28 vOvoU5yxUFuSRFpPvVq4svvRK07YSOB3/cNzYxVLjYLZK/jlFy/ED8DC2czvDwStxFTh qgsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=anVv06K4voEx8glJ2FPNjL9SygdM/whii5BW5GdM7ks=; b=SHDcgCrKtBdAcRwKo0ZGMwvSoRJ6dbjqX/QkPO71LTzBHOESKGeNBsYAZ6qZhJZv+1 h5T+jIRb7s0alLT9Z7EEHA8P7xZhKrfMreXcUGQE3gAHG0GjxM9XB8F+OyXriofoymlu bBvj8oDWkbemYXs3fB3PEC5651/JrxmenbaQvtBKZ3p3/F4muly+wfY9b7VB8/82PPGV aBHPsBEaPcJLkwa5Y4VYAumL2Gx6dh9U6d7sE6KKwNxnMuobTKL1dNa6LzZLVZKKjcnY d6eY4NAtvjZsUrVwBSPlUU998eIPDud4XMOx1FP2EiC4eqzeF46ry3NiTA0BetaEcUun sVAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x9-20020a17090aca0900b00205d6cc25cfsi7607792pjt.72.2022.10.31.05.16.08; Mon, 31 Oct 2022 05:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231273AbiJaMOw (ORCPT + 99 others); Mon, 31 Oct 2022 08:14:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231253AbiJaMOn (ORCPT ); Mon, 31 Oct 2022 08:14:43 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EE70CF011; Mon, 31 Oct 2022 05:14:31 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DC3623A; Mon, 31 Oct 2022 05:14:38 -0700 (PDT) Received: from e126311.arm.com (unknown [10.57.68.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 931D33F5A1; Mon, 31 Oct 2022 05:14:29 -0700 (PDT) From: Kajetan Puchalski To: rafael@kernel.org Cc: daniel.lezcano@linaro.org, lukasz.luba@arm.com, Dietmar.Eggemann@arm.com, dsmythies@telus.net, yu.chen.surf@gmail.com, kajetan.puchalski@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v3 1/2] cpuidle: teo: Optionally skip polling states in teo_find_shallower_state() Date: Mon, 31 Oct 2022 12:13:13 +0000 Message-Id: <20221031121314.1381472-2-kajetan.puchalski@arm.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20221031121314.1381472-1-kajetan.puchalski@arm.com> References: <20221031121314.1381472-1-kajetan.puchalski@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748205392077597175?= X-GMAIL-MSGID: =?utf-8?q?1748205392077597175?= Add a no_poll flag to teo_find_shallower_state() that will let the function optionally not consider polling states. This allows the caller to guard against the function inadvertently resulting in TEO putting the CPU in a polling state when that behaviour is undesirable. Signed-off-by: Kajetan Puchalski --- drivers/cpuidle/governors/teo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c index d9262db79cae..e2864474a98d 100644 --- a/drivers/cpuidle/governors/teo.c +++ b/drivers/cpuidle/governors/teo.c @@ -258,15 +258,17 @@ static s64 teo_middle_of_bin(int idx, struct cpuidle_driver *drv) * @dev: Target CPU. * @state_idx: Index of the capping idle state. * @duration_ns: Idle duration value to match. + * @no_poll: Don't consider polling states. */ static int teo_find_shallower_state(struct cpuidle_driver *drv, struct cpuidle_device *dev, int state_idx, - s64 duration_ns) + s64 duration_ns, bool no_poll) { int i; for (i = state_idx - 1; i >= 0; i--) { - if (dev->states_usage[i].disable) + if (dev->states_usage[i].disable || + (no_poll && drv->states[i].flags & CPUIDLE_FLAG_POLLING)) continue; state_idx = i; @@ -469,7 +471,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, */ if (idx > idx0 && drv->states[idx].target_residency_ns > delta_tick) - idx = teo_find_shallower_state(drv, dev, idx, delta_tick); + idx = teo_find_shallower_state(drv, dev, idx, delta_tick, false); } return idx;