From patchwork Mon Oct 31 11:43:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13228 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2262009wru; Mon, 31 Oct 2022 04:45:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM68FIfLMTEANt2G2Pdeel5Me31nzTwCnKUKRO5o0Zm5dIb/YY6GqetS5sYMSrg78YURO0yo X-Received: by 2002:a05:6402:d05:b0:462:9b84:3299 with SMTP id eb5-20020a0564020d0500b004629b843299mr12866483edb.270.1667216753874; Mon, 31 Oct 2022 04:45:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667216753; cv=none; d=google.com; s=arc-20160816; b=NQwIzTToQs4/DgN+KixDS65z9VlTDFiNrfU0Y4CYjjqqj11nCAWHdZS9kJRMQmKLXs pHGQxLpH9aSLXO9TtARY2jPULaepKkG6lHL/nMi1Sgx4PcojkefrxUeHcvu+5ZcQF2Hn 3mWYOJutF0b/Alp21+YBtTl2yKwaXv5alrrHuT5fF925Rxm0RCMv1s7AUQWZVcwijhMy NMn515rC1NLnCvukiY2kfezhdCaVXMhhApYTxt0o6+XK2OgDCcLZubFLLsiUOw7iLKxh eQpn9fQwnCAJFr3UJS8Ud1UOZklDlh5/Fgx9BWIBQ/itIM6UR0TrJEqsx+r4D9dr9iX4 EqbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=buXHvJyH1b3P0e9TFw1QIL9Uv6ozxn4CxA8bY4SJG4w=; b=EA2QbXWp6P/PyKskEN3rg29QIZtFWZcN5oIAOW2L2xrcQ6rIMuiHspymnJPY6qz4YB eQAp84uGb2wMPP9u6JmCOBmo+H8X0x0RW0lb6nHAE59aVxbn+hFfq0ax3JpKK1SeSFFf zCC1XCPzBNAhgOhQdzLQnw95uK/5CVVpd2g7MOxYgjO/7IqZhTLKnTPRvs/dulSbcHNF +RiDyclP2HLVhWSk154Y0OIVz3kwOlNdeBLBnpYZL0EAcBRu4UyVUY+CIWoE1RJ2kWjr C39NBZ83P4Uis1inRCx/iwVdq+ko1WGADZAOsNvy/llzDrEdcbdorJMhMMaZlNk0645V sc0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=in52tpEP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g29-20020a056402321d00b00462e597dc46si7447023eda.301.2022.10.31.04.45.29; Mon, 31 Oct 2022 04:45:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=in52tpEP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbiJaLoY (ORCPT + 99 others); Mon, 31 Oct 2022 07:44:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231157AbiJaLoJ (ORCPT ); Mon, 31 Oct 2022 07:44:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F176CEE0D; Mon, 31 Oct 2022 04:44:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9FF72B815F3; Mon, 31 Oct 2022 11:43:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18A8BC433D6; Mon, 31 Oct 2022 11:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667216638; bh=ZKQMpX4qGKyQLBywqky+QWUckJGF7SXW7qUOTP5qfrs=; h=From:To:Cc:Subject:Date:From; b=in52tpEP7HlAbsUsm/FUBDmublUfP6UNxCimfAFIQtbBMo/aXKnzby5aC2qgVck8w +QcV2jPFnn5eivH2VvbOPHRTDvz854SAqDwKMy1WEAoZudHrkiGJh+9DiZnZfccUyk Rnvv5eziSyFNzZj9rBBnCGc/LelaQ8wiIwSZEuHCBQfB4v0cy2CLQ8kT3NDTiiFVcn QxU8VBqaAJBApB5TiB+rpY3m+b0omSCfntGtcHMIPEYuWfhZeV7f5PmZl6b/NLPx9W oBl42H+8kGM4s7CGVkKWrlYRGhlnttUgp433fPDJ7YPhMgpyLD01pBCzk8V7kjsyPo 72P2ACbchICpw== From: "Jiri Slaby (SUSE)" To: aelior@marvell.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Martin Liska , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: [PATCH] qed (gcc13): use u16 for fid to be big enough Date: Mon, 31 Oct 2022 12:43:54 +0100 Message-Id: <20221031114354.10398-1-jirislaby@kernel.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748203474777329111?= X-GMAIL-MSGID: =?utf-8?q?1748203474777329111?= gcc 13 correctly reports overflow in qed_grc_dump_addr_range(): In file included from drivers/net/ethernet/qlogic/qed/qed.h:23, from drivers/net/ethernet/qlogic/qed/qed_debug.c:10: drivers/net/ethernet/qlogic/qed/qed_debug.c: In function 'qed_grc_dump_addr_range': include/linux/qed/qed_if.h:1217:9: error: overflow in conversion from 'int' to 'u8' {aka 'unsigned char'} changes value from '(int)vf_id << 8 | 128' to '128' [-Werror=overflow] We do: u8 fid; ... fid = vf_id << 8 | 128; Since fid is 16bit (and the stored value above too), fid should be u16, not u8. Fix that. Cc: Martin Liska Cc: Ariel Elior Cc: Manish Chopra Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: netdev@vger.kernel.org Signed-off-by: Jiri Slaby (SUSE) --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c index 5250d1d1e49c..86ecb080b153 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c @@ -1972,9 +1972,10 @@ static u32 qed_grc_dump_addr_range(struct qed_hwfn *p_hwfn, u8 split_id) { struct dbg_tools_data *dev_data = &p_hwfn->dbg_info; - u8 port_id = 0, pf_id = 0, vf_id = 0, fid = 0; + u8 port_id = 0, pf_id = 0, vf_id = 0; bool read_using_dmae = false; u32 thresh; + u16 fid; if (!dump) return len;