From patchwork Sun Oct 30 17:33:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 13025 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1894057wru; Sun, 30 Oct 2022 10:36:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6XLZXezFcqTvv93GiWn/5fs6TkeO/zlekMiQ8TCwTekqPo7lZRE+vXoOhfBxWVbevCbPrq X-Received: by 2002:a05:6402:406:b0:458:a47:d14c with SMTP id q6-20020a056402040600b004580a47d14cmr9832516edv.41.1667151361973; Sun, 30 Oct 2022 10:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667151361; cv=none; d=google.com; s=arc-20160816; b=N2Zb9PRzagQbj6nBzd3+WVG19vRWHWMc41Yep6QSdRzhv/DQyoEFAx4jOj0rFH6NGi c2lfAdqkD6kGvCOYTAdFltXJmOhEFzI8K1q8jEqxNI3fauQWTG8hzIq/ul+xFDj3woC7 qlN7tK4N8ECVqqKzMCLkd9iElGbqiXNjrshutYA7XrDY+RK9c+APzab9XZ0MyBfQagZ4 oZ8dqNPdJequ2TsJMNBJ8WqBD0SRfjjSMTXKjkG/r6wfgMENKcefiKysyQblbkLxLUM3 aHQxIU31Wcqjhg5BYbne3nA6J+aTyXakfIGRUleCk8jNQ1SwwDo1dxRyDgdbhYIf1F+i s8WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yBnzgeOVv70gnxTpcK6WQn8BCY9lk3Ouvi6oxwV0GhY=; b=twyJIOfhphW5W8BntR5GHZmqCHFLnA1d/YwOW8eZs3mX7ZBVtePRP0UiUSpTihrW0m c/DhPmxzso4lbAY2oHRoGlJeW3Ym3Tla1eutBhBimVMq/l9gFYwn12qg4LRWfzsME38j 5y3haeZZFY/fKu5k3pH1JDOlEMlrKSt11JzzT7XU+Iko2XznfMvPi55nl8vzqN2H32tc iD4zM6i8iQ0fqt9cSuniIyPYlPR5TSiEqucm/DvRV32MSEgoq4uaITlR+z6BkrNfyxM3 08KRjSnEnV3+tDNg3IE4wJtyM3dYHi8UAbv2uq+o1I01vHfEl4Gqh8oWLEwqGSWtaFSy Nmjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn1-20020a17090794c100b00791a3dd01b6si5812067ejc.864.2022.10.30.10.35.38; Sun, 30 Oct 2022 10:36:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbiJ3ReW (ORCPT + 99 others); Sun, 30 Oct 2022 13:34:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbiJ3Rdx (ORCPT ); Sun, 30 Oct 2022 13:33:53 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F7BAA44F for ; Sun, 30 Oct 2022 10:33:52 -0700 (PDT) Received: from ipservice-092-217-067-184.092.217.pools.vodafone-ip.de ([92.217.67.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1opCBx-000469-Ey; Sun, 30 Oct 2022 18:33:49 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 11/13] staging: r8188eu: remove return value from on_action_public_default Date: Sun, 30 Oct 2022 18:33:24 +0100 Message-Id: <20221030173326.1588647-12-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221030173326.1588647-1-martin@kaiser.cx> References: <20221030173326.1588647-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748134906333490019?= X-GMAIL-MSGID: =?utf-8?q?1748134906333490019?= The only caller of on_action_public_default does not check the return value. We can make it a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index b395457a6a60..f5923792f067 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3788,22 +3788,15 @@ static void on_action_public_vendor(struct recv_frame *precv_frame) on_action_public_p2p(precv_frame); } -static unsigned int on_action_public_default(struct recv_frame *precv_frame) +static void on_action_public_default(struct recv_frame *precv_frame) { - unsigned int ret = _FAIL; u8 *pframe = precv_frame->rx_data; u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr); u8 token; token = frame_body[2]; - if (rtw_action_public_decache(precv_frame, token) == _FAIL) - goto exit; - - ret = _SUCCESS; - -exit: - return ret; + rtw_action_public_decache(precv_frame, token); } static void on_action_public(struct adapter *padapter, struct recv_frame *precv_frame)