From patchwork Sun Oct 30 17:33:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 13023 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1894021wru; Sun, 30 Oct 2022 10:35:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6VbZrp4eXNBkFkLGMAApZqfhlAPF7T7ge8Gqrq2gysOtAdZRHdgRIzVLd1ZHSRisCh/D2w X-Received: by 2002:a05:6402:12d1:b0:463:3f0c:be02 with SMTP id k17-20020a05640212d100b004633f0cbe02mr3546630edx.239.1667151356266; Sun, 30 Oct 2022 10:35:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667151356; cv=none; d=google.com; s=arc-20160816; b=sgwuapV+LRXY0QpM9AqciBH7MGxSahs1oL/yimLfgWQX1U5CidBl1vpzwMlxlQafmb bvEfiP9g+3cilIxRn7OyK8uP0+OQfSnoWikHHlBCJb9AM9LKwajWQDTqZ2RnD+cRpQk+ 7QZARleTQczHJN2EwQ3SbT8GdE5+Z49wWHT93xIRUICVx2F+eYMy7ulcKJO4a3Tijk4m WTQMIyjfWhrM6xHvRLSSeUcLGU6K7HNRKY1ic1zs7ysA5B+Hm93Zr0/JQ2j+dy9/pjVH Rb3uirFeIVwwqV5+VkBcG87SzKQPpE09s22EsdDUzFUSfHFXeYZWvfeIJvOIdnGBF/yN v1dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DMZUsJNikyQLrk20aOH886hKhnIgPHP49kGmFXo+Dg0=; b=lYHQMOvypDtw7QnTYQXQMTKUluOmqpIKJyL+6Zu2czn67rK4djDRhcCQOdQcwAQPl8 HmbEywvvUA2SPEBviq3Pd99tGIih3qIq29eh5brpgu35/DyiyuVb//mLj+mpnQ49pimS Xc0ziXT7Ye/75MaPslV9/i3fWW4IiCYA83zzq1sQbfY6Qe9lX9BDfkQh1RwFeOK7AZpY CZh8uesGO5TGPIpzxl4GmjUDwQI2eTFfLOIluHk4tOzq4zX/auwgmPwiooo956ndjojx GtMW+BGB3COXLFoe+Z3QhChcePt+ETjTpr5rt6OwNiWaErUE3/+wKflCvPtwFQgI6GKn PRDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r2-20020a50aac2000000b00461f2136969si5198428edc.242.2022.10.30.10.35.31; Sun, 30 Oct 2022 10:35:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiJ3ReQ (ORCPT + 99 others); Sun, 30 Oct 2022 13:34:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbiJ3Rdw (ORCPT ); Sun, 30 Oct 2022 13:33:52 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC7CA44D for ; Sun, 30 Oct 2022 10:33:51 -0700 (PDT) Received: from ipservice-092-217-067-184.092.217.pools.vodafone-ip.de ([92.217.67.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1opCBw-000469-MM; Sun, 30 Oct 2022 18:33:48 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 10/13] staging: r8188eu: remove return value from on_action_public_vendor Date: Sun, 30 Oct 2022 18:33:23 +0100 Message-Id: <20221030173326.1588647-11-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221030173326.1588647-1-martin@kaiser.cx> References: <20221030173326.1588647-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748134900228465573?= X-GMAIL-MSGID: =?utf-8?q?1748134900228465573?= The only caller of on_action_public_vendor does not check the return value. We can make it a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index b3cef3504ad3..b395457a6a60 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3779,17 +3779,13 @@ static unsigned int on_action_public_p2p(struct recv_frame *precv_frame) return _SUCCESS; } -static unsigned int on_action_public_vendor(struct recv_frame *precv_frame) +static void on_action_public_vendor(struct recv_frame *precv_frame) { - unsigned int ret = _FAIL; u8 *pframe = precv_frame->rx_data; u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr); - if (!memcmp(frame_body + 2, P2P_OUI, 4)) { - ret = on_action_public_p2p(precv_frame); - } - - return ret; + if (!memcmp(frame_body + 2, P2P_OUI, 4)) + on_action_public_p2p(precv_frame); } static unsigned int on_action_public_default(struct recv_frame *precv_frame)